Files
Umbraco-CMS/tests/Umbraco.Tests.UnitTests/Umbraco.Core/ShortStringHelper/StylesheetHelperTests.cs

228 lines
6.2 KiB
C#
Raw Normal View History

// Copyright (c) Umbraco.
// See LICENSE for more details.
using System.Linq;
using NUnit.Framework;
using Umbraco.Cms.Core.Strings.Css;
Merge release/10.0.0 into v10/dev commit e0aa430d4cfbb5de61e7c223167331cfd0c1533d Author: Paul Johnson <pmj@umbraco.com> Date: Thu May 19 10:00:57 2022 +0100 Fix typo in pipeline yaml commit 2ec450f2d6d97f828e70d0faad9d205c0a5dd104 Author: Paul Johnson <pmj@umbraco.com> Date: Thu May 19 09:14:47 2022 +0100 Fix yaml conditions commit c2d548039a0db01a9ab85327aa3c7bdd36a73af1 Author: Paul Johnson <pmj@umbraco.com> Date: Thu May 19 09:02:50 2022 +0100 Azure pipeline refactor (#12428) * Skip symbols for Umbraco.Templates * Resolve some test issues + Fixed whitespace dependant tests to pass regardless of build OS vs run OS. + Snap dictionary tests were failing when Configuration was release + Removed hardcoded baseUrl from one of the acceptance tests * Move docfx setup to ./build and fix * Update UI docs title * Added dockerfile that can be used when running the acceptance tests. * Take explicit dependency on System.Security.Cryptography.Pkcs * Refactor ci/cd pipeline commit ee8359af75cd576e7ab054db2a2ce6ace68452fa Author: Mole <nikolajlauridsen@protonmail.ch> Date: Thu May 19 09:57:21 2022 +0200 V10: Reintroduce appsettings-schema.json (#12416) * Reintroduce language files tests (#12367) * Reintroducing language files tests * Fix casing * Update tests/Umbraco.Tests.UnitTests/Umbraco.Core/EmbeddedResources/LanguageXmlTests.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Change Umbraco.Cms and Umbraco.Templates nuspecs to csproj * Remove Umbraco.Templates from VerifyNuGet step * Remove duplicate and unnecessary properties * Generate json schema on build * Add targets file * Gitignore auto generated appsettings schema * Fix build not copying file * Use the new path in appsettings * Update copy message * Build json schema as release * Update json schema options Otherwise just running the project will put the file in the wrong place * Generate schema if it doesn't exist in Web.Ui * Update json schema options Otherwise just running the project will put the file in the wrong place Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com> Co-authored-by: Ronald Barendse <ronald@barend.se> commit dd617ede80a457b33cd1db65d1adf9f5806f7450 Author: Ronald Barendse <ronald@barend.se> Date: Thu May 19 09:51:11 2022 +0200 v10: Change Umbraco.Cms and Umbraco.Templates nuspecs to csproj (#12413) * Reintroduce language files tests (#12367) * Reintroducing language files tests * Fix casing * Update tests/Umbraco.Tests.UnitTests/Umbraco.Core/EmbeddedResources/LanguageXmlTests.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Change Umbraco.Cms and Umbraco.Templates nuspecs to csproj * Remove Umbraco.Templates from VerifyNuGet step * Remove duplicate and unnecessary properties Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com> Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> commit b83216876f07c2073e241fadab3c9f7a79c37a68 Author: Ronald Barendse <ronald@barend.se> Date: Thu May 19 08:36:04 2022 +0200 v10: Project template database/connection string improvements (#12407) * Add new connection-string-provider-name parameter * Use template value forms to correctly encode JSON values * Add new development-database-type parameter * Update package template and fix App_Plugins directory rename * Remove conflicting short parameter name * Lowercase framework parameter to align with MS templates * Cleanup default template settings * Write unattended install parameters when either connection string or development database is set * Include RootNamespace in UmbracoPackage template * Update Umbraco specific gitignore rules * Revert "Lowercase framework parameter to align with MS templates" This reverts commit 22de389272a7e119df569ec2e54190265f6d0ae0. * Add exclude-gitignore parameter * Update template schemas * Add minimal-gitignore parameter commit e40049dcf15ff6bf1fe91e56e3328fd9700a3a2a Author: Mole <nikolajlauridsen@protonmail.ch> Date: Wed May 18 15:22:51 2022 +0200 Fix domain for invariant content nodes (#12405) Co-authored-by: Elitsa Marinovska <elm@umbraco.dk> commit a3692b887ad0387fe5baace187ab2e12a1cb5c30 Author: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com> Date: Mon May 9 11:42:10 2022 +0200 Use SnippetCollection to when working with snippets (#12355) * Introducing a new Snippet type * Adding a SnippetCollection and SnippetCollectionBuilder * Using snippetCollection to get the snippets instead of fileService * Fixed fetching the correct content * Make ISnippet non-discoverable * Split the SnippetCollection into PartialViewSnippetCollection and PartialViewMacroSnippetCollection * Update CodeFileController to use the 2 snippet collections * Display the names with Empty.cshtml on top * Remove merging embedded snippets with custom snippets from ~\Umbraco.Web.UI\umbraco\PartialViewMacros\Templates folder for the Partial View Collection * Fix naming * Fix another naming * Cleanup + Use base items Co-authored-by: Bjarke Berg <mail@bergmania.dk> (cherry picked from commit 9326cc5fc64a85e8e7fc19ae7faa726e33c33480) commit 4f48a4937b1b2f05cd20b2200ae817675c88646d Author: patrickdemooij9 <patrickdemooij98@hotmail.com> Date: Fri Oct 8 11:18:00 2021 +0200 Cherry picked from 4c08b446842dd49e70bdc3d424d1f9d589126976 commit 4fdbfee5973c09c9678d3f13f2ecadb83cd0ff27 Author: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com> Date: Wed May 11 00:51:37 2022 +0200 Show nicer overlay when clicking block card for deleted element type (#12140) * Show nicer overlay when clicking block card for deleted element type * Cleanup * Remove stop-scrolling container * Use flex-start instead on start * Remove legacy flexbox fallback * Remove unnecessary hack * Use standard gap property instead * Localization of message * Fix translation * End sentence with a dot (cherry picked from commit ebb1dc21a91e08ad994bdd46ab2dd89ed0de3632) commit 3856bf82881820699e7ae214621a954559d7b578 Author: Henk Jan Pluim <henkjan.pluim@greenchoice.nl> Date: Mon Apr 25 10:02:06 2022 +0200 #fix 12254 return emptyresult (cherry picked from commit 7993d19c1b4ba2a6303ef90e7acbfb51971003f2) commit 7087c3d9f600082ee9ec33e262ca53bc59096a1e Author: Ronald Barendse <ronald@barend.se> Date: Tue May 17 12:59:01 2022 +0200 v10: Use ForceCreateDatabase during unattended install and extend GetUmbracoConnectionString extension methods (#12397) * Add extension methods to get the Umbraco connection string/provider name from configuration * Added tests for configuration extension methods. * Fix issue with InstallMissingDatabase and ForceCreateDatabase * Fix comments * Revert casing change in GenerateConnectionString * Re-add AddOptions (without config binding) to fix test * Update src/Umbraco.Core/Configuration/Models/ConnectionStrings.cs Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/ConnectionStrings.cs * Update src/Umbraco.Infrastructure/Runtime/RuntimeState.cs * Whitespace and documentation updates * Add DatabaseProviderMetadataExtensions * Filter before ordering * Replace DataDirectory placeholder when setting connection string Co-authored-by: Andy Butland <abutland73@gmail.com> Co-authored-by: Bjarke Berg <mail@bergmania.dk> (cherry picked from commit 8e6e262c7f0e3985014dd29cd635f2ac7a286b0f) commit e90bf26577dce293715d29058cce32683b67dc9f Author: Ronald Barendse <ronald@barend.se> Date: Tue May 17 07:33:54 2022 +0200 v10: Support System.Data.SqlClient provider name (#12408) * Add support for System.Data.SqlClient provider name * Only update connection string when required (cherry picked from commit e82bcb1b76f456fddcf97d3993acc9d665652796) commit fd0637c96d159db7f3f0ee0421b82771c50f3173 Author: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com> Date: Mon May 16 14:23:59 2022 +0200 Reintroduce language files tests (#12367) * Reintroducing language files tests * Fix casing * Update tests/Umbraco.Tests.UnitTests/Umbraco.Core/EmbeddedResources/LanguageXmlTests.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> (cherry picked from commit 2ed71a64ec8c548d3bab4e3500d4899db4cdc226)
2022-05-19 10:25:44 +01:00
using Umbraco.Cms.Tests.Common.Extensions;
using Umbraco.Extensions;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.ShortStringHelper;
[TestFixture]
public class StylesheetHelperTests
{
[Test]
public void Replace_Rule()
{
var css =
@"body {font-family:Arial;}/** Umb_Name: Test1 */ p { font-size: 1em; } /** umb_name: Test2 */ li {padding:0px;} table {margin:0;}";
var results = StylesheetHelper.ParseRules(css);
var result = StylesheetHelper.ReplaceRule(
css,
results.First().Name,
new StylesheetRule
{
Name = "My new rule",
Selector = "p",
Styles = "font-size:1em; color:blue;",
});
Assert.AreEqual(
@"body {font-family:Arial;}/**umb_name:My new rule*/
p{font-size:1em; color:blue;} /** umb_name: Test2 */ li {padding:0px;} table {margin:0;}".StripWhitespace(),
result.StripWhitespace());
}
[Test]
public void Append_Rule()
{
var css =
@"body {font-family:Arial;}/** Umb_Name: Test1 */ p { font-size: 1em; } /** umb_name: Test2 */ li {padding:0px;} table {margin:0;}";
var result = StylesheetHelper.AppendRule(
css,
new StylesheetRule { Name = "My new rule", Selector = "p", Styles = "font-size:1em; color:blue;" });
Assert.AreEqual(
@"body {font-family:Arial;}/** Umb_Name: Test1 */ p { font-size: 1em; } /** umb_name: Test2 */ li {padding:0px;} table {margin:0;}
/**umb_name:My new rule*/
p{font-size:1em; color:blue;}".StripWhitespace(),
result.StripWhitespace());
}
[Test]
public void Duplicate_Names()
{
var css = @"/** Umb_Name: Test */ p { font-size: 1em; } /** umb_name: Test */ li {padding:0px;}";
var results = StylesheetHelper.ParseRules(css);
Assert.AreEqual(1, results.Count());
}
// Standard rule stle
[TestCase("Test", "p", "font-size: 1em;", @"/**
Umb_Name: Test
*/
p {
font-size: 1em;
}")]
// All on one line, different casing
[TestCase("Test", "p", "font-size: 1em;", @"/** Umb_Name: Test */ p { font-size: 1em; }")]
// styles on several lines
[TestCase(
"Test",
"p",
@"font-size: 1em;
color:red; font-weight:bold;
text-align:left;",
@"/** umb_name: Test */ p { font-size: 1em;
color:red; font-weight:bold;
2017-07-20 11:21:28 +02:00
text-align:left;
}")]
// All on one line with no spaces
[TestCase("Test", "p", "font-size: 1em;", @"/**UMB_NAME:Test*/p{font-size: 1em;}")]
// Has a name with spaces
[TestCase("Hello world", "p", "font-size: 1em;", @"/**UMB_NAME:Hello world */p{font-size: 1em;}")]
// Every part on a new line
[TestCase("Test", "p", "font-size: 1em;", @"/**
umb_name:
Test
*/
p
{
font-size: 1em;
}")]
public void ParseRules_Parses(string name, string selector, string styles, string css)
{
// Act
var results = StylesheetHelper.ParseRules(css).ToArray();
// Assert
Assert.AreEqual(1, results.Length);
// Assert.IsTrue(results.First().RuleId.Value.Value.ToString() == file.Id.Value.Value + "/" + name);
Assert.AreEqual(name, results.First().Name);
Assert.AreEqual(selector, results.First().Selector);
Assert.AreEqual(styles.StripWhitespace(), results.First().Styles.StripWhitespace());
}
// No Name: keyword
[TestCase(@"/** Test2 */
p
{
font-size: 1em;
}")]
// Has a Name: keyword, but applies to 2 rules, so shouldn't parse
[TestCase(@"/** umb_name: Test2 */
p, h2
{
font-size: 1em;
}")]
// Has it's name wrapping over two lines
[TestCase("/** umb_name: Test\r\n2 */ p { font-size: 1em; }")]
[TestCase("/** umb_name: Test\n2 */ p { font-size: 1em; }")]
// Only a single asterisk
[TestCase("/* umb_name: Test */ p { font-size: 1em; }")]
// Has a name with spaces over multiple lines
[TestCase(@"/**UMB_NAME:Hello
world */p{font-size: 1em;}")]
public void ParseRules_DoesntParse(string css)
{
// Act
var results = StylesheetHelper.ParseRules(css);
// Assert
Assert.IsTrue(results.Any() == false);
}
[Test]
public void AppendRules_IsFormatted()
{
// base CSS
var css = Tabbed(
@"body {
#font-family:Arial;
}");
// add a couple of rules
var result = StylesheetHelper.AppendRule(
css,
new StylesheetRule { Name = "Test", Selector = ".test", Styles = "font-color: red;margin: 1rem;" });
result = StylesheetHelper.AppendRule(
result,
new StylesheetRule { Name = "Test2", Selector = ".test2", Styles = "font-color: green;" });
// verify the CSS formatting including the indents
Assert.AreEqual(
Tabbed(
@"body {
#font-family:Arial;
}
/**umb_name:Test*/
.test {
#font-color: red;
#margin: 1rem;
}
/**umb_name:Test2*/
.test2 {
#font-color: green;
}").NormalizeNewLines(),
result.NormalizeNewLines());
}
[Test]
public void ParseFormattedRules_CanParse()
{
// base CSS
var css = Tabbed(
@"body {
#font-family:Arial;
}
/**umb_name:Test*/
.test {
#font-color: red;
#margin: 1rem;
}
/**umb_name:Test2*/
.test2 {
#font-color: green;
}");
var rules = StylesheetHelper.ParseRules(css).ToArray();
Assert.AreEqual(2, rules.Count());
Assert.AreEqual("Test", rules.First().Name);
Assert.AreEqual(".test", rules.First().Selector);
Assert.AreEqual(
@"font-color: red;
margin: 1rem;".NormalizeNewLines(),
rules.First().Styles.NormalizeNewLines());
Assert.AreEqual("Test2", rules.Last().Name);
Assert.AreEqual(".test2", rules.Last().Selector);
Assert.AreEqual("font-color: green;", rules.Last().Styles);
}
// can't put tabs in verbatim strings, so this will replace # with \t to test the CSS indents
// - and it's tabs because the editor uses tabs, not spaces...
private static string Tabbed(string input) => input.Replace("#", "\t");
}