Files
Umbraco-CMS/tests/Umbraco.Tests.Integration/Umbraco.Core/Services/RelationServiceTests.cs

151 lines
6.8 KiB
C#
Raw Normal View History

Remove the non-controversial, straightforward obsoleted constructs for Umbraco 16 (#18661) * Removed obsoletes from IConfigManipulator. * Removed obsolete models builder extensions. * Removed the obsolete ContentDashboardSettings. * Removed the obsolete InstallMissingDatabase setting on GlobalSettings. * Removed obsolete NuCache settings. * Removed obsolete RuntimeMinificationSettings. * Removed obsolete health check constant. * Removed obsolete icon constant. * Removed obsolete telemetry constant. * Removed obsolete property and constructor on UmbracoBuilder. * Removed obsolete constructor on AuditNotificationsHandler. * Removed obsolete constructor on HTTP header health checks. * Removed obsolete constructor on MediaFileManager. * Removed obsolete GetDefaultFileContent on ViewHelper. * Remove obsoleted methods on embed providers. * Fix tests. * Removed obsolete constructors on BlockEditorDataConverter. * Removed obsolete SeedCacheDuration property on CacheSettings. * Removed obsolete PublishCulture on ContentRepositoryExtensions. * Removed obsolete MonitorLock. * Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository. * Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository. * Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository. * Removed obsolete DateValueEditor constructors. * Removed obsolete GetAutomaticRelationTypesAliases. * Removed obsolete constructor on TextOnlyValueEditor. * Removed obsolete constructors on RegexValidator and RequiredValidator. * Removed obsolete constructs on SliderValueConverter and TagsValueConverter. * Removed obsolete GetContentType methods from IPublishedCache. * Removed ContentFinderByIdPath. * Removed obsolete constructor on DefaultMediaUrlProvider. * Removed obsolete constructor on Domain. * Removed obsolete constructor on PublishedRequest. * Removed obsolete methods on CheckPermissions. * Removed obsolete GetUserId from IBackOfficeSecurity. * Removed obsolete methods on LegacyPasswordSecurity. * Removed obsolete constructors on AuditService. * Removed obsolete methods on IContentEditingService. * Remove obsolete constructors and methods on ContentService/IContentService. * Removed obsolete constructor in ContentTypeEditingService. * Removed obsolete constructor in MediaTypeEditingService. * Removed obsolete constructor in MemberTypeEditingService. * Removed obsolete constructor in ContentTypeService. * Removed obsolete constructors in ContentTypeServiceBase. * Removed obsolete constructors and methods in ContentVersionService. * Removed obsolete constructor in DataTypeUsageService. * Removed obsolete constructor in DomainService. * Removed obsolete constructor in FileService. * Removes obsolete AttemptMove from IContentService. * Removes obsolete SetPreventCleanup from IContentVersionService. * Removes obsolete GetReferences from IDataTypeService. * Removed obsolete SetConsentLevel from IMetricsConsentService. * Removed obsolete methods from IPackageDataInstallation. * Removed obsolete methods from IPackagingService. * Removed obsolete methods on ITwoFactorLoginService. Removed obsolete ITemporaryMediaService. * Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService. * More obsolete constructors. * Removed obsoleted overloads on IPropertyValidationService. * Fixed build for tests. * Removed obsolete constructor for PublicAccessService, UserService and RelationService. * Removed GetDefaultMemberType. * Removed obsolete user group functionality from IUserService. * Removed obsolete extension methods on IUserService. * Removed obsolete method from ITelemetryService. * Removed obsolete UdiParserServiceConnectors. * Removed obsolete method on ICookieManager. * Removed obsolete DynamicContext. * Removed obsolete XmlHelper. * Fixed failing integration tests. * Removed obsoletes in Umbraco.Cms.Api.Common * Removed obsoletes in Umbraco.Cms.Api.Delivery * Removed obsoletes in Umbraco.Cms.Api.Management * Removed obsoletes in Umbraco.Examine.Lucene * Removed obsoletes in Umbraco.Infrastructure * Fix failing delivery API contract integration test. * Made integration tests internal. * Removed obsoletes from web projects. * Fix build. * Removed Twitter OEmbed provider * Removed obsolete constructor on PublishedDataType. * Removed obsolete constructors on PublishedCacheBase. * Removed the obsolete PropertyEditorTagsExtensions. * Removed obsoletion properties on configuration response models (#18697) * Removed obsolete methods from server-side models. * Update client-side types and sdk. * Update client-side files. * Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694) * Removed obsolete method in UserService. (#18710) * Removed obsoleted group alias keys from being publicly available. (#18682) * Removed unneceessary ApiVersion attribute. * Clean-up obsoletions on MemberService (#18703) * Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers. * Removed obsoletion on member service method that's not obsolete on the interface.
2025-03-21 18:02:31 +01:00
using Castle.Components.DictionaryAdapter.Xml;
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
using NUnit.Framework;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Services.OperationStatus;
using Umbraco.Cms.Tests.Common.Builders;
using Umbraco.Cms.Tests.Common.Builders.Extensions;
using Umbraco.Cms.Tests.Common.Testing;
using Umbraco.Cms.Tests.Integration.Testing;
namespace Umbraco.Cms.Tests.Integration.Umbraco.Core.Services;
[TestFixture]
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerTest)]
Remove the non-controversial, straightforward obsoleted constructs for Umbraco 16 (#18661) * Removed obsoletes from IConfigManipulator. * Removed obsolete models builder extensions. * Removed the obsolete ContentDashboardSettings. * Removed the obsolete InstallMissingDatabase setting on GlobalSettings. * Removed obsolete NuCache settings. * Removed obsolete RuntimeMinificationSettings. * Removed obsolete health check constant. * Removed obsolete icon constant. * Removed obsolete telemetry constant. * Removed obsolete property and constructor on UmbracoBuilder. * Removed obsolete constructor on AuditNotificationsHandler. * Removed obsolete constructor on HTTP header health checks. * Removed obsolete constructor on MediaFileManager. * Removed obsolete GetDefaultFileContent on ViewHelper. * Remove obsoleted methods on embed providers. * Fix tests. * Removed obsolete constructors on BlockEditorDataConverter. * Removed obsolete SeedCacheDuration property on CacheSettings. * Removed obsolete PublishCulture on ContentRepositoryExtensions. * Removed obsolete MonitorLock. * Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository. * Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository. * Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository. * Removed obsolete DateValueEditor constructors. * Removed obsolete GetAutomaticRelationTypesAliases. * Removed obsolete constructor on TextOnlyValueEditor. * Removed obsolete constructors on RegexValidator and RequiredValidator. * Removed obsolete constructs on SliderValueConverter and TagsValueConverter. * Removed obsolete GetContentType methods from IPublishedCache. * Removed ContentFinderByIdPath. * Removed obsolete constructor on DefaultMediaUrlProvider. * Removed obsolete constructor on Domain. * Removed obsolete constructor on PublishedRequest. * Removed obsolete methods on CheckPermissions. * Removed obsolete GetUserId from IBackOfficeSecurity. * Removed obsolete methods on LegacyPasswordSecurity. * Removed obsolete constructors on AuditService. * Removed obsolete methods on IContentEditingService. * Remove obsolete constructors and methods on ContentService/IContentService. * Removed obsolete constructor in ContentTypeEditingService. * Removed obsolete constructor in MediaTypeEditingService. * Removed obsolete constructor in MemberTypeEditingService. * Removed obsolete constructor in ContentTypeService. * Removed obsolete constructors in ContentTypeServiceBase. * Removed obsolete constructors and methods in ContentVersionService. * Removed obsolete constructor in DataTypeUsageService. * Removed obsolete constructor in DomainService. * Removed obsolete constructor in FileService. * Removes obsolete AttemptMove from IContentService. * Removes obsolete SetPreventCleanup from IContentVersionService. * Removes obsolete GetReferences from IDataTypeService. * Removed obsolete SetConsentLevel from IMetricsConsentService. * Removed obsolete methods from IPackageDataInstallation. * Removed obsolete methods from IPackagingService. * Removed obsolete methods on ITwoFactorLoginService. Removed obsolete ITemporaryMediaService. * Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService. * More obsolete constructors. * Removed obsoleted overloads on IPropertyValidationService. * Fixed build for tests. * Removed obsolete constructor for PublicAccessService, UserService and RelationService. * Removed GetDefaultMemberType. * Removed obsolete user group functionality from IUserService. * Removed obsolete extension methods on IUserService. * Removed obsolete method from ITelemetryService. * Removed obsolete UdiParserServiceConnectors. * Removed obsolete method on ICookieManager. * Removed obsolete DynamicContext. * Removed obsolete XmlHelper. * Fixed failing integration tests. * Removed obsoletes in Umbraco.Cms.Api.Common * Removed obsoletes in Umbraco.Cms.Api.Delivery * Removed obsoletes in Umbraco.Cms.Api.Management * Removed obsoletes in Umbraco.Examine.Lucene * Removed obsoletes in Umbraco.Infrastructure * Fix failing delivery API contract integration test. * Made integration tests internal. * Removed obsoletes from web projects. * Fix build. * Removed Twitter OEmbed provider * Removed obsolete constructor on PublishedDataType. * Removed obsolete constructors on PublishedCacheBase. * Removed the obsolete PropertyEditorTagsExtensions. * Removed obsoletion properties on configuration response models (#18697) * Removed obsolete methods from server-side models. * Update client-side types and sdk. * Update client-side files. * Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694) * Removed obsolete method in UserService. (#18710) * Removed obsoleted group alias keys from being publicly available. (#18682) * Removed unneceessary ApiVersion attribute. * Clean-up obsoletions on MemberService (#18703) * Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers. * Removed obsoletion on member service method that's not obsolete on the interface.
2025-03-21 18:02:31 +01:00
internal sealed class RelationServiceTests : UmbracoIntegrationTest
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
{
private IRelationService RelationService => GetRequiredService<IRelationService>();
[Test]
[TestCase(true, true)]
[TestCase(false, true)]
[TestCase(true, false)]
[TestCase(false, false)]
public async Task Can_Create_Relation_Types_With_Bi_Directional_And_Is_Dependency(bool isBiDirectional, bool isDependency)
{
IRelationTypeWithIsDependency relationType = new RelationTypeBuilder()
.WithChildObjectType(Constants.ObjectTypes.DocumentType)
.WithParentObjectType(Constants.ObjectTypes.MediaType)
.WithIsBidirectional(isBiDirectional)
.WithIsDependency(isDependency)
.Build();
Attempt<IRelationType, RelationTypeOperationStatus> result = await RelationService.CreateAsync(relationType, Constants.Security.SuperUserKey);
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
Assert.Multiple(() =>
{
Assert.IsTrue(result.Success);
Assert.AreEqual(RelationTypeOperationStatus.Success, result.Status);
});
AssertRelationTypesAreSame(relationType, result.Result);
}
[Test]
[TestCase(Constants.ObjectTypes.Strings.Document, Constants.ObjectTypes.Strings.Media)]
[TestCase(Constants.ObjectTypes.Strings.Member, Constants.ObjectTypes.Strings.DocumentType)]
[TestCase(Constants.ObjectTypes.Strings.MediaType, Constants.ObjectTypes.Strings.MemberType)]
[TestCase(Constants.ObjectTypes.Strings.DataType, Constants.ObjectTypes.Strings.MemberGroup)]
[TestCase(Constants.ObjectTypes.Strings.Document, Constants.ObjectTypes.Strings.ContentRecycleBin)]
[TestCase(Constants.ObjectTypes.Strings.Document, Constants.ObjectTypes.Strings.SystemRoot)]
public async Task Can_Create_Relation_Types_With_Allowed_Object_Types(string childObjectTypeGuid, string parentObjectTypeGuid)
{
IRelationTypeWithIsDependency relationType = new RelationTypeBuilder()
.WithChildObjectType(new Guid(childObjectTypeGuid))
.WithParentObjectType(new Guid(parentObjectTypeGuid))
.Build();
Attempt<IRelationType, RelationTypeOperationStatus> result = await RelationService.CreateAsync(relationType, Constants.Security.SuperUserKey);
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
Assert.Multiple(() =>
{
Assert.IsTrue(result.Success);
Assert.AreEqual(RelationTypeOperationStatus.Success, result.Status);
});
AssertRelationTypesAreSame(relationType, result.Result);
}
[Test]
[TestCase(Constants.ObjectTypes.Strings.Document, "53E492BD-F242-40A7-8F21-7D649463DD23", RelationTypeOperationStatus.InvalidChildObjectType)]
[TestCase("E7524E34-F84F-43DE-92E2-25999785B7EA", Constants.ObjectTypes.Strings.DataType, RelationTypeOperationStatus.InvalidParentObjectType)]
[TestCase("00000000-0000-0000-0000-000000000000", Constants.ObjectTypes.Strings.Document, RelationTypeOperationStatus.InvalidParentObjectType)]
[TestCase(Constants.ObjectTypes.Strings.IdReservation, Constants.ObjectTypes.Strings.Document, RelationTypeOperationStatus.InvalidParentObjectType)]
public async Task Cannot_Create_Relation_Types_With_Disallowed_Object_Types(string parentObjectTypeGuid, string childObjectTypeGuid, RelationTypeOperationStatus relationTypeOperationStatus)
{
IRelationTypeWithIsDependency relationType = new RelationTypeBuilder()
.WithChildObjectType(new Guid(childObjectTypeGuid))
.WithParentObjectType(new Guid(parentObjectTypeGuid))
.Build();
Attempt<IRelationType, RelationTypeOperationStatus> result = await RelationService.CreateAsync(relationType, Constants.Security.SuperUserKey);
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
Assert.Multiple(() =>
{
Assert.IsFalse(result.Success);
Assert.AreEqual(relationTypeOperationStatus, result.Status);
});
}
[Test]
public async Task Can_Create_Relation_Type_With_Key()
{
const string key = "82E7631C-0417-460C-91C1-F65784627143";
IRelationTypeWithIsDependency relationType = new RelationTypeBuilder()
.WithChildObjectType(Constants.ObjectTypes.DocumentType)
.WithParentObjectType(Constants.ObjectTypes.DocumentType)
.WithKey(new Guid(key))
.Build();
Attempt<IRelationType, RelationTypeOperationStatus> result = await RelationService.CreateAsync(relationType, Constants.Security.SuperUserKey);
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
Assert.Multiple(() =>
{
Assert.IsTrue(result.Success);
Assert.AreEqual(RelationTypeOperationStatus.Success, result.Status);
Assert.IsTrue(string.Equals(key, result.Result.Key.ToString(), StringComparison.OrdinalIgnoreCase));
});
AssertRelationTypesAreSame(relationType, result.Result);
}
[Test]
[TestCase(-1000000)]
[TestCase(-1)]
[TestCase(100)]
[TestCase(10000000)]
public async Task Cannot_Create_Relation_Types_With_Id(int id)
{
IRelationTypeWithIsDependency relationType = new RelationTypeBuilder()
.WithChildObjectType(Constants.ObjectTypes.DocumentType)
.WithParentObjectType(Constants.ObjectTypes.DocumentType)
.WithId(id)
.Build();
Attempt<IRelationType, RelationTypeOperationStatus> result = await RelationService.CreateAsync(relationType, Constants.Security.SuperUserKey);
V13: relation type controller (#13856) * Create RelationTypeControllerBase.cs * Implement ByKey endpoint * Move controllers * Implement ByRelationTypeKeyRelationController * Refactor relation service to use skip/take in interface * change httpget * Implement object types endpoint * Add ObjectTypeViewModelFactory.cs * Change signature to IActionResult * Implement CreateRelationTypeController.cs * Implement CreateRelationTypeController.cs * Add optional key parameter to RelationType * Add optional key to RelationTypeSavingViewModel * Update ProducsResponseType * Implement UpdateRelationTypeController * Update routes * Implement DeleteRelationTypeController * Remove key from UpdatingViewmoDel * Implement UpdatingViewModel factory method * Update relationType factory * Fix paging for object types * Implement CreateAsync * Update create action to use CreateAsync * Implement update async * Add default implementations to avoid breaking changes * actually use userIds * Add ProducesResponseType status 400 to endpoints * Implement new DeleteAsync method * Update OpenApi.json * Add mapping to DI * Update 404 to return proper HTTP status * Add not found to ByKey action * Rename viewmodels to request/response * Update OpenApi.json * All RelationServiceTests.cs * Add allowed object types test * Fix grouping * Implement AllowedRelationObjectTypesService.cs * Refactor view model factory to use new service * Implement non-happy path tests * Implement allowed child/parent object types * refactor test to return proper relationTypeOperationStatus * Add can create relation type with key * Add Id test * formatting * Refactor service to have validation logic in save method * move object types endpoint to own silo * Delete unused using * Update OpenApi.json * Update OpenApi.json * Update tests to user proper child/parent * Implement RelationTypeBaseModel * Update OpenApi.json * Use array instead of enumerable * Rename view model factory to presentation factory * Rename GetPagedByRelationTypeKey * Rename IRelationViewModelFactory * Rename IRelationTypeViewModelFactory * Update error description * Update OpenApi.json * Update OpenApi.json --------- Co-authored-by: Zeegaan <nge@umbraco.dk> Co-authored-by: Nikolaj <nikolajlauridsen@protonmail.ch>
2023-03-01 08:51:17 +01:00
Assert.Multiple(() =>
{
Assert.IsFalse(result.Success);
Assert.AreEqual(RelationTypeOperationStatus.InvalidId, result.Status);
});
}
private void AssertRelationTypesAreSame(IRelationTypeWithIsDependency relationType, IRelationType result)
{
Assert.Multiple(() =>
{
Assert.AreEqual(relationType.Name, result.Name);
Assert.AreEqual(relationType.ParentObjectType, result.ParentObjectType);
Assert.AreEqual(relationType.ChildObjectType, result.ChildObjectType);
Assert.AreEqual(relationType.IsBidirectional, result.IsBidirectional);
var asWithDependency = (IRelationTypeWithIsDependency)result;
Assert.AreEqual(relationType.IsDependency, asWithDependency.IsDependency);
});
var persistedRelationType = RelationService.GetRelationTypeById(result.Key);
Assert.AreEqual(result, persistedRelationType);
}
}