Files
Umbraco-CMS/tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/EntityServiceTests.cs

953 lines
33 KiB
C#
Raw Normal View History

// Copyright (c) Umbraco.
// See LICENSE for more details.
using System;
2018-06-29 19:52:40 +02:00
using System.Collections.Generic;
using System.Linq;
using NUnit.Framework;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Models.Entities;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Infrastructure.Persistence;
using Umbraco.Cms.Tests.Common.Attributes;
using Umbraco.Cms.Tests.Common.Builders;
using Umbraco.Cms.Tests.Common.Testing;
using Umbraco.Cms.Tests.Integration.Testing;
using Umbraco.Extensions;
2018-06-29 19:52:40 +02:00
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Services;
/// <summary>
/// Tests covering the EntityService
/// </summary>
[TestFixture]
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerFixture)]
public class EntityServiceTests : UmbracoIntegrationTest
2018-06-29 19:52:40 +02:00
{
[SetUp]
public void SetupTestData()
2018-06-29 19:52:40 +02:00
{
if (_langFr == null && _langEs == null)
{
_langFr = new Language("fr-FR", "French (France)");
_langEs = new Language("es-ES", "Spanish (Spain)");
LocalizationService.Save(_langFr);
LocalizationService.Save(_langEs);
}
2018-06-29 19:52:40 +02:00
CreateTestData();
}
private Language _langFr;
private Language _langEs;
private ILocalizationService LocalizationService => GetRequiredService<ILocalizationService>();
private IContentTypeService ContentTypeService => GetRequiredService<IContentTypeService>();
private IContentService ContentService => GetRequiredService<IContentService>();
private IEntityService EntityService => GetRequiredService<IEntityService>();
private ISqlContext SqlContext => GetRequiredService<ISqlContext>();
private IMediaTypeService MediaTypeService => GetRequiredService<IMediaTypeService>();
2020-10-05 09:38:30 +02:00
private IMediaService MediaService => GetRequiredService<IMediaService>();
2020-10-05 09:38:30 +02:00
private IFileService FileService => GetRequiredService<IFileService>();
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Paged_Descendants_Ordering_Path()
{
var contentType = ContentTypeService.Get("umbTextpage");
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
var rootId = root.Id;
var ids = new List<int>();
for (var i = 0; i < 10; i++)
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
ContentService.Save(c1);
ids.Add(c1.Id);
root = c1; // make a hierarchy
}
var entities = EntityService.GetPagedDescendants(rootId, UmbracoObjectTypes.Document, 0, 6, out var total)
.ToArray();
Assert.That(entities.Length, Is.EqualTo(6));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[0], entities[0].Id);
entities = EntityService.GetPagedDescendants(rootId, UmbracoObjectTypes.Document, 1, 6, out total).ToArray();
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[6], entities[0].Id);
// Test ordering direction
entities = EntityService.GetPagedDescendants(
rootId,
UmbracoObjectTypes.Document,
0,
6,
out total,
ordering: Ordering.By("Path", Direction.Descending)).ToArray();
Assert.That(entities.Length, Is.EqualTo(6));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[^1], entities[0].Id);
entities = EntityService.GetPagedDescendants(
rootId,
UmbracoObjectTypes.Document,
1,
6,
out total,
ordering: Ordering.By("Path", Direction.Descending)).ToArray();
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[ids.Count - 1 - 6], entities[0].Id);
}
[Test]
public void EntityService_Can_Get_Paged_Content_Children()
{
var contentType = ContentTypeService.Get("umbTextpage");
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
var ids = new List<int>();
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
ContentService.Save(c1);
ids.Add(c1.Id);
}
var entities = EntityService.GetPagedChildren(root.Id, UmbracoObjectTypes.Document, 0, 6, out var total)
.ToArray();
Assert.That(entities.Length, Is.EqualTo(6));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[0], entities[0].Id);
entities = EntityService.GetPagedChildren(root.Id, UmbracoObjectTypes.Document, 1, 6, out total).ToArray();
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[6], entities[0].Id);
// Test ordering direction
entities = EntityService.GetPagedChildren(
root.Id,
UmbracoObjectTypes.Document,
0,
6,
out total,
ordering: Ordering.By("SortOrder", Direction.Descending)).ToArray();
Assert.That(entities.Length, Is.EqualTo(6));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[^1], entities[0].Id);
entities = EntityService.GetPagedChildren(
root.Id,
UmbracoObjectTypes.Document,
1,
6,
out total,
ordering: Ordering.By("SortOrder", Direction.Descending)).ToArray();
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(total, Is.EqualTo(10));
Assert.AreEqual(ids[ids.Count - 1 - 6], entities[0].Id);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Paged_Content_Descendants()
{
var contentType = ContentTypeService.Get("umbTextpage");
2018-06-29 19:52:40 +02:00
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
var count = 0;
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
ContentService.Save(c1);
count++;
2018-06-29 19:52:40 +02:00
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), c1);
ContentService.Save(c2);
2018-06-29 19:52:40 +02:00
count++;
}
}
var entities = EntityService.GetPagedDescendants(root.Id, UmbracoObjectTypes.Document, 0, 31, out var total)
.ToArray();
Assert.That(entities.Length, Is.EqualTo(31));
Assert.That(total, Is.EqualTo(60));
entities = EntityService.GetPagedDescendants(root.Id, UmbracoObjectTypes.Document, 1, 31, out total).ToArray();
Assert.That(entities.Length, Is.EqualTo(29));
Assert.That(total, Is.EqualTo(60));
}
[Test]
[LongRunning]
public void EntityService_Can_Get_Paged_Content_Descendants_Including_Recycled()
{
var contentType = ContentTypeService.Get("umbTextpage");
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
var toDelete = new List<IContent>();
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
ContentService.Save(c1);
2018-06-29 19:52:40 +02:00
if (i % 2 == 0)
2018-06-29 19:52:40 +02:00
{
toDelete.Add(c1);
2018-06-29 19:52:40 +02:00
}
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), c1);
ContentService.Save(c2);
2018-06-29 19:52:40 +02:00
}
}
2018-06-29 19:52:40 +02:00
foreach (var content in toDelete)
{
ContentService.MoveToRecycleBin(content);
2018-06-29 19:52:40 +02:00
}
// search at root to see if it returns recycled
var entities = EntityService.GetPagedDescendants(-1, UmbracoObjectTypes.Document, 0, 1000, out var total)
.Select(x => x.Id)
.ToArray();
foreach (var c in toDelete)
2018-06-29 19:52:40 +02:00
{
Assert.True(entities.Contains(c.Id));
}
}
2018-06-29 19:52:40 +02:00
[Test]
[LongRunning]
public void EntityService_Can_Get_Paged_Content_Descendants_Without_Recycled()
{
var contentType = ContentTypeService.Get("umbTextpage");
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
var toDelete = new List<IContent>();
for (var i = 0; i < 10; i++)
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
ContentService.Save(c1);
2018-06-29 19:52:40 +02:00
if (i % 2 == 0)
2018-06-29 19:52:40 +02:00
{
toDelete.Add(c1);
2018-06-29 19:52:40 +02:00
}
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), c1);
ContentService.Save(c2);
2018-06-29 19:52:40 +02:00
}
}
foreach (var content in toDelete)
2018-06-29 19:52:40 +02:00
{
ContentService.MoveToRecycleBin(content);
}
2018-06-29 19:52:40 +02:00
// search at root to see if it returns recycled
var entities = EntityService
.GetPagedDescendants(UmbracoObjectTypes.Document, 0, 1000, out var total, includeTrashed: false)
.Select(x => x.Id)
.ToArray();
2018-06-29 19:52:40 +02:00
foreach (var c in toDelete)
{
Assert.IsFalse(entities.Contains(c.Id));
2018-06-29 19:52:40 +02:00
}
}
2018-06-29 19:52:40 +02:00
New backoffice - trees design (#12963) * Refactor: Add default versioned back office route attribute * Tree controller bases and first draft implementations for document, media and doctype * Move tree item view models to appropriate location * Fix missing parent * Refactor user entity access for testability * A bit of clean-up + handle user start nodes for items endpoint * Implement foldersOnly for folder tree * Items endpoint for document type tree * Strongly typed action results * Content + media recycle bin * Correct return type for swagger * Member type tree * Rename user start node handling to make a little more sense * Revert to faked admin start nodes in document tree * Media type tree * Data type tree * Relation type tree * Remove unused dependency from member type tree * Correct documentation for member type tree endpoint response types * Use icon constants * Add templates tree * Member group tree * Document blueprint tree * Partial views, scripts and stylesheets trees * Static files tree * Clarify "folders only" state * Comments and improved readability * Rename TreeControllerBase and TreeItemViewModel * Move recycle bin controller base to its own namespace * Moved tree base controllers to their own namespace * Common base class for tree view models * Remove ProblemDetails response type declaration from all actions * Add OpenApiTag * Various review comments * Dictionary item tree * Renamed all tree controllers to follow action/feature naming convention * Handle client culture state for document tree * Support "ignore user start nodes" for content and media + refactor how tree states work to make things more explicit * Fix or postpone a few TODOs * Make entity service able to paginate trashed children * Handle sorting explicitly * Re-apply VersionedApiBackOfficeRoute to install and upgrade controllers after merge * Use PagedViewModel instead of PagedResult for all trees * Explain the usage of UmbracoObjectTypes.Unknown * Introduce and apply GetMany pattern for dictionary items * Add a note about relation type caching * Fix broken test build + add unit tests for new localization service methods * Use new management API controller base * Entity repository should build document entities for document blueprints when getting paged entities (same as it does when getting specific entities) * Use Media type for Media recycle bin Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Move shared relation service to concrete implementations * Use inclusive language * Add 401 response type documentation to applicable trees * Refactor entity load for folder tree controller base + ensure that folders are only included in the first result page * Add (in-memory) pagination to dictionary tree * Make file system controller honor paging parameters * Support pagination in relation type tree * Clarify method name a bit for detecting tree root path requests * Update Open API schema to match new trees * Move from page number and page size to skip/take (with temporary workaround for lack of property skip/take pagination in current DB implementation) * Update OpenAPI schema to match skip/take * Update OpenAPI schema * Don't return paginated view models from "items" endpoints * Update OpenApi schema Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-09-28 13:37:59 +02:00
[Test]
[LongRunning]
New backoffice - trees design (#12963) * Refactor: Add default versioned back office route attribute * Tree controller bases and first draft implementations for document, media and doctype * Move tree item view models to appropriate location * Fix missing parent * Refactor user entity access for testability * A bit of clean-up + handle user start nodes for items endpoint * Implement foldersOnly for folder tree * Items endpoint for document type tree * Strongly typed action results * Content + media recycle bin * Correct return type for swagger * Member type tree * Rename user start node handling to make a little more sense * Revert to faked admin start nodes in document tree * Media type tree * Data type tree * Relation type tree * Remove unused dependency from member type tree * Correct documentation for member type tree endpoint response types * Use icon constants * Add templates tree * Member group tree * Document blueprint tree * Partial views, scripts and stylesheets trees * Static files tree * Clarify "folders only" state * Comments and improved readability * Rename TreeControllerBase and TreeItemViewModel * Move recycle bin controller base to its own namespace * Moved tree base controllers to their own namespace * Common base class for tree view models * Remove ProblemDetails response type declaration from all actions * Add OpenApiTag * Various review comments * Dictionary item tree * Renamed all tree controllers to follow action/feature naming convention * Handle client culture state for document tree * Support "ignore user start nodes" for content and media + refactor how tree states work to make things more explicit * Fix or postpone a few TODOs * Make entity service able to paginate trashed children * Handle sorting explicitly * Re-apply VersionedApiBackOfficeRoute to install and upgrade controllers after merge * Use PagedViewModel instead of PagedResult for all trees * Explain the usage of UmbracoObjectTypes.Unknown * Introduce and apply GetMany pattern for dictionary items * Add a note about relation type caching * Fix broken test build + add unit tests for new localization service methods * Use new management API controller base * Entity repository should build document entities for document blueprints when getting paged entities (same as it does when getting specific entities) * Use Media type for Media recycle bin Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Move shared relation service to concrete implementations * Use inclusive language * Add 401 response type documentation to applicable trees * Refactor entity load for folder tree controller base + ensure that folders are only included in the first result page * Add (in-memory) pagination to dictionary tree * Make file system controller honor paging parameters * Support pagination in relation type tree * Clarify method name a bit for detecting tree root path requests * Update Open API schema to match new trees * Move from page number and page size to skip/take (with temporary workaround for lack of property skip/take pagination in current DB implementation) * Update OpenAPI schema to match skip/take * Update OpenAPI schema * Don't return paginated view models from "items" endpoints * Update OpenApi schema Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-09-28 13:37:59 +02:00
public void EntityService_Can_Get_Paged_Trashed_Content_Children()
{
var contentType = ContentTypeService.Get("umbTextpage");
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
var toDelete = new List<IContent>();
for (var i = 0; i < 10; i++)
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
ContentService.Save(c1);
if (i % 2 == 0)
{
toDelete.Add(c1);
}
for (var j = 0; j < 5; j++)
{
var c2 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), c1);
ContentService.Save(c2);
}
}
foreach (var content in toDelete)
{
ContentService.MoveToRecycleBin(content);
}
// get paged entities at recycle bin root
var entities = EntityService
.GetPagedTrashedChildren(Constants.System.RecycleBinContent, UmbracoObjectTypes.Document, 0, 1000, out var total)
.Select(x => x.Id)
.ToArray();
Assert.True(total > 0);
foreach (var c in toDelete)
{
Assert.IsTrue(entities.Contains(c.Id));
}
}
[Test]
public void EntityService_Can_Get_Paged_Content_Descendants_With_Search()
{
var contentType = ContentTypeService.Get("umbTextpage");
var root = ContentBuilder.CreateSimpleContent(contentType);
ContentService.Save(root);
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, "ssss" + Guid.NewGuid(), root);
ContentService.Save(c1);
2018-06-29 19:52:40 +02:00
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = ContentBuilder.CreateSimpleContent(contentType, "tttt" + Guid.NewGuid(), c1);
ContentService.Save(c2);
2018-06-29 19:52:40 +02:00
}
}
var entities = EntityService.GetPagedDescendants(
root.Id,
UmbracoObjectTypes.Document,
0,
10,
out var total,
SqlContext.Query<IUmbracoEntity>().Where(x => x.Name.Contains("ssss"))).ToArray();
Assert.That(entities.Length, Is.EqualTo(10));
Assert.That(total, Is.EqualTo(10));
entities = EntityService.GetPagedDescendants(
root.Id,
UmbracoObjectTypes.Document,
0,
50,
out total,
SqlContext.Query<IUmbracoEntity>().Where(x => x.Name.Contains("tttt"))).ToArray();
Assert.That(entities.Length, Is.EqualTo(50));
Assert.That(total, Is.EqualTo(50));
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Paged_Media_Children()
{
var folderType = MediaTypeService.Get(1031);
var imageMediaType = MediaTypeService.Get(1032);
var root = MediaBuilder.CreateMediaFolder(folderType, -1);
MediaService.Save(root);
for (var i = 0; i < 10; i++)
{
var c1 = MediaBuilder.CreateMediaImage(imageMediaType, root.Id);
MediaService.Save(c1);
2018-06-29 19:52:40 +02:00
}
var entities = EntityService.GetPagedChildren(root.Id, UmbracoObjectTypes.Media, 0, 6, out var total).ToArray();
Assert.That(entities.Length, Is.EqualTo(6));
Assert.That(total, Is.EqualTo(10));
entities = EntityService.GetPagedChildren(root.Id, UmbracoObjectTypes.Media, 1, 6, out total).ToArray();
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(total, Is.EqualTo(10));
}
[Test]
[LongRunning]
public void EntityService_Can_Get_Paged_Media_Descendants()
{
var folderType = MediaTypeService.Get(1031);
var imageMediaType = MediaTypeService.Get(1032);
var root = MediaBuilder.CreateMediaFolder(folderType, -1);
MediaService.Save(root);
var count = 0;
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = MediaBuilder.CreateMediaImage(imageMediaType, root.Id);
MediaService.Save(c1);
count++;
2018-06-29 19:52:40 +02:00
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = MediaBuilder.CreateMediaImage(imageMediaType, c1.Id);
MediaService.Save(c2);
2018-06-29 19:52:40 +02:00
count++;
}
}
var entities = EntityService.GetPagedDescendants(root.Id, UmbracoObjectTypes.Media, 0, 31, out var total)
.ToArray();
Assert.That(entities.Length, Is.EqualTo(31));
Assert.That(total, Is.EqualTo(60));
entities = EntityService.GetPagedDescendants(root.Id, UmbracoObjectTypes.Media, 1, 31, out total).ToArray();
Assert.That(entities.Length, Is.EqualTo(29));
Assert.That(total, Is.EqualTo(60));
}
[Test]
[LongRunning]
public void EntityService_Can_Get_Paged_Media_Descendants_Including_Recycled()
{
var folderType = MediaTypeService.Get(1031);
var imageMediaType = MediaTypeService.Get(1032);
var root = MediaBuilder.CreateMediaFolder(folderType, -1);
MediaService.Save(root);
var toDelete = new List<IMedia>();
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = MediaBuilder.CreateMediaImage(imageMediaType, root.Id);
MediaService.Save(c1);
2018-06-29 19:52:40 +02:00
if (i % 2 == 0)
2018-06-29 19:52:40 +02:00
{
toDelete.Add(c1);
2018-06-29 19:52:40 +02:00
}
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = MediaBuilder.CreateMediaImage(imageMediaType, c1.Id);
MediaService.Save(c2);
2018-06-29 19:52:40 +02:00
}
}
2018-06-29 19:52:40 +02:00
foreach (var content in toDelete)
{
MediaService.MoveToRecycleBin(content);
}
2018-06-29 19:52:40 +02:00
// search at root to see if it returns recycled
var entities = EntityService.GetPagedDescendants(-1, UmbracoObjectTypes.Media, 0, 1000, out var total)
.Select(x => x.Id)
.ToArray();
foreach (var media in toDelete)
{
Assert.IsTrue(entities.Contains(media.Id));
2018-06-29 19:52:40 +02:00
}
}
2018-06-29 19:52:40 +02:00
[Test]
[LongRunning]
public void EntityService_Can_Get_Paged_Media_Descendants_Without_Recycled()
{
var folderType = MediaTypeService.Get(1031);
var imageMediaType = MediaTypeService.Get(1032);
var root = MediaBuilder.CreateMediaFolder(folderType, -1);
MediaService.Save(root);
var toDelete = new List<IMedia>();
for (var i = 0; i < 10; i++)
2018-06-29 19:52:40 +02:00
{
var c1 = MediaBuilder.CreateMediaImage(imageMediaType, root.Id);
MediaService.Save(c1);
2018-06-29 19:52:40 +02:00
if (i % 2 == 0)
2018-06-29 19:52:40 +02:00
{
toDelete.Add(c1);
2018-06-29 19:52:40 +02:00
}
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = MediaBuilder.CreateMediaImage(imageMediaType, c1.Id);
MediaService.Save(c2);
2018-06-29 19:52:40 +02:00
}
}
2018-06-29 19:52:40 +02:00
foreach (var content in toDelete)
{
MediaService.MoveToRecycleBin(content);
2018-06-29 19:52:40 +02:00
}
// search at root to see if it returns recycled
var entities = EntityService
.GetPagedDescendants(UmbracoObjectTypes.Media, 0, 1000, out var total, includeTrashed: false)
.Select(x => x.Id)
.ToArray();
foreach (var media in toDelete)
2018-06-29 19:52:40 +02:00
{
Assert.IsFalse(entities.Contains(media.Id));
}
}
New backoffice - trees design (#12963) * Refactor: Add default versioned back office route attribute * Tree controller bases and first draft implementations for document, media and doctype * Move tree item view models to appropriate location * Fix missing parent * Refactor user entity access for testability * A bit of clean-up + handle user start nodes for items endpoint * Implement foldersOnly for folder tree * Items endpoint for document type tree * Strongly typed action results * Content + media recycle bin * Correct return type for swagger * Member type tree * Rename user start node handling to make a little more sense * Revert to faked admin start nodes in document tree * Media type tree * Data type tree * Relation type tree * Remove unused dependency from member type tree * Correct documentation for member type tree endpoint response types * Use icon constants * Add templates tree * Member group tree * Document blueprint tree * Partial views, scripts and stylesheets trees * Static files tree * Clarify "folders only" state * Comments and improved readability * Rename TreeControllerBase and TreeItemViewModel * Move recycle bin controller base to its own namespace * Moved tree base controllers to their own namespace * Common base class for tree view models * Remove ProblemDetails response type declaration from all actions * Add OpenApiTag * Various review comments * Dictionary item tree * Renamed all tree controllers to follow action/feature naming convention * Handle client culture state for document tree * Support "ignore user start nodes" for content and media + refactor how tree states work to make things more explicit * Fix or postpone a few TODOs * Make entity service able to paginate trashed children * Handle sorting explicitly * Re-apply VersionedApiBackOfficeRoute to install and upgrade controllers after merge * Use PagedViewModel instead of PagedResult for all trees * Explain the usage of UmbracoObjectTypes.Unknown * Introduce and apply GetMany pattern for dictionary items * Add a note about relation type caching * Fix broken test build + add unit tests for new localization service methods * Use new management API controller base * Entity repository should build document entities for document blueprints when getting paged entities (same as it does when getting specific entities) * Use Media type for Media recycle bin Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Move shared relation service to concrete implementations * Use inclusive language * Add 401 response type documentation to applicable trees * Refactor entity load for folder tree controller base + ensure that folders are only included in the first result page * Add (in-memory) pagination to dictionary tree * Make file system controller honor paging parameters * Support pagination in relation type tree * Clarify method name a bit for detecting tree root path requests * Update Open API schema to match new trees * Move from page number and page size to skip/take (with temporary workaround for lack of property skip/take pagination in current DB implementation) * Update OpenAPI schema to match skip/take * Update OpenAPI schema * Don't return paginated view models from "items" endpoints * Update OpenApi schema Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-09-28 13:37:59 +02:00
[Test]
[LongRunning]
New backoffice - trees design (#12963) * Refactor: Add default versioned back office route attribute * Tree controller bases and first draft implementations for document, media and doctype * Move tree item view models to appropriate location * Fix missing parent * Refactor user entity access for testability * A bit of clean-up + handle user start nodes for items endpoint * Implement foldersOnly for folder tree * Items endpoint for document type tree * Strongly typed action results * Content + media recycle bin * Correct return type for swagger * Member type tree * Rename user start node handling to make a little more sense * Revert to faked admin start nodes in document tree * Media type tree * Data type tree * Relation type tree * Remove unused dependency from member type tree * Correct documentation for member type tree endpoint response types * Use icon constants * Add templates tree * Member group tree * Document blueprint tree * Partial views, scripts and stylesheets trees * Static files tree * Clarify "folders only" state * Comments and improved readability * Rename TreeControllerBase and TreeItemViewModel * Move recycle bin controller base to its own namespace * Moved tree base controllers to their own namespace * Common base class for tree view models * Remove ProblemDetails response type declaration from all actions * Add OpenApiTag * Various review comments * Dictionary item tree * Renamed all tree controllers to follow action/feature naming convention * Handle client culture state for document tree * Support "ignore user start nodes" for content and media + refactor how tree states work to make things more explicit * Fix or postpone a few TODOs * Make entity service able to paginate trashed children * Handle sorting explicitly * Re-apply VersionedApiBackOfficeRoute to install and upgrade controllers after merge * Use PagedViewModel instead of PagedResult for all trees * Explain the usage of UmbracoObjectTypes.Unknown * Introduce and apply GetMany pattern for dictionary items * Add a note about relation type caching * Fix broken test build + add unit tests for new localization service methods * Use new management API controller base * Entity repository should build document entities for document blueprints when getting paged entities (same as it does when getting specific entities) * Use Media type for Media recycle bin Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Move shared relation service to concrete implementations * Use inclusive language * Add 401 response type documentation to applicable trees * Refactor entity load for folder tree controller base + ensure that folders are only included in the first result page * Add (in-memory) pagination to dictionary tree * Make file system controller honor paging parameters * Support pagination in relation type tree * Clarify method name a bit for detecting tree root path requests * Update Open API schema to match new trees * Move from page number and page size to skip/take (with temporary workaround for lack of property skip/take pagination in current DB implementation) * Update OpenAPI schema to match skip/take * Update OpenAPI schema * Don't return paginated view models from "items" endpoints * Update OpenApi schema Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-09-28 13:37:59 +02:00
public void EntityService_Can_Get_Paged_Trashed_Media_Children()
{
var folderType = MediaTypeService.Get(1031);
var imageMediaType = MediaTypeService.Get(1032);
var root = MediaBuilder.CreateMediaFolder(folderType, -1);
MediaService.Save(root);
var toDelete = new List<IMedia>();
for (var i = 0; i < 10; i++)
{
var c1 = MediaBuilder.CreateMediaImage(imageMediaType, root.Id);
MediaService.Save(c1);
if (i % 2 == 0)
{
toDelete.Add(c1);
}
for (var j = 0; j < 5; j++)
{
var c2 = MediaBuilder.CreateMediaImage(imageMediaType, c1.Id);
MediaService.Save(c2);
}
}
foreach (var content in toDelete)
{
MediaService.MoveToRecycleBin(content);
}
// get paged entities at recycle bin root
var entities = EntityService
.GetPagedTrashedChildren(Constants.System.RecycleBinMedia, UmbracoObjectTypes.Media, 0, 1000, out var total)
.Select(x => x.Id)
.ToArray();
Assert.True(total > 0);
foreach (var media in toDelete)
{
Assert.IsTrue(entities.Contains(media.Id));
}
}
[Test]
[LongRunning]
public void EntityService_Can_Get_Paged_Media_Descendants_With_Search()
{
var folderType = MediaTypeService.Get(1031);
var imageMediaType = MediaTypeService.Get(1032);
2018-06-29 19:52:40 +02:00
var root = MediaBuilder.CreateMediaFolder(folderType, -1);
MediaService.Save(root);
2018-06-29 19:52:40 +02:00
for (var i = 0; i < 10; i++)
{
var c1 = MediaBuilder.CreateMediaImage(imageMediaType, root.Id);
c1.Name = "ssss" + Guid.NewGuid();
MediaService.Save(c1);
for (var j = 0; j < 5; j++)
2018-06-29 19:52:40 +02:00
{
var c2 = MediaBuilder.CreateMediaImage(imageMediaType, c1.Id);
c2.Name = "tttt" + Guid.NewGuid();
MediaService.Save(c2);
2018-06-29 19:52:40 +02:00
}
}
var entities = EntityService.GetPagedDescendants(
root.Id,
UmbracoObjectTypes.Media,
0,
10,
out var total,
SqlContext.Query<IUmbracoEntity>().Where(x => x.Name.Contains("ssss"))).ToArray();
Assert.That(entities.Length, Is.EqualTo(10));
Assert.That(total, Is.EqualTo(10));
entities = EntityService.GetPagedDescendants(
root.Id,
UmbracoObjectTypes.Media,
0,
50,
out total,
SqlContext.Query<IUmbracoEntity>().Where(x => x.Name.Contains("tttt"))).ToArray();
Assert.That(entities.Length, Is.EqualTo(50));
Assert.That(total, Is.EqualTo(50));
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_Content_By_UmbracoObjectTypes()
{
var entities = EntityService.GetAll(UmbracoObjectTypes.Document).ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(entities.Any(x => x.Trashed), Is.True);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_Content_By_UmbracoObjectType_Id()
{
var objectTypeId = Constants.ObjectTypes.Document;
var entities = EntityService.GetAll(objectTypeId).ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(entities.Any(x => x.Trashed), Is.True);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_Content_By_Type()
{
var entities = EntityService.GetAll<IContent>().ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Length, Is.EqualTo(4));
Assert.That(entities.Any(x => x.Trashed), Is.True);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Child_Content_By_ParentId_And_UmbracoObjectType()
{
var entities = EntityService.GetChildren(-1, UmbracoObjectTypes.Document).ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Length, Is.EqualTo(1));
Assert.That(entities.Any(x => x.Trashed), Is.False);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Content_By_UmbracoObjectType_With_Variant_Names()
{
var alias = "test" + Guid.NewGuid();
var template = TemplateBuilder.CreateTextPageTemplate(alias);
FileService.SaveTemplate(template);
var contentType = ContentTypeBuilder.CreateSimpleContentType("test2", "Test2", defaultTemplateId: template.Id);
contentType.Variations = ContentVariation.Culture;
ContentTypeService.Save(contentType);
var c1 = ContentBuilder.CreateSimpleContent(contentType, "Test");
c1.SetCultureName("Test - FR", _langFr.IsoCode);
c1.SetCultureName("Test - ES", _langEs.IsoCode);
ContentService.Save(c1);
var result = EntityService.Get(c1.Id, UmbracoObjectTypes.Document);
Assert.AreEqual("Test - FR", result.Name); // got name from default culture
Assert.IsNotNull(result as IDocumentEntitySlim);
var doc = (IDocumentEntitySlim)result;
var cultureNames = doc.CultureNames;
Assert.AreEqual("Test - FR", cultureNames[_langFr.IsoCode]);
Assert.AreEqual("Test - ES", cultureNames[_langEs.IsoCode]);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Child_Content_By_ParentId_And_UmbracoObjectType_With_Variant_Names()
{
var template = TemplateBuilder.CreateTextPageTemplate();
FileService.SaveTemplate(template);
var contentType = ContentTypeBuilder.CreateSimpleContentType("test1", "Test1", defaultTemplateId: template.Id);
contentType.Variations = ContentVariation.Culture;
ContentTypeService.Save(contentType);
2018-06-29 19:52:40 +02:00
var root = ContentBuilder.CreateSimpleContent(contentType);
root.SetCultureName("Root", _langFr.IsoCode); // else cannot save
ContentService.Save(root);
2018-06-29 19:52:40 +02:00
for (var i = 0; i < 10; i++)
{
var c1 = ContentBuilder.CreateSimpleContent(contentType, Guid.NewGuid().ToString(), root);
if (i % 2 == 0)
2018-06-29 19:52:40 +02:00
{
c1.SetCultureName("Test " + i + " - FR", _langFr.IsoCode);
c1.SetCultureName("Test " + i + " - ES", _langEs.IsoCode);
2018-06-29 19:52:40 +02:00
}
else
{
c1.SetCultureName("Test", _langFr.IsoCode); // else cannot save
}
ContentService.Save(c1);
}
2018-06-29 19:52:40 +02:00
var entities = EntityService.GetChildren(root.Id, UmbracoObjectTypes.Document).ToArray();
2018-06-29 19:52:40 +02:00
Assert.AreEqual(10, entities.Length);
for (var i = 0; i < entities.Length; i++)
{
Assert.AreEqual(0, entities[i].AdditionalData.Count);
2018-06-29 19:52:40 +02:00
if (i % 2 == 0)
{
var doc = (IDocumentEntitySlim)entities[i];
var keys = doc.CultureNames.Keys.ToList();
var vals = doc.CultureNames.Values.ToList();
Assert.AreEqual(_langFr.IsoCode.ToLowerInvariant(), keys[0].ToLowerInvariant());
Assert.AreEqual("Test " + i + " - FR", vals[0]);
Assert.AreEqual(_langEs.IsoCode.ToLowerInvariant(), keys[1].ToLowerInvariant());
Assert.AreEqual("Test " + i + " - ES", vals[1]);
}
else
2018-06-29 19:52:40 +02:00
{
Assert.AreEqual(0, entities[i].AdditionalData.Count);
}
}
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Children_By_ParentId()
{
var entities = EntityService.GetChildren(_folderId);
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Count(), Is.EqualTo(3));
Assert.That(entities.Any(x => x.Trashed), Is.False);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Descendants_By_ParentId()
{
var entities = EntityService.GetDescendants(_folderId);
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Count(), Is.EqualTo(4));
Assert.That(entities.Any(x => x.Trashed), Is.False);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Throws_When_Getting_All_With_Invalid_Type()
{
var objectTypeId = Constants.ObjectTypes.ContentItem;
2018-06-29 19:52:40 +02:00
Assert.Throws<NotSupportedException>(() => EntityService.GetAll<IContentBase>());
Assert.Throws<NotSupportedException>(() => EntityService.GetAll(objectTypeId));
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_ContentTypes_By_UmbracoObjectTypes()
{
var entities = EntityService.GetAll(UmbracoObjectTypes.DocumentType).ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Count(), Is.EqualTo(1));
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_ContentTypes_By_UmbracoObjectType_Id()
{
var objectTypeId = Constants.ObjectTypes.DocumentType;
var entities = EntityService.GetAll(objectTypeId).ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Count(), Is.EqualTo(1));
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_ContentTypes_By_Type()
{
var entities = EntityService.GetAll<IContentType>().ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Count(), Is.EqualTo(1));
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Find_All_Media_By_UmbracoObjectTypes()
{
var entities = EntityService.GetAll(UmbracoObjectTypes.Media).ToArray();
2018-06-29 19:52:40 +02:00
Assert.That(entities.Any(), Is.True);
Assert.That(entities.Length, Is.EqualTo(5));
2018-06-29 19:52:40 +02:00
foreach (var entity in entities)
{
Assert.IsTrue(entity.GetType().Implements<IMediaEntitySlim>());
Console.WriteLine(((IMediaEntitySlim)entity).MediaPath);
Assert.IsNotEmpty(((IMediaEntitySlim)entity).MediaPath);
2018-06-29 19:52:40 +02:00
}
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_ObjectType()
{
var mediaObjectType = EntityService.GetObjectType(1031);
2018-06-29 19:52:40 +02:00
Assert.NotNull(mediaObjectType);
Assert.AreEqual(mediaObjectType, UmbracoObjectTypes.MediaType);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Key_For_Id_With_Unknown_Type()
{
var result = EntityService.GetKey(_contentType.Id, UmbracoObjectTypes.Unknown);
2018-06-29 19:52:40 +02:00
Assert.IsTrue(result.Success);
Assert.AreEqual(Guid.Parse("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522"), result.Result);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Key_For_Id()
{
var result = EntityService.GetKey(_contentType.Id, UmbracoObjectTypes.DocumentType);
2018-06-29 19:52:40 +02:00
Assert.IsTrue(result.Success);
Assert.AreEqual(Guid.Parse("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522"), result.Result);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Cannot_Get_Key_For_Id_With_Incorrect_Object_Type()
{
var result1 = EntityService.GetKey(_contentType.Id, UmbracoObjectTypes.DocumentType);
var result2 = EntityService.GetKey(_contentType.Id, UmbracoObjectTypes.MediaType);
2018-06-29 19:52:40 +02:00
Assert.IsTrue(result1.Success);
Assert.IsFalse(result2.Success);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Id_For_Key_With_Unknown_Type()
{
var result =
EntityService.GetId(Guid.Parse("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522"), UmbracoObjectTypes.Unknown);
2018-06-29 19:52:40 +02:00
Assert.IsTrue(result.Success);
Assert.AreEqual(_contentType.Id, result.Result);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Can_Get_Id_For_Key()
{
var result = EntityService.GetId(Guid.Parse("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522"),
UmbracoObjectTypes.DocumentType);
2018-06-29 19:52:40 +02:00
Assert.IsTrue(result.Success);
Assert.AreEqual(_contentType.Id, result.Result);
}
2018-06-29 19:52:40 +02:00
[Test]
public void EntityService_Cannot_Get_Id_For_Key_With_Incorrect_Object_Type()
{
var result1 = EntityService.GetId(Guid.Parse("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522"),
UmbracoObjectTypes.DocumentType);
var result2 = EntityService.GetId(Guid.Parse("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522"),
UmbracoObjectTypes.MediaType);
2018-06-29 19:52:40 +02:00
Assert.IsTrue(result1.Success);
Assert.IsFalse(result2.Success);
}
2018-06-29 19:52:40 +02:00
[Test]
public void ReserveId()
{
var guid = Guid.NewGuid();
2018-06-29 19:52:40 +02:00
// can reserve
var reservedId = EntityService.ReserveId(guid);
Assert.IsTrue(reservedId > 0);
2018-06-29 19:52:40 +02:00
// can get it back
var id = EntityService.GetId(guid, UmbracoObjectTypes.DocumentType);
Assert.IsTrue(id.Success);
Assert.AreEqual(reservedId, id.Result);
2018-06-29 19:52:40 +02:00
// anything goes
id = EntityService.GetId(guid, UmbracoObjectTypes.Media);
Assert.IsTrue(id.Success);
Assert.AreEqual(reservedId, id.Result);
2018-06-29 19:52:40 +02:00
// a random guid won't work
Assert.IsFalse(EntityService.GetId(Guid.NewGuid(), UmbracoObjectTypes.DocumentType).Success);
}
2018-06-29 19:52:40 +02:00
private static bool s_isSetup;
private int _folderId;
private ContentType _contentType;
private Content _textpage;
private Content _subpage;
private Content _subpage2;
private Content _trashed;
private IMediaType _folderMediaType;
private Media _folder;
private IMediaType _imageMediaType;
private Media _image;
private Media _subfolder;
private Media _subfolder2;
public void CreateTestData()
{
if (s_isSetup == false)
{
s_isSetup = true;
var template = TemplateBuilder.CreateTextPageTemplate();
FileService.SaveTemplate(template); // else, FK violation on contentType!
// Create and Save ContentType "umbTextpage" -> _contentType.Id
_contentType =
ContentTypeBuilder.CreateSimpleContentType("umbTextpage", "Textpage", defaultTemplateId: template.Id);
_contentType.Key = new Guid("1D3A8E6E-2EA9-4CC1-B229-1AEE19821522");
ContentTypeService.Save(_contentType);
// Create and Save Content "Homepage" based on "umbTextpage" -> 1053
_textpage = ContentBuilder.CreateSimpleContent(_contentType);
_textpage.Key = new Guid("B58B3AD4-62C2-4E27-B1BE-837BD7C533E0");
ContentService.Save(_textpage, 0);
// Create and Save Content "Text Page 1" based on "umbTextpage" -> 1054
_subpage = ContentBuilder.CreateSimpleContent(_contentType, "Text Page 1", _textpage.Id);
var contentSchedule = ContentScheduleCollection.CreateWithEntry(DateTime.Now.AddMinutes(-5), null);
ContentService.Save(_subpage, 0, contentSchedule);
// Create and Save Content "Text Page 2" based on "umbTextpage" -> 1055
_subpage2 = ContentBuilder.CreateSimpleContent(_contentType, "Text Page 2", _textpage.Id);
ContentService.Save(_subpage2, 0);
// Create and Save Content "Text Page Deleted" based on "umbTextpage" -> 1056
_trashed = ContentBuilder.CreateSimpleContent(_contentType, "Text Page Deleted", -20);
_trashed.Trashed = true;
ContentService.Save(_trashed, 0);
// Create and Save folder-Media -> 1057
_folderMediaType = MediaTypeService.Get(1031);
_folder = MediaBuilder.CreateMediaFolder(_folderMediaType, -1);
MediaService.Save(_folder, 0);
_folderId = _folder.Id;
// Create and Save image-Media -> 1058
_imageMediaType = MediaTypeService.Get(1032);
_image = MediaBuilder.CreateMediaImage(_imageMediaType, _folder.Id);
MediaService.Save(_image, 0);
// Create and Save file-Media -> 1059
var fileMediaType = MediaTypeService.Get(1033);
var file = MediaBuilder.CreateMediaFile(fileMediaType, _folder.Id);
MediaService.Save(file, 0);
// Create and save sub folder -> 1060
_subfolder = MediaBuilder.CreateMediaFolder(_folderMediaType, _folder.Id);
MediaService.Save(_subfolder, 0);
// Create and save sub folder -> 1061
_subfolder2 = MediaBuilder.CreateMediaFolder(_folderMediaType, _subfolder.Id);
MediaService.Save(_subfolder2, 0);
2018-06-29 19:52:40 +02:00
}
}
}