2020-11-30 00:45:38 +00:00
|
|
|
using System.Collections.Generic;
|
2021-04-12 17:50:05 +10:00
|
|
|
using System.Data;
|
2020-11-29 13:59:08 +00:00
|
|
|
using System.Linq;
|
2020-11-29 13:56:58 +00:00
|
|
|
using System.Threading;
|
|
|
|
|
using System.Threading.Tasks;
|
|
|
|
|
using Microsoft.AspNetCore.Identity;
|
2022-12-05 12:25:55 +01:00
|
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
2020-11-29 13:56:58 +00:00
|
|
|
using Moq;
|
|
|
|
|
using NUnit.Framework;
|
2021-04-12 17:50:05 +10:00
|
|
|
using Umbraco.Cms.Core.Events;
|
2021-02-22 20:55:12 +00:00
|
|
|
using Umbraco.Cms.Core.Mapping;
|
|
|
|
|
using Umbraco.Cms.Core.Models;
|
Published members cleanup (#10159)
* Getting new netcore PublicAccessChecker in place
* Adds full test coverage for PublicAccessChecker
* remove PublicAccessComposer
* adjust namespaces, ensure RoleManager works, separate public access controller, reduce content controller
* Implements the required methods on IMemberManager, removes old migrated code
* Updates routing to be able to re-route, Fixes middleware ordering ensuring endpoints are last, refactors pipeline options, adds public access middleware, ensures public access follows all hops
* adds note
* adds note
* Cleans up ext methods, ensures that members identity is added on both front-end and back ends. updates how UmbracoApplicationBuilder works in that it explicitly starts endpoints at the time of calling.
* Changes name to IUmbracoEndpointBuilder
* adds note
* Fixing tests, fixing error describers so there's 2x one for back office, one for members, fixes TryConvertTo, fixes login redirect
* fixing build
* Updates user manager to correctly validate password hashing and injects the IBackOfficeUserPasswordChecker
* Merges PR
* Fixes up build and notes
* Implements security stamp and email confirmed for members, cleans up a bunch of repo/service level member groups stuff, shares user store code between members and users and fixes the user identity object so we arent' tracking both groups and roles.
* Security stamp for members is now working
* Fixes keepalive, fixes PublicAccessMiddleware to not throw, updates startup code to be more clear and removes magic that registers middleware.
* adds note
* removes unused filter, fixes build
* fixes WebPath and tests
* Looks up entities in one query
* remove usings
* Fix test, remove stylesheet
* Set status code before we write to response to avoid error
* Ensures that users and members are validated when logging in. Shares more code between users and members.
* merge changes
* oops
* Reducing and removing published member cache
* Fixes RepositoryCacheKeys to ensure the keys are normalized
* oops didn't mean to commit this
* Fix casing issues with caching, stop boxing value types for all cache operations, stop re-creating string keys in DefaultRepositoryCachePolicy
* oops didn't mean to comit this
* bah, far out this keeps getting recommitted. sorry
* cannot inject IPublishedMemberCache and cannot have IPublishedMember
* splits out files, fixes build
* fix tests
* removes membership provider classes
* removes membership provider classes
* updates the identity map definition
* reverts commented out lines
* reverts commented out lines
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-22 21:21:43 +10:00
|
|
|
using Umbraco.Cms.Core.PublishedCache;
|
2021-02-23 09:05:06 +01:00
|
|
|
using Umbraco.Cms.Core.Scoping;
|
|
|
|
|
using Umbraco.Cms.Core.Security;
|
2021-02-22 20:55:12 +00:00
|
|
|
using Umbraco.Cms.Core.Services;
|
2023-10-10 11:51:47 +02:00
|
|
|
using Umbraco.Cms.Tests.UnitTests.TestHelpers;
|
2021-02-22 20:55:12 +00:00
|
|
|
using Umbraco.Cms.Tests.UnitTests.Umbraco.Core.ShortStringHelper;
|
2022-06-21 08:09:38 +02:00
|
|
|
using IScopeProvider = Umbraco.Cms.Infrastructure.Scoping.IScopeProvider;
|
2020-11-29 13:56:58 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Infrastructure.Security;
|
|
|
|
|
|
|
|
|
|
[TestFixture]
|
|
|
|
|
public class MemberUserStoreTests
|
2020-11-29 13:56:58 +00:00
|
|
|
{
|
2022-06-21 08:09:38 +02:00
|
|
|
private Mock<IMemberService> _mockMemberService;
|
|
|
|
|
|
|
|
|
|
public MemberUserStore CreateSut()
|
2020-11-29 13:56:58 +00:00
|
|
|
{
|
2022-06-21 08:09:38 +02:00
|
|
|
_mockMemberService = new Mock<IMemberService>();
|
2023-10-10 11:51:47 +02:00
|
|
|
var mockScopeProvider = TestHelper.ScopeProvider;
|
2022-06-21 08:09:38 +02:00
|
|
|
|
|
|
|
|
return new MemberUserStore(
|
|
|
|
|
_mockMemberService.Object,
|
2023-10-10 11:51:47 +02:00
|
|
|
new UmbracoMapper(new MapDefinitionCollection(() => new List<IMapDefinition>()), mockScopeProvider, NullLogger<UmbracoMapper>.Instance),
|
|
|
|
|
mockScopeProvider,
|
2022-06-21 08:09:38 +02:00
|
|
|
new IdentityErrorDescriber(),
|
|
|
|
|
Mock.Of<IPublishedSnapshotAccessor>(),
|
|
|
|
|
Mock.Of<IExternalLoginWithKeyService>(),
|
|
|
|
|
Mock.Of<ITwoFactorLoginService>());
|
|
|
|
|
}
|
2020-11-29 13:56:58 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
[Test]
|
|
|
|
|
public async Task GivenISetNormalizedUserName_ThenIShouldGetASuccessResult()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
|
|
|
|
var fakeUser = new MemberIdentityUser { UserName = "MyName" };
|
2021-03-06 18:57:54 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
// act
|
|
|
|
|
await sut.SetNormalizedUserNameAsync(fakeUser, "NewName", CancellationToken.None);
|
2021-03-06 18:57:54 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
// assert
|
|
|
|
|
Assert.AreEqual("NewName", fakeUser.UserName);
|
|
|
|
|
Assert.AreEqual("NewName", await sut.GetNormalizedUserNameAsync(fakeUser, CancellationToken.None));
|
|
|
|
|
}
|
2021-03-06 18:57:54 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
[Test]
|
|
|
|
|
public async Task GivenICreateUser_AndTheUserIsNull_ThenIShouldGetAFailedResultAsync()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
|
|
|
|
|
|
|
|
|
// act
|
|
|
|
|
var actual = await sut.CreateAsync(null);
|
|
|
|
|
|
|
|
|
|
// assert
|
|
|
|
|
Assert.IsFalse(actual.Succeeded);
|
|
|
|
|
Assert.IsTrue(actual.Errors.Any(x =>
|
|
|
|
|
x.Code == "IdentityErrorUserStore" && x.Description == "Value cannot be null. (Parameter 'user')"));
|
|
|
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
[Test]
|
|
|
|
|
public async Task GivenICreateUser_AndTheUserDoesNotHaveIdentity_ThenIShouldGetAFailedResultAsync()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
|
|
|
|
var fakeUser = new MemberIdentityUser();
|
|
|
|
|
|
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
|
|
|
var mockMember = Mock.Of<IMember>(m =>
|
|
|
|
|
m.Name == "fakeName" &&
|
|
|
|
|
m.Email == "fakeemail@umbraco.com" &&
|
|
|
|
|
m.Username == "fakeUsername" &&
|
|
|
|
|
m.RawPasswordValue == "fakePassword" &&
|
|
|
|
|
m.ContentTypeAlias == fakeMemberType.Alias &&
|
|
|
|
|
m.HasIdentity == false);
|
|
|
|
|
|
|
|
|
|
_mockMemberService
|
|
|
|
|
.Setup(x => x.CreateMember(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()))
|
|
|
|
|
.Returns(mockMember);
|
|
|
|
|
_mockMemberService.Setup(x => x.Save(mockMember));
|
|
|
|
|
|
|
|
|
|
// act
|
|
|
|
|
var actual = await sut.CreateAsync(null);
|
|
|
|
|
|
|
|
|
|
// assert
|
|
|
|
|
Assert.IsFalse(actual.Succeeded);
|
|
|
|
|
Assert.IsTrue(actual.Errors.Any(x =>
|
|
|
|
|
x.Code == "IdentityErrorUserStore" && x.Description == "Value cannot be null. (Parameter 'user')"));
|
|
|
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
[Test]
|
|
|
|
|
public async Task GivenICreateANewUser_AndTheUserIsPopulatedCorrectly_ThenIShouldGetASuccessResultAsync()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
|
|
|
|
var fakeUser = new MemberIdentityUser();
|
|
|
|
|
|
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
|
|
|
var mockMember = Mock.Of<IMember>(m =>
|
|
|
|
|
m.Name == "fakeName" &&
|
|
|
|
|
m.Email == "fakeemail@umbraco.com" &&
|
|
|
|
|
m.Username == "fakeUsername" &&
|
|
|
|
|
m.RawPasswordValue == "fakePassword" &&
|
|
|
|
|
m.Comments == "hello" &&
|
|
|
|
|
m.ContentTypeAlias == fakeMemberType.Alias &&
|
|
|
|
|
m.HasIdentity == true);
|
|
|
|
|
|
|
|
|
|
_mockMemberService
|
|
|
|
|
.Setup(x => x.CreateMember(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()))
|
|
|
|
|
.Returns(mockMember);
|
|
|
|
|
_mockMemberService.Setup(x => x.Save(mockMember));
|
|
|
|
|
|
|
|
|
|
// act
|
|
|
|
|
var identityResult = await sut.CreateAsync(fakeUser, CancellationToken.None);
|
|
|
|
|
|
|
|
|
|
// assert
|
|
|
|
|
Assert.IsTrue(identityResult.Succeeded);
|
|
|
|
|
Assert.IsTrue(!identityResult.Errors.Any());
|
|
|
|
|
_mockMemberService.Verify(x =>
|
|
|
|
|
x.CreateMember(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()));
|
|
|
|
|
_mockMemberService.Verify(x => x.Save(mockMember));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
[Test]
|
|
|
|
|
public async Task GivenIUpdateAUser_ThenIShouldGetASuccessResultAsync()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
|
|
|
|
var fakeUser = new MemberIdentityUser
|
2021-03-06 13:51:41 +00:00
|
|
|
{
|
2022-06-21 08:09:38 +02:00
|
|
|
Id = "123",
|
|
|
|
|
Name = "fakeName",
|
|
|
|
|
Email = "fakeemail@umbraco.com",
|
|
|
|
|
UserName = "fakeUsername",
|
|
|
|
|
Comments = "hello",
|
|
|
|
|
LastLoginDateUtc = DateTime.UtcNow,
|
|
|
|
|
LastPasswordChangeDateUtc = DateTime.UtcNow,
|
|
|
|
|
EmailConfirmed = true,
|
|
|
|
|
AccessFailedCount = 3,
|
|
|
|
|
LockoutEnd = DateTime.UtcNow.AddDays(10),
|
|
|
|
|
IsApproved = true,
|
|
|
|
|
PasswordHash = "abcde",
|
|
|
|
|
SecurityStamp = "abc",
|
|
|
|
|
};
|
|
|
|
|
fakeUser.Roles.Add(new IdentityUserRole<string> { RoleId = "role1", UserId = "123" });
|
|
|
|
|
fakeUser.Roles.Add(new IdentityUserRole<string> { RoleId = "role2", UserId = "123" });
|
|
|
|
|
|
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
|
|
|
var mockMember = Mock.Of<IMember>(m =>
|
|
|
|
|
m.Id == 123 &&
|
|
|
|
|
m.Name == "a" &&
|
|
|
|
|
m.Email == "a@b.com" &&
|
|
|
|
|
m.Username == "c" &&
|
|
|
|
|
m.RawPasswordValue == "d" &&
|
|
|
|
|
m.Comments == "e" &&
|
|
|
|
|
m.ContentTypeAlias == fakeMemberType.Alias &&
|
|
|
|
|
m.HasIdentity == true &&
|
|
|
|
|
m.EmailConfirmedDate == DateTime.MinValue &&
|
|
|
|
|
m.FailedPasswordAttempts == 0 &&
|
|
|
|
|
m.LastLockoutDate == DateTime.MinValue &&
|
|
|
|
|
m.IsApproved == false &&
|
|
|
|
|
m.RawPasswordValue == "xyz" &&
|
|
|
|
|
m.SecurityStamp == "xyz");
|
|
|
|
|
|
|
|
|
|
_mockMemberService.Setup(x => x.Save(mockMember));
|
|
|
|
|
_mockMemberService.Setup(x => x.GetById(123)).Returns(mockMember);
|
|
|
|
|
|
|
|
|
|
// act
|
|
|
|
|
var identityResult = await sut.UpdateAsync(fakeUser, CancellationToken.None);
|
|
|
|
|
|
|
|
|
|
// assert
|
|
|
|
|
Assert.IsTrue(identityResult.Succeeded);
|
|
|
|
|
Assert.IsTrue(!identityResult.Errors.Any());
|
|
|
|
|
|
|
|
|
|
Assert.AreEqual(fakeUser.Name, mockMember.Name);
|
|
|
|
|
Assert.AreEqual(fakeUser.Email, mockMember.Email);
|
|
|
|
|
Assert.AreEqual(fakeUser.UserName, mockMember.Username);
|
|
|
|
|
Assert.AreEqual(fakeUser.Comments, mockMember.Comments);
|
|
|
|
|
Assert.AreEqual(fakeUser.LastPasswordChangeDateUtc.Value.ToLocalTime(), mockMember.LastPasswordChangeDate);
|
|
|
|
|
Assert.AreEqual(fakeUser.LastLoginDateUtc.Value.ToLocalTime(), mockMember.LastLoginDate);
|
|
|
|
|
Assert.AreEqual(fakeUser.AccessFailedCount, mockMember.FailedPasswordAttempts);
|
|
|
|
|
Assert.AreEqual(fakeUser.IsLockedOut, mockMember.IsLockedOut);
|
|
|
|
|
Assert.AreEqual(fakeUser.IsApproved, mockMember.IsApproved);
|
|
|
|
|
Assert.AreEqual(fakeUser.PasswordHash, mockMember.RawPasswordValue);
|
|
|
|
|
Assert.AreEqual(fakeUser.SecurityStamp, mockMember.SecurityStamp);
|
|
|
|
|
Assert.AreNotEqual(DateTime.MinValue, mockMember.EmailConfirmedDate.Value);
|
|
|
|
|
|
|
|
|
|
_mockMemberService.Verify(x => x.Save(mockMember));
|
|
|
|
|
_mockMemberService.Verify(x => x.GetById(123));
|
|
|
|
|
_mockMemberService.Verify(x => x.ReplaceRoles(new[] { 123 }, new[] { "role1", "role2" }));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
[Test]
|
|
|
|
|
public async Task GivenIDeleteUser_AndTheUserIsNotPresent_ThenIShouldGetAFailedResultAsync()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
2021-03-06 13:51:41 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
// act
|
|
|
|
|
var actual = await sut.DeleteAsync(null);
|
2021-03-06 13:51:41 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
// assert
|
|
|
|
|
Assert.IsTrue(actual.Succeeded == false);
|
|
|
|
|
Assert.IsTrue(actual.Errors.Any(x =>
|
|
|
|
|
x.Code == "IdentityErrorUserStore" && x.Description == "Value cannot be null. (Parameter 'user')"));
|
|
|
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
[Test]
|
|
|
|
|
public async Task GivenIDeleteUser_AndTheUserIsDeletedCorrectly_ThenIShouldGetASuccessResultAsync()
|
|
|
|
|
{
|
|
|
|
|
// arrange
|
|
|
|
|
var sut = CreateSut();
|
|
|
|
|
var fakeUser = new MemberIdentityUser(777);
|
|
|
|
|
var fakeCancellationToken = CancellationToken.None;
|
2021-03-06 13:51:41 +00:00
|
|
|
|
2022-06-21 08:09:38 +02:00
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
|
|
|
IMember mockMember = new Member(fakeMemberType)
|
2021-03-06 13:51:41 +00:00
|
|
|
{
|
2022-06-21 08:09:38 +02:00
|
|
|
Id = 777,
|
|
|
|
|
Name = "fakeName",
|
|
|
|
|
Email = "fakeemail@umbraco.com",
|
|
|
|
|
Username = "fakeUsername",
|
|
|
|
|
RawPasswordValue = "fakePassword",
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
_mockMemberService.Setup(x => x.GetById(mockMember.Id)).Returns(mockMember);
|
|
|
|
|
_mockMemberService.Setup(x => x.Delete(mockMember));
|
|
|
|
|
|
|
|
|
|
// act
|
|
|
|
|
var identityResult = await sut.DeleteAsync(fakeUser, fakeCancellationToken);
|
|
|
|
|
|
|
|
|
|
// assert
|
|
|
|
|
Assert.IsTrue(identityResult.Succeeded);
|
|
|
|
|
Assert.IsTrue(!identityResult.Errors.Any());
|
|
|
|
|
_mockMemberService.Verify(x => x.GetById(mockMember.Id));
|
|
|
|
|
_mockMemberService.Verify(x => x.Delete(mockMember));
|
|
|
|
|
_mockMemberService.VerifyNoOtherCalls();
|
2020-11-29 13:56:58 +00:00
|
|
|
}
|
|
|
|
|
}
|