From 0688835ac0a35e3ae76fc0db2566fdd2266e7c23 Mon Sep 17 00:00:00 2001 From: Claus Date: Tue, 17 Oct 2017 23:44:03 +0200 Subject: [PATCH] fixing bug in U4-10524 Show warning in UI for the media/content picker that is referencing a trashed or deleted item --- .../propertyeditors/mediapicker/mediapicker.controller.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.controller.js index f550d30c4c..91777bfc3e 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.controller.js @@ -44,7 +44,10 @@ angular.module('umbraco').controller("Umbraco.PropertyEditors.MediaPickerControl function(id) { var found = _.find(medias, function(m) { - return m.udi === id || m.id === id; + // We could use coercion (two ='s) here .. but not sure if this works equally well in all browsers and + // it's prone to someone "fixing" it at some point without knowing the effects. Rather use toString() + // compares and be completely sure it works. + return m.udi.toString() === id.toString() || m.id.toString() === id.toString(); }); if (found) { return found;