yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Maxlength attribute on macro name

Browse Source
This commit is contained in:
Poornima Nayar
2019-08-29 22:09:25 +01:00
committed by Sebastiaan Janssen
parent 0e3f324cb0
commit 088abae314
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Umbraco.Web.UI.Client/src/views/macros/create.html
View File

@@ -19,7 +19,8 @@
</div> </div>
<umb-control-group label="@macro_enterMacroName" hide-label="false"> <umb-control-group label="@macro_enterMacroName" hide-label="false">
<input type="text" name="itemKey" ng-model="vm.itemKey" class="umb-textstring textstring input-block-level" umb-auto-focus required /> <input type="text" name="itemKey" ng-model="vm.itemKey" class="umb-textstring textstring input-block-level"
umb-auto-focus required maxlength="255" />
</umb-control-group> </umb-control-group>
<button type="submit" class="btn btn-primary"><localize key="general_create">Create</localize></button> <button type="submit" class="btn btn-primary"><localize key="general_create">Create</localize></button>

10
src/Umbraco.Web/Editors/MacrosController.cs
View File

@@ -62,6 +62,11 @@ namespace Umbraco.Web.Editors
return this.ReturnErrorResponse("Macro with this alias already exists"); return this.ReturnErrorResponse("Macro with this alias already exists");
} }
if (name == null || name.Length > 255)
{
return this.ReturnErrorResponse("Name cannnot be more than 255 characters in length.");
}
try try
{ {
var macro = new Macro var macro = new Macro
@@ -149,6 +154,11 @@ namespace Umbraco.Web.Editors
return this.ReturnErrorResponse($"No macro data found in request"); return this.ReturnErrorResponse($"No macro data found in request");
} }
if (macroDisplay.Name == null || macroDisplay.Name.Length > 255)
{
return this.ReturnErrorResponse("Name cannnot be more than 255 characters in length.");
}
var macro = _macroService.GetById(int.Parse(macroDisplay.Id.ToString())); var macro = _macroService.GetById(int.Parse(macroDisplay.Id.ToString()));
if (macro == null) if (macro == null)