Merge pull request #11064 from umbraco/v9/bugfix/10650-fix_issue_with_upgrading_while_in_backoffice

Add redirect to /umbraco if you are not in run state.

src/Umbraco.Web.BackOffice/Controllers/BackOfficeController.cs

@@ -12,6 +12,7 @@ using Microsoft.AspNetCore.Identity;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
+using Umbraco.Cms.Core;
 using Umbraco.Cms.Core.Cache;
 using Umbraco.Cms.Core.Configuration.Grid;
 using Umbraco.Cms.Core.Configuration.Models;
@@ -112,11 +113,14 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
         [AllowAnonymous]
         public async Task<IActionResult> Default()
         {
-            // TODO: It seems that if you login during an authorize upgrade and the upgrade fails, you can still
-            // access the back office. This should redirect to the installer in that case?
+            // Check if we not are in an run state, if so we need to redirect
+            if (_runtimeState.Level != RuntimeLevel.Run)
+            {
+                return Redirect("/");
+            }
 
             // force authentication to occur since this is not an authorized endpoint
-            var result = await this.AuthenticateBackOfficeAsync();
+            AuthenticateResult result = await this.AuthenticateBackOfficeAsync();
 
             var viewPath = Path.Combine(Constants.SystemDirectories.Umbraco, Constants.Web.Mvc.BackOfficeArea, nameof(Default) + ".cshtml")
                 .Replace("\\", "/"); // convert to forward slashes since it's a virtual path