yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add test for populating alias in migration

Browse Source
This commit is contained in:
Ronald Barendse
2021-08-31 15:50:49 +02:00
parent ddcf3d5bfc
commit 0895aeaf30
3 changed files with 71 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Umbraco.Core/Migrations/Upgrade/V_8_17_0/AddPropertyTypeGroupColumns.cs
View File

@@ -1,4 +1,5 @@
using System.Linq;
using System.Collections.Generic;
using System.Linq;
using Umbraco.Core.Logging;
using Umbraco.Core.Persistence.Dtos;
@@ -14,9 +15,21 @@ namespace Umbraco.Core.Migrations.Upgrade.V_8_17_0
{
AddColumn<PropertyTypeGroupDto>("type");
// Add column without constraints
AddColumn<PropertyTypeGroupDto>("alias", out var sqls);
// Populate non-null alias column
var dtos = Database.Fetch<PropertyTypeGroupDto>();
foreach (var dto in PopulateAliases(dtos))
Database.Update(dto, x => new { x.Alias });
// Finally add the constraints
foreach (var sql in sqls)
Database.Execute(sql);
}
internal IEnumerable<PropertyTypeGroupDto> PopulateAliases(IEnumerable<PropertyTypeGroupDto> dtos)
{
foreach (var dtosPerAlias in dtos.GroupBy(x => x.Text.ToSafeAlias(true)))
{
var dtosPerAliasAndText = dtosPerAlias.GroupBy(x => x.Text);
@@ -33,7 +46,7 @@ namespace Umbraco.Core.Migrations.Upgrade.V_8_17_0
dto.Alias += numberSuffix;
}
Database.Update(dto, x => new { x.Alias });
yield return dto;
}
numberSuffix++;
@@ -44,9 +57,6 @@ namespace Umbraco.Core.Migrations.Upgrade.V_8_17_0
Logger.Error<AddPropertyTypeGroupColumns>("Detected the same alias {Alias} for different property group names {Names}, the migration added suffixes, but this might break backwards compatibility.", dtosPerAlias.Key, dtosPerAliasAndText.Select(x => x.Key));
}
}
foreach (var sql in sqls)
Database.Execute(sql);
}
}
}