yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix smidge bundles not always invalidated between backoffice versions. (#11700)

Browse Source 
* Introduced new smidge CacheBuster with sensible defaults.

* Bring back reset functionality in SmidgeRuntimeMinifier

* Clearer obsolete messaging.
This commit is contained in:
Paul Johnson
2021-12-02 10:32:19 +00:00
committed by GitHub
parent 6c5851f556
commit 08f106a23f
12 changed files with 257 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/.editorconfig Normal file
View File

@@ -0,0 +1,5 @@
root = false
[*.cs]
csharp_style_var_when_type_is_apparent = true:none
csharp_style_var_elsewhere = true:none

113
tests/Umbraco.Tests.UnitTests/Umbraco.Web.Common/RuntimeMinification/UmbracoSmidgeConfigCacheBusterTests.cs Normal file
View File

@@ -0,0 +1,113 @@
using AutoFixture;
using AutoFixture.AutoMoq;
using AutoFixture.Kernel;
using Microsoft.Extensions.Options;
using Moq;
using NUnit.Framework;
using Smidge;
using Smidge.Cache;
using Umbraco.Cms.Core.Configuration;
using Umbraco.Cms.Core.Configuration.Models;
using Umbraco.Cms.Core.Semver;
using Umbraco.Cms.Web.Common.RuntimeMinification;
using Umbraco.Extensions;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Web.Common.RuntimeMinification
{
/// <remarks>
/// UmbracoCustomizations kindly configures an IUmbracoVersion so we need to go verbose without AutoMoqData
/// </remarks>
[TestFixture]
public class UmbracoSmidgeConfigCacheBusterTests
{
[Test]
public void GetValue_DefaultReleaseSetupWithNoConfiguredVersion_HasSensibleDefaults()
{
var fixture = new Fixture();
fixture.Customize(new AutoMoqCustomization());
var umbracoVersion = fixture.Freeze<Mock<IUmbracoVersion>>();
var entryAssemblyMetadata = fixture.Freeze<Mock<IEntryAssemblyMetadata>>();
var sut = fixture.Create<UmbracoSmidgeConfigCacheBuster>();
umbracoVersion.Setup(x => x.SemanticVersion).Returns(new SemVersion(9, 4, 5, "beta", "41658f99"));
entryAssemblyMetadata.Setup(x => x.Name).Returns("Bills.Brilliant.Bakery");
entryAssemblyMetadata.Setup(x => x.InformationalVersion).Returns("42.1.2-alpha+41658f99");
var result = sut.GetValue();
var expected = $"Bills.Brilliant.Bakery_9.4.5-beta+41658f99_42.1.2-alpha+41658f99".GenerateHash();
Assert.AreEqual(expected, result);
}
[Test]
public void GetValue_DefaultReleaseSetupWithConfiguredVersion_HasSensibleDefaults()
{
var config = Options.Create(new RuntimeMinificationSettings { Version = "1" });
var fixture = new Fixture();
fixture.Customize(new AutoMoqCustomization());
fixture.Inject(config);
var umbracoVersion = fixture.Freeze<Mock<IUmbracoVersion>>();
var entryAssemblyMetadata = fixture.Freeze<Mock<IEntryAssemblyMetadata>>();
var sut = fixture.Create<UmbracoSmidgeConfigCacheBuster>();
umbracoVersion.Setup(x => x.SemanticVersion).Returns(new SemVersion(9, 4, 5, "beta", "41658f99"));
entryAssemblyMetadata.Setup(x => x.Name).Returns("Bills.Brilliant.Bakery");
entryAssemblyMetadata.Setup(x => x.InformationalVersion).Returns("42.1.2-alpha+41658f99");
var result = sut.GetValue();
var expected = $"1_9.4.5-beta+41658f99_42.1.2-alpha+41658f99".GenerateHash();
Assert.AreEqual(expected, result);
}
[Test]
public void GetValue_DefaultReleaseSetupWithNoConfiguredVersion_ChangesWhenUmbracoVersionChanges()
{
var fixture = new Fixture();
fixture.Customize(new AutoMoqCustomization());
var umbracoVersion = fixture.Freeze<Mock<IUmbracoVersion>>();
var entryAssemblyMetadata = fixture.Freeze<Mock<IEntryAssemblyMetadata>>();
var sut = fixture.Create<UmbracoSmidgeConfigCacheBuster>();
umbracoVersion.Setup(x => x.SemanticVersion).Returns(new SemVersion(9, 4, 5, "beta", "41658f99"));
entryAssemblyMetadata.Setup(x => x.Name).Returns("Bills.Brilliant.Bakery");
entryAssemblyMetadata.Setup(x => x.InformationalVersion).Returns("42.1.2-alpha+41658f99");
var before = sut.GetValue();
umbracoVersion.Setup(x => x.SemanticVersion).Returns(new SemVersion(9, 5, 0, "beta", "41658f99"));
sut = fixture.Create<UmbracoSmidgeConfigCacheBuster>();
var after = sut.GetValue();
Assert.AreNotEqual(before, after);
}
[Test]
public void GetValue_DefaultReleaseSetupWithNoConfiguredVersion_ChangesWhenDownstreamVersionChanges()
{
var fixture = new Fixture();
fixture.Customize(new AutoMoqCustomization());
var umbracoVersion = fixture.Freeze<Mock<IUmbracoVersion>>();
var entryAssemblyMetadata = fixture.Freeze<Mock<IEntryAssemblyMetadata>>();
var sut = fixture.Create<UmbracoSmidgeConfigCacheBuster>();
umbracoVersion.Setup(x => x.SemanticVersion).Returns(new SemVersion(9, 4, 5, "beta", "41658f99"));
entryAssemblyMetadata.Setup(x => x.Name).Returns("Bills.Brilliant.Bakery");
entryAssemblyMetadata.Setup(x => x.InformationalVersion).Returns("42.1.2-alpha+41658f99");
var before = sut.GetValue();
entryAssemblyMetadata.Setup(x => x.InformationalVersion).Returns("42.2.0-rc");
sut = fixture.Create<UmbracoSmidgeConfigCacheBuster>();
var after = sut.GetValue();
Assert.AreNotEqual(before, after);
}
}
}