yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Umbraco.Tests.Common warnings. (#17172)

Browse Source 
* Fix async warning.

* Fix MediaFileManager warning.

* Fix TypeLoader warning.

* Fix CodeBase warning.

* Fix ContentTypeEditingBuilder warning.

* Fix _containerKey warning.

* Fix _key warning.

* Fix issues due to merge with contrib

---------

Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com>
This commit is contained in:
Jeroen Breuer
2025-01-03 17:59:50 +01:00
committed by GitHub
parent aaa44a20cb
commit 09575599ad
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Umbraco.Tests.Common/Builders/ContentTypeEditingBuilder.cs
View File

@@ -192,7 +192,7 @@ public class ContentTypeEditingBuilder : ContentTypeEditingBaseBuilder<ContentTy
.Build(); .Build();
} }
public static ContentTypeCreateModel CreateContentTypeWithTwoPropertiesOneVariantAndOneInvariant(string alias = "test", string name = "TestName", string variantPropertyAlias = "variant", string variantPropertyName = "Variant", string invariantAlias = "invariant", string invariantName = "Invariant") public static ContentTypeCreateModel CreateContentTypeWithTwoPropertiesOneVariantAndOneInvariant(string alias = "test", string name = "TestName", string variantPropertyAlias = "variant", string variantPropertyName = "Variant", string invariantAlias = "invariant", string invariantName = "Invariant")
{ {
var containerKey = Guid.NewGuid(); var containerKey = Guid.NewGuid();
var builder = new ContentTypeEditingBuilder(); var builder = new ContentTypeEditingBuilder();

5
tests/Umbraco.Tests.Common/TestHelperBase.cs
View File

@@ -96,8 +96,7 @@ public abstract class TestHelperBase
Mock.Of<IMediaPathScheme>(), Mock.Of<IMediaPathScheme>(),
loggerFactory.CreateLogger<MediaFileManager>(), loggerFactory.CreateLogger<MediaFileManager>(),
Mock.Of<IShortStringHelper>(), Mock.Of<IShortStringHelper>(),
Mock.Of<IServiceProvider>(), Mock.Of<IServiceProvider>());
Options.Create(new ContentSettings()));
var databaseFactory = new Mock<IUmbracoDatabaseFactory>(); var databaseFactory = new Mock<IUmbracoDatabaseFactory>();
var database = new Mock<IUmbracoDatabase>(); var database = new Mock<IUmbracoDatabase>();
var sqlContext = new Mock<ISqlContext>(); var sqlContext = new Mock<ISqlContext>();
@@ -207,7 +206,7 @@ public abstract class TestHelperBase
throw new ArgumentException("relativePath must start with '~/'", nameof(relativePath)); throw new ArgumentException("relativePath must start with '~/'", nameof(relativePath));
} }
var codeBase = typeof(TestHelperBase).Assembly.CodeBase; var codeBase = typeof(TestHelperBase).Assembly.Location;
var uri = new Uri(codeBase); var uri = new Uri(codeBase);
var path = uri.LocalPath; var path = uri.LocalPath;
var bin = Path.GetDirectoryName(path); var bin = Path.GetDirectoryName(path);

2
tests/Umbraco.Tests.Common/TestLastChanceFinder.cs
View File

@@ -8,5 +8,5 @@ namespace Umbraco.Cms.Tests.Common;
public class TestLastChanceFinder : IContentLastChanceFinder public class TestLastChanceFinder : IContentLastChanceFinder
{ {
public async Task<bool> TryFindContent(IPublishedRequestBuilder frequest) => false; public Task<bool> TryFindContent(IPublishedRequestBuilder frequest) => Task.FromResult(false);
} }