Improve performance and reduce memory use and reduce array allocations by reusing char[] (#9166)

* Reduce array allocations by reusing char[]

* don't hide .Equals()

* Reduce memory use by reducing array allocations

* Revert "Reduce memory use by reducing array allocations"

This reverts commit faf6b60234167f5443435243eb52187ab07d514c.

* reuse char[] for string.split() to avoid params [] allocation
This commit is contained in:
Chad
2021-01-22 15:02:25 +13:00
committed by GitHub
parent 335c6b17b9
commit 0bd4dced0b
97 changed files with 310 additions and 167 deletions

View File

@@ -403,7 +403,7 @@ namespace Umbraco.Core.Persistence.SqlSyntax
var columns = string.IsNullOrEmpty(columnDefinition.PrimaryKeyColumns)
? GetQuotedColumnName(columnDefinition.Name)
: string.Join(", ", columnDefinition.PrimaryKeyColumns
.Split(new[] { ',', ' ' }, StringSplitOptions.RemoveEmptyEntries)
.Split(Constants.CharArrays.CommaSpace, StringSplitOptions.RemoveEmptyEntries)
.Select(GetQuotedColumnName));
var primaryKeyPart = string.Concat("PRIMARY KEY", columnDefinition.IsIndexed ? " CLUSTERED" : " NONCLUSTERED");