From 0bffe9aa554d6c3455cf8b875e7c42cff9ac81ed Mon Sep 17 00:00:00 2001 From: Andy Butland Date: Sat, 31 Oct 2020 22:53:16 +0100 Subject: [PATCH] Updated health check configuration validation tests to match change to cron expression. --- .../HostedServices/HealthCheckNotifier.cs | 1 - .../Models/Validation/HealthChecksSettingsValidatorTests.cs | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Infrastructure/HostedServices/HealthCheckNotifier.cs b/src/Umbraco.Infrastructure/HostedServices/HealthCheckNotifier.cs index f4cf33fa61..b9e41c8410 100644 --- a/src/Umbraco.Infrastructure/HostedServices/HealthCheckNotifier.cs +++ b/src/Umbraco.Infrastructure/HostedServices/HealthCheckNotifier.cs @@ -52,7 +52,6 @@ namespace Umbraco.Infrastructure.HostedServices _logger = logger; _profilingLogger = profilingLogger; } - public override async void ExecuteAsync(object state) { diff --git a/src/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/HealthChecksSettingsValidatorTests.cs b/src/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/HealthChecksSettingsValidatorTests.cs index e6ca06a34b..d38b41720e 100644 --- a/src/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/HealthChecksSettingsValidatorTests.cs +++ b/src/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/HealthChecksSettingsValidatorTests.cs @@ -21,12 +21,12 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Core.Configuration.Models.Validation public void Returns_Fail_For_Configuration_With_Invalid_Notification_FirstRunTime() { var validator = new HealthChecksSettingsValidator(); - var options = BuildHealthChecksSettings(firstRunTime: "25:00"); + var options = BuildHealthChecksSettings(firstRunTime: "0 3 *"); var result = validator.Validate("settings", options); Assert.False(result.Succeeded); } - private static HealthChecksSettings BuildHealthChecksSettings(string firstRunTime = "12:00") + private static HealthChecksSettings BuildHealthChecksSettings(string firstRunTime = "0 3 * * *") { return new HealthChecksSettings {