From 0d12852cd8520dd21c4e33136a93d4747506d816 Mon Sep 17 00:00:00 2001
From: abi <abi@novicell.co.uk>
Date: Tue, 21 Jan 2020 09:07:10 +0000
Subject: [PATCH] Address Shannon comments

Add code documentation, return empty enumerable instead of allocate empty list
---
 .../Search/IUmbracoTreeSearcherFields.cs         | 16 +++++++++++++++-
 .../Search/UmbracoTreeSearcherFields.cs          |  7 +++----
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/Umbraco.Web/Search/IUmbracoTreeSearcherFields.cs b/src/Umbraco.Web/Search/IUmbracoTreeSearcherFields.cs
index eaa5d743a1..c5a6c53d19 100644
--- a/src/Umbraco.Web/Search/IUmbracoTreeSearcherFields.cs
+++ b/src/Umbraco.Web/Search/IUmbracoTreeSearcherFields.cs
@@ -2,12 +2,26 @@ using System.Collections.Generic;
 
 namespace Umbraco.Web.Search
 {
+    /// <summary>
+    /// Used to propagate hardcoded internal Field lists
+    /// </summary>
     public interface IUmbracoTreeSearcherFields
     {
+        /// <summary>
+        /// Propagate list of searchable fields for all node types
+        /// </summary>
         IEnumerable<string> GetBackOfficeFields();
+        /// <summary>
+        /// Propagate list of searchable fields for Members
+        /// </summary>
         IEnumerable<string> GetBackOfficeMembersFields();
-
+        /// <summary>
+        /// Propagate list of searchable fields for Media
+        /// </summary>
         IEnumerable<string> GetBackOfficeMediaFields();
+        /// <summary>
+        /// Propagate list of searchable fields for Documents
+        /// </summary>
         IEnumerable<string> GetBackOfficeDocumentFields();
     }
 }
diff --git a/src/Umbraco.Web/Search/UmbracoTreeSearcherFields.cs b/src/Umbraco.Web/Search/UmbracoTreeSearcherFields.cs
index d1c663024b..f90d7bc6b6 100644
--- a/src/Umbraco.Web/Search/UmbracoTreeSearcherFields.cs
+++ b/src/Umbraco.Web/Search/UmbracoTreeSearcherFields.cs
@@ -1,8 +1,8 @@
 using System.Collections.Generic;
+using System.Linq;
 using Umbraco.Examine;
-using Umbraco.Web.Search;
 
-namespace Umbraco.Web
+namespace Umbraco.Web.Search
 {
     public class UmbracoTreeSearcherFields : IUmbracoTreeSearcherFields
     {
@@ -23,10 +23,9 @@ namespace Umbraco.Web
         {
             return _backOfficeMediaFields;
         }
-        private IReadOnlyList<string> _backOfficeDocumentFields = new List<string> ();
         public IEnumerable<string> GetBackOfficeDocumentFields()
         {
-            return _backOfficeDocumentFields;
+            return Enumerable.Empty<string>();
         }
     }
 }