From 0dd2beb4848ae77fad64a42554eec0a3a1c1b79d Mon Sep 17 00:00:00 2001
From: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
Date: Wed, 31 Jan 2024 15:00:47 +0100
Subject: [PATCH] V14: Update DataTypeControllerBase to use GetAllAsync()
 (#15641)

* Update to use GetAllAsync()

* Obsolete GetAll

---------

Co-authored-by: Elitsa <elm@umbraco.dk>
---
 .../Controllers/DataType/Tree/DataTypeTreeControllerBase.cs     | 2 +-
 src/Umbraco.Core/Services/IDataTypeService.cs                   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Umbraco.Cms.Api.Management/Controllers/DataType/Tree/DataTypeTreeControllerBase.cs b/src/Umbraco.Cms.Api.Management/Controllers/DataType/Tree/DataTypeTreeControllerBase.cs
index bb2d24fe57..f2628133ac 100644
--- a/src/Umbraco.Cms.Api.Management/Controllers/DataType/Tree/DataTypeTreeControllerBase.cs
+++ b/src/Umbraco.Cms.Api.Management/Controllers/DataType/Tree/DataTypeTreeControllerBase.cs
@@ -30,7 +30,7 @@ public class DataTypeTreeControllerBase : FolderTreeControllerBase<DataTypeTreeI
     protected override DataTypeTreeItemResponseModel[] MapTreeItemViewModels(Guid? parentId, IEntitySlim[] entities)
     {
         var dataTypes = _dataTypeService
-            .GetAll(entities.Select(entity => entity.Id).ToArray())
+            .GetAllAsync(entities.Select(entity => entity.Key).ToArray()).GetAwaiter().GetResult()
             .ToDictionary(contentType => contentType.Id);
 
         return entities.Select(entity =>
diff --git a/src/Umbraco.Core/Services/IDataTypeService.cs b/src/Umbraco.Core/Services/IDataTypeService.cs
index cd2a8b71a8..ad593b6d0f 100644
--- a/src/Umbraco.Core/Services/IDataTypeService.cs
+++ b/src/Umbraco.Core/Services/IDataTypeService.cs
@@ -112,6 +112,7 @@ public interface IDataTypeService : IService
     /// </summary>
     /// <param name="ids">Optional array of Ids</param>
     /// <returns>An enumerable list of <see cref="IDataType" /> objects</returns>
+    [Obsolete("Please use GetAllAsync. Will be removed in V15.")]
     IEnumerable<IDataType> GetAll(params int[] ids);
 
     /// <summary>