diff --git a/src/Umbraco.Web/Trees/ContentTreeController.cs b/src/Umbraco.Web/Trees/ContentTreeController.cs
index b083c85bab..4e97292147 100644
--- a/src/Umbraco.Web/Trees/ContentTreeController.cs
+++ b/src/Umbraco.Web/Trees/ContentTreeController.cs
@@ -1,196 +1,195 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Net;
-using System.Net.Http.Formatting;
-using System.Web.Http;
-using Umbraco.Core;
-using Umbraco.Core.Models;
-using Umbraco.Core.Models.Entities;
-using Umbraco.Core.Services;
-using Umbraco.Web.Composing;
-using Umbraco.Web.Models.Trees;
-using Umbraco.Web.Mvc;
-using Umbraco.Web.WebApi.Filters;
-using Umbraco.Web._Legacy.Actions;
-using Umbraco.Web.Models.ContentEditing;
-using Umbraco.Web.Search;
-using Constants = Umbraco.Core.Constants;
-
-namespace Umbraco.Web.Trees
-{
- //We will not allow the tree to render unless the user has access to any of the sections that the tree gets rendered
- // this is not ideal but until we change permissions to be tree based (not section) there's not much else we can do here.
- [UmbracoApplicationAuthorize(
- Constants.Applications.Content,
- Constants.Applications.Media,
- Constants.Applications.Users,
- Constants.Applications.Settings,
- Constants.Applications.Developer,
- Constants.Applications.Members)]
- [Tree(Constants.Applications.Content, Constants.Trees.Content)]
- [PluginController("UmbracoTrees")]
- [CoreTree]
- [SearchableTree("searchResultFormatter", "configureContentResult")]
- public class ContentTreeController : ContentTreeControllerBase, ISearchableTree
- {
- private readonly UmbracoTreeSearcher _treeSearcher = new UmbracoTreeSearcher();
-
- protected override int RecycleBinId => Constants.System.RecycleBinContent;
-
- protected override bool RecycleBinSmells => Services.ContentService.RecycleBinSmells();
-
- private int[] _userStartNodes;
- protected override int[] UserStartNodes
- => _userStartNodes ?? (_userStartNodes = Security.CurrentUser.CalculateContentStartNodeIds(Services.EntityService));
-
- ///
- protected override TreeNode GetSingleTreeNode(IEntitySlim entity, string parentId, FormDataCollection queryStrings)
- {
- var langId = queryStrings?["culture"];
-
- var allowedUserOptions = GetAllowedUserMenuItemsForNode(entity);
- if (CanUserAccessNode(entity, allowedUserOptions, langId))
- {
- //Special check to see if it ia a container, if so then we'll hide children.
- var isContainer = entity.IsContainer; // && (queryStrings.Get("isDialog") != "true");
-
- var node = CreateTreeNode(
- entity,
- Constants.ObjectTypes.Document,
- parentId,
- queryStrings,
- entity.HasChildren && !isContainer);
-
- // entity is either a container, or a document
- if (isContainer)
- {
- node.AdditionalData.Add("isContainer", true);
- node.SetContainerStyle();
- }
- else
- {
- var documentEntity = (IDocumentEntitySlim) entity;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Net;
+using System.Net.Http.Formatting;
+using System.Web.Http;
+using Umbraco.Core;
+using Umbraco.Core.Models;
+using Umbraco.Core.Models.Entities;
+using Umbraco.Core.Services;
+using Umbraco.Web.Composing;
+using Umbraco.Web.Models.Trees;
+using Umbraco.Web.Mvc;
+using Umbraco.Web.WebApi.Filters;
+using Umbraco.Web._Legacy.Actions;
+using Umbraco.Web.Models.ContentEditing;
+using Umbraco.Web.Search;
+using Constants = Umbraco.Core.Constants;
+
+namespace Umbraco.Web.Trees
+{
+ //We will not allow the tree to render unless the user has access to any of the sections that the tree gets rendered
+ // this is not ideal but until we change permissions to be tree based (not section) there's not much else we can do here.
+ [UmbracoApplicationAuthorize(
+ Constants.Applications.Content,
+ Constants.Applications.Media,
+ Constants.Applications.Users,
+ Constants.Applications.Settings,
+ Constants.Applications.Developer,
+ Constants.Applications.Members)]
+ [Tree(Constants.Applications.Content, Constants.Trees.Content)]
+ [PluginController("UmbracoTrees")]
+ [CoreTree]
+ [SearchableTree("searchResultFormatter", "configureContentResult")]
+ public class ContentTreeController : ContentTreeControllerBase, ISearchableTree
+ {
+ private readonly UmbracoTreeSearcher _treeSearcher = new UmbracoTreeSearcher();
+
+ protected override int RecycleBinId => Constants.System.RecycleBinContent;
+
+ protected override bool RecycleBinSmells => Services.ContentService.RecycleBinSmells();
+
+ private int[] _userStartNodes;
+ protected override int[] UserStartNodes
+ => _userStartNodes ?? (_userStartNodes = Security.CurrentUser.CalculateContentStartNodeIds(Services.EntityService));
+
+ ///
+ protected override TreeNode GetSingleTreeNode(IEntitySlim entity, string parentId, FormDataCollection queryStrings)
+ {
+ var langId = queryStrings?["culture"];
+
+ var allowedUserOptions = GetAllowedUserMenuItemsForNode(entity);
+ if (CanUserAccessNode(entity, allowedUserOptions, langId))
+ {
+ //Special check to see if it ia a container, if so then we'll hide children.
+ var isContainer = entity.IsContainer; // && (queryStrings.Get("isDialog") != "true");
+
+ var node = CreateTreeNode(
+ entity,
+ Constants.ObjectTypes.Document,
+ parentId,
+ queryStrings,
+ entity.HasChildren && !isContainer);
+
+ // entity is either a container, or a document
+ if (isContainer)
+ {
+ node.AdditionalData.Add("isContainer", true);
+ node.SetContainerStyle();
+ }
+ else
+ {
+ var documentEntity = (IDocumentEntitySlim) entity;
//fixme we need these statuses per variant but to do that we need to fix the issues listed in IDocumentEntitySlim
if (!documentEntity.Published)
- node.SetNotPublishedStyle();
- //if (documentEntity.Edited)
- // node.SetHasUnpublishedVersionStyle();
+ node.SetNotPublishedStyle();
+ //if (documentEntity.Edited)
+ // node.SetHasUnpublishedVersionStyle();
- node.AdditionalData.Add("contentType", documentEntity.ContentTypeAlias);
- }
-
- if (Services.PublicAccessService.IsProtected(entity.Path))
- node.SetProtectedStyle();
-
- return node;
- }
-
- return null;
- }
-
- protected override MenuItemCollection PerformGetMenuForNode(string id, FormDataCollection queryStrings)
- {
- if (id == Constants.System.Root.ToInvariantString())
- {
- var menu = new MenuItemCollection();
-
- // if the user's start node is not the root then the only menu item to display is refresh
- if (UserStartNodes.Contains(Constants.System.Root) == false)
- {
- menu.Items.Add(
- Services.TextService.Localize(string.Concat("actions/", ActionRefresh.Instance.Alias)),
- true);
- return menu;
- }
-
- //set the default to create
- menu.DefaultMenuAlias = ActionNew.Instance.Alias;
-
- // we need to get the default permissions as you can't set permissions on the very root node
- var permission = Services.UserService.GetPermissions(Security.CurrentUser, Constants.System.Root).First();
- var nodeActions = global::Umbraco.Web._Legacy.Actions.Action.FromEntityPermission(permission)
- .Select(x => new MenuItem(x));
-
- //these two are the standard items
- menu.Items.Add(Services.TextService.Localize("actions", ActionNew.Instance.Alias));
- menu.Items.Add(Services.TextService.Localize("actions", ActionSort.Instance.Alias), true).ConvertLegacyMenuItem(null, "content", "content");
-
- //filter the standard items
- FilterUserAllowedMenuItems(menu, nodeActions);
-
- if (menu.Items.Any())
- {
- menu.Items.Last().SeperatorBefore = true;
- }
-
- // add default actions for *all* users
- menu.Items.Add(Services.TextService.Localize("actions", ActionRePublish.Instance.Alias)).ConvertLegacyMenuItem(null, "content", "content");
- menu.Items.Add(Services.TextService.Localize("actions", ActionRefresh.Instance.Alias), true);
-
- return menu;
- }
-
-
- //return a normal node menu:
- int iid;
- if (int.TryParse(id, out iid) == false)
- {
- throw new HttpResponseException(HttpStatusCode.NotFound);
- }
- var item = Services.EntityService.Get(iid, UmbracoObjectTypes.Document);
- if (item == null)
- {
- throw new HttpResponseException(HttpStatusCode.NotFound);
- }
-
- //if the user has no path access for this node, all they can do is refresh
- if (Security.CurrentUser.HasPathAccess(item, Services.EntityService, RecycleBinId) == false)
- {
- var menu = new MenuItemCollection();
- menu.Items.Add(
- Services.TextService.Localize(string.Concat("actions/", ActionRefresh.Instance.Alias)),
- true);
- return menu;
- }
-
- var nodeMenu = GetAllNodeMenuItems(item);
- var allowedMenuItems = GetAllowedUserMenuItemsForNode(item);
-
- FilterUserAllowedMenuItems(nodeMenu, allowedMenuItems);
-
- //if the media item is in the recycle bin, don't have a default menu, just show the regular menu
- if (item.Path.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries).Contains(RecycleBinId.ToInvariantString()))
- {
- nodeMenu.DefaultMenuAlias = null;
- nodeMenu.Items.Insert(2, new MenuItem(ActionRestore.Instance, Services.TextService.Localize("actions", ActionRestore.Instance.Alias)));
- }
- else
- {
- //set the default to create
- nodeMenu.DefaultMenuAlias = ActionNew.Instance.Alias;
- }
-
-
- return nodeMenu;
- }
-
- protected override UmbracoObjectTypes UmbracoObjectType
- {
- get { return UmbracoObjectTypes.Document; }
- }
-
- ///
- /// Returns true or false if the current user has access to the node based on the user's allowed start node (path) access
- ///
- ///
- ///
- ///
- protected override bool HasPathAccess(string id, FormDataCollection queryStrings)
- {
- var entity = GetEntityFromId(id);
- return HasPathAccess(entity, queryStrings);
+ node.AdditionalData.Add("contentType", documentEntity.ContentTypeAlias);
+ }
+
+ if (Services.PublicAccessService.IsProtected(entity.Path))
+ node.SetProtectedStyle();
+
+ return node;
+ }
+
+ return null;
+ }
+
+ protected override MenuItemCollection PerformGetMenuForNode(string id, FormDataCollection queryStrings)
+ {
+ if (id == Constants.System.Root.ToInvariantString())
+ {
+ var menu = new MenuItemCollection();
+
+ // if the user's start node is not the root then the only menu item to display is refresh
+ if (UserStartNodes.Contains(Constants.System.Root) == false)
+ {
+ menu.Items.Add(
+ Services.TextService.Localize(string.Concat("actions/", ActionRefresh.Instance.Alias)),
+ true);
+ return menu;
+ }
+
+ //set the default to create
+ menu.DefaultMenuAlias = ActionNew.Instance.Alias;
+
+ // we need to get the default permissions as you can't set permissions on the very root node
+ var permission = Services.UserService.GetPermissions(Security.CurrentUser, Constants.System.Root).First();
+ var nodeActions = global::Umbraco.Web._Legacy.Actions.Action.FromEntityPermission(permission)
+ .Select(x => new MenuItem(x));
+
+ //these two are the standard items
+ menu.Items.Add(Services.TextService.Localize("actions", ActionNew.Instance.Alias));
+ menu.Items.Add(Services.TextService.Localize("actions", ActionSort.Instance.Alias), true).ConvertLegacyMenuItem(null, "content", "content");
+
+ //filter the standard items
+ FilterUserAllowedMenuItems(menu, nodeActions);
+
+ if (menu.Items.Any())
+ {
+ menu.Items.Last().SeperatorBefore = true;
+ }
+
+ // add default actions for *all* users
+ menu.Items.Add(Services.TextService.Localize("actions", ActionRefresh.Instance.Alias), true);
+
+ return menu;
+ }
+
+
+ //return a normal node menu:
+ int iid;
+ if (int.TryParse(id, out iid) == false)
+ {
+ throw new HttpResponseException(HttpStatusCode.NotFound);
+ }
+ var item = Services.EntityService.Get(iid, UmbracoObjectTypes.Document);
+ if (item == null)
+ {
+ throw new HttpResponseException(HttpStatusCode.NotFound);
+ }
+
+ //if the user has no path access for this node, all they can do is refresh
+ if (Security.CurrentUser.HasPathAccess(item, Services.EntityService, RecycleBinId) == false)
+ {
+ var menu = new MenuItemCollection();
+ menu.Items.Add(
+ Services.TextService.Localize(string.Concat("actions/", ActionRefresh.Instance.Alias)),
+ true);
+ return menu;
+ }
+
+ var nodeMenu = GetAllNodeMenuItems(item);
+ var allowedMenuItems = GetAllowedUserMenuItemsForNode(item);
+
+ FilterUserAllowedMenuItems(nodeMenu, allowedMenuItems);
+
+ //if the media item is in the recycle bin, don't have a default menu, just show the regular menu
+ if (item.Path.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries).Contains(RecycleBinId.ToInvariantString()))
+ {
+ nodeMenu.DefaultMenuAlias = null;
+ nodeMenu.Items.Insert(2, new MenuItem(ActionRestore.Instance, Services.TextService.Localize("actions", ActionRestore.Instance.Alias)));
+ }
+ else
+ {
+ //set the default to create
+ nodeMenu.DefaultMenuAlias = ActionNew.Instance.Alias;
+ }
+
+
+ return nodeMenu;
+ }
+
+ protected override UmbracoObjectTypes UmbracoObjectType
+ {
+ get { return UmbracoObjectTypes.Document; }
+ }
+
+ ///
+ /// Returns true or false if the current user has access to the node based on the user's allowed start node (path) access
+ ///
+ ///
+ ///
+ ///
+ protected override bool HasPathAccess(string id, FormDataCollection queryStrings)
+ {
+ var entity = GetEntityFromId(id);
+ return HasPathAccess(entity, queryStrings);
}
protected override IEnumerable GetChildEntities(string id, FormDataCollection queryStrings)
@@ -198,64 +197,64 @@ namespace Umbraco.Web.Trees
var result = base.GetChildEntities(id, queryStrings);
var culture = queryStrings["culture"].TryConvertTo();
- //if this is null we'll set it to the default.
- var cultureVal = (culture.Success ? culture.Result : null) ?? Services.LocalizationService.GetDefaultLanguageIsoCode();
-
- // set names according to variations
+ //if this is null we'll set it to the default.
+ var cultureVal = (culture.Success ? culture.Result : null) ?? Services.LocalizationService.GetDefaultLanguageIsoCode();
+
+ // set names according to variations
foreach (var entity in result)
EnsureName(entity, cultureVal);
return result;
- }
-
- ///
- /// Returns a collection of all menu items that can be on a content node
- ///
- ///
- ///
- protected MenuItemCollection GetAllNodeMenuItems(IUmbracoEntity item)
- {
- var menu = new MenuItemCollection();
- AddActionNode(item, menu);
- AddActionNode(item, menu);
-
- AddActionNode(item, menu);
-
- //need to ensure some of these are converted to the legacy system - until we upgrade them all to be angularized.
- AddActionNode(item, menu, true);
- AddActionNode(item, menu);
- AddActionNode(item, menu, convert: true);
-
- AddActionNode(item, menu, true, true);
-
- AddActionNode(item, menu, convert: true);
- AddActionNode(item, menu, convert: true);
- AddActionNode(item, menu, convert: true);
- AddActionNode(item, menu, convert: true);
- AddActionNode(item, menu, convert: true);
- AddActionNode(item, menu, true, true);
-
- AddActionNode(item, menu, true, true);
- AddActionNode(item, menu, convert: true);
-
- AddActionNode(item, menu, true);
-
- return menu;
- }
+ }
- ///
- /// set name according to variations
- ///
- ///
- ///
- private void EnsureName(IEntitySlim entity, string culture)
- {
- if (culture == null)
- {
- if (string.IsNullOrWhiteSpace(entity.Name))
- entity.Name = "[[" + entity.Id + "]]";
- return;
- }
+ ///
+ /// Returns a collection of all menu items that can be on a content node
+ ///
+ ///
+ ///
+ protected MenuItemCollection GetAllNodeMenuItems(IUmbracoEntity item)
+ {
+ var menu = new MenuItemCollection();
+ AddActionNode(item, menu);
+ AddActionNode(item, menu);
+
+ AddActionNode(item, menu);
+
+ //need to ensure some of these are converted to the legacy system - until we upgrade them all to be angularized.
+ AddActionNode(item, menu, true);
+ AddActionNode(item, menu);
+ AddActionNode(item, menu, convert: true);
+
+ AddActionNode(item, menu, true, true);
+
+ AddActionNode(item, menu, convert: true);
+ AddActionNode(item, menu, convert: true);
+ AddActionNode(item, menu, convert: true);
+ AddActionNode(item, menu, convert: true);
+ AddActionNode(item, menu, convert: true);
+ AddActionNode(item, menu, true, true);
+
+ AddActionNode(item, menu, true, true);
+ AddActionNode(item, menu, convert: true);
+
+ AddActionNode(item, menu, true);
+
+ return menu;
+ }
+
+ ///
+ /// set name according to variations
+ ///
+ ///
+ ///
+ private void EnsureName(IEntitySlim entity, string culture)
+ {
+ if (culture == null)
+ {
+ if (string.IsNullOrWhiteSpace(entity.Name))
+ entity.Name = "[[" + entity.Id + "]]";
+ return;
+ }
if (!(entity is IDocumentEntitySlim docEntity))
throw new InvalidOperationException($"Cannot render a tree node for a culture when the entity isn't {typeof(IDocumentEntitySlim)}, instead it is {entity.GetType()}");
@@ -272,27 +271,27 @@ namespace Umbraco.Web.Trees
}
if (string.IsNullOrWhiteSpace(entity.Name))
- entity.Name = "[[" + entity.Id + "]]";
+ entity.Name = "[[" + entity.Id + "]]";
}
-
- private void AddActionNode(IUmbracoEntity item, MenuItemCollection menu, bool hasSeparator = false, bool convert = false)
- where TAction : IAction
- {
- var menuItem = menu.Items.Add(Services.TextService.Localize("actions", Current.Actions.GetAction().Alias), hasSeparator);
- if (convert) menuItem.ConvertLegacyMenuItem(item, "content", "content");
- }
-
- private void AddActionNode(IUmbracoEntity item, MenuItemCollection menu, bool hasSeparator = false, bool convert = false)
- where TItem : MenuItem, new()
- where TAction : IAction
- {
- var menuItem = menu.Items.Add(Services.TextService.Localize("actions", Current.Actions.GetAction().Alias), hasSeparator);
- if (convert) menuItem.ConvertLegacyMenuItem(item, "content", "content");
- }
-
- public IEnumerable Search(string query, int pageSize, long pageIndex, out long totalFound, string searchFrom = null)
- {
- return _treeSearcher.ExamineSearch(Umbraco, query, UmbracoEntityTypes.Document, pageSize, pageIndex, out totalFound, searchFrom);
- }
- }
-}
+
+ private void AddActionNode(IUmbracoEntity item, MenuItemCollection menu, bool hasSeparator = false, bool convert = false)
+ where TAction : IAction
+ {
+ var menuItem = menu.Items.Add(Services.TextService.Localize("actions", Current.Actions.GetAction().Alias), hasSeparator);
+ if (convert) menuItem.ConvertLegacyMenuItem(item, "content", "content");
+ }
+
+ private void AddActionNode(IUmbracoEntity item, MenuItemCollection menu, bool hasSeparator = false, bool convert = false)
+ where TItem : MenuItem, new()
+ where TAction : IAction
+ {
+ var menuItem = menu.Items.Add(Services.TextService.Localize("actions", Current.Actions.GetAction().Alias), hasSeparator);
+ if (convert) menuItem.ConvertLegacyMenuItem(item, "content", "content");
+ }
+
+ public IEnumerable Search(string query, int pageSize, long pageIndex, out long totalFound, string searchFrom = null)
+ {
+ return _treeSearcher.ExamineSearch(Umbraco, query, UmbracoEntityTypes.Document, pageSize, pageIndex, out totalFound, searchFrom);
+ }
+ }
+}