yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Netcore: migrate more unittests (#8939)

Browse Source 
* Migrated unit tests

* Migrated CoreThings tests

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

* Migrated Property Editor unit tests

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

* Migrated CoreXml tests

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

* Moved more tests

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

* revert some IsSZArray test code

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

* Renamed bad named test

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

* removed unnecessary file mentions in csproj file

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
This commit is contained in:
Bjarke Berg
2020-09-22 15:59:37 +02:00
committed by GitHub
parent 0c908a7bbb
commit 0ea251945b
50 changed files with 1191 additions and 789 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/Umbraco.Tests.UnitTests/Umbraco.Core/ShortStringHelper/StringValidationTests.cs Normal file
View File

@@ -0,0 +1,42 @@
using System.ComponentModel.DataAnnotations;
using NUnit.Framework;
using Umbraco.Tests.TestHelpers;
using Umbraco.Tests.Testing;
namespace Umbraco.Tests.Strings
{
[TestFixture]
public class StringValidationTests
{
[TestCase("someone@somewhere.com", ExpectedResult = true)]
[TestCase("someone@somewhere.co.uk", ExpectedResult = true)]
[TestCase("someone+tag@somewhere.net", ExpectedResult = true)]
[TestCase("futureTLD@somewhere.fooo", ExpectedResult = true)]
[TestCase("abc@xyz.financial", ExpectedResult = true)]
[TestCase("admin+gmail-syntax@c.pizza", ExpectedResult = true)]
[TestCase("admin@c.pizza", ExpectedResult = true)]
[TestCase("fdsa", ExpectedResult = false)]
[TestCase("fdsa@", ExpectedResult = false)]
// IsValid can be either a powerful regex OR a dummy test,
// and by default it depends on System.ComponentModel.DataAnnotations.AppSettings.DisableRegEx
// which ends up using BinaryCompatibility.Current.TargetsAtLeastFramework472 so for some reason
// in 472 we are not using the regex anymore
//
// it can be forced, though with an app settings
// dataAnnotations:dataTypeAttribute:disableRegEx = false
//
// since Umbraco is now 4.7.2+, the setting is required for the following tests to pass
//[TestCase("fdsa@fdsa", ExpectedResult = false)]
//[TestCase("fdsa@fdsa.", ExpectedResult = false)]
public bool Validate_Email_Address(string input)
{
var foo = new EmailAddressAttribute();
return foo.IsValid(input);
}
}
}