From fbbc89b477effbc6487d775e170c6ebc7578b736 Mon Sep 17 00:00:00 2001 From: Poornima Nayar Date: Tue, 11 Sep 2018 16:29:21 +0100 Subject: [PATCH 1/3] Removed the anchor tag around notification --- .../src/views/components/notifications/umb-notifications.html | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html b/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html index 9962e2dd84..6c74014c7e 100644 --- a/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html +++ b/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html @@ -11,10 +11,8 @@
- {{notification.headline}} -
From a0ae39a147005d37650d8e9299b223c0c0d68a49 Mon Sep 17 00:00:00 2001 From: Poornima Nayar Date: Thu, 13 Sep 2018 10:27:48 +0100 Subject: [PATCH 2/3] Reworked the notifications banner to use ng-switch to show the anchor tag when there is a notification url. --- .../components/notifications/umb-notifications.html | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html b/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html index 6c74014c7e..7cd0d1a510 100644 --- a/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html +++ b/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html @@ -9,10 +9,15 @@
- -
+
+ {{notification.headline}} + +
+ {{notification.headline}} + +
From 7f4280c67f4fcce342b6ea9e9e41074c5cd6ffb4 Mon Sep 17 00:00:00 2001 From: Poornima Nayar Date: Fri, 14 Sep 2018 10:06:32 +0100 Subject: [PATCH 3/3] added checks for whitespace --- .../src/views/components/notifications/umb-notifications.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html b/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html index 7cd0d1a510..3b78562c1a 100644 --- a/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html +++ b/src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html @@ -10,7 +10,7 @@
- + {{notification.headline}}