yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve draggableSelector

Browse Source
This commit is contained in:
Niels Lyngsø
2024-02-24 21:51:24 +01:00
parent 709c1dcb5a
commit 126166d77a
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts
View File

@@ -333,9 +333,12 @@ export class UmbSorterController<T, ElementType extends HTMLElement = HTMLElemen
if (!this.#config.disabledItemSelector || !element.matches(this.#config.disabledItemSelector)) {
// Idea: to make sure on does not get initialized twice: if ((element as HTMLElement).draggable === true) return;
(element as HTMLElement).draggable = true;
element.addEventListener('dragstart', this.#handleDragStart);
element.addEventListener('dragend', this.#handleDragEnd);
const draggableElement = this.#config.draggableSelector
? (element.querySelector(this.#config.draggableSelector) as HTMLElement | undefined) ?? element
: element;
(draggableElement as HTMLElement).draggable = true;
draggableElement.addEventListener('dragstart', this.#handleDragStart);
draggableElement.addEventListener('dragend', this.#handleDragEnd);
}
// If we have a currentItem and the element matches, we should set the currentElement to this element.
@@ -354,10 +357,12 @@ export class UmbSorterController<T, ElementType extends HTMLElement = HTMLElemen
destroyIgnorerElements(element, this.#config.ignorerSelector);
}
element.removeEventListener('dragstart', this.#handleDragStart);
const draggableElement = this.#config.draggableSelector
? (element.querySelector(this.#config.draggableSelector) as HTMLElement | undefined) ?? element
: element;
draggableElement.removeEventListener('dragstart', this.#handleDragStart);
// We are not ready to remove the dragend or drop, as this is might be the active one just moving container:
//element.removeEventListener('dragend', this.#handleDragEnd);
//element.addEventListener('drop', this.#handleDrop);
//draggableElement.removeEventListener('dragend', this.#handleDragEnd);
}
#setupPlaceholderStyle() {