From 12f7492d80ce96312e7243b963ba3a8203c09b2a Mon Sep 17 00:00:00 2001 From: Stephan Date: Wed, 20 Feb 2019 16:27:52 +0100 Subject: [PATCH] Reorg code --- ..._Accessors.cs => CompositionExtensions.cs} | 40 ---------------- .../CompositionExtensions_Essentials.cs | 33 ------------- .../CompositionExtensions_FileSystems.cs | 47 +++++++++++++++++++ .../CompositionExtensions_Uniques.cs | 35 ++++++++++++++ src/Umbraco.Core/Umbraco.Core.csproj | 4 +- 5 files changed, 85 insertions(+), 74 deletions(-) rename src/Umbraco.Core/{CompositionExtensions_Accessors.cs => CompositionExtensions.cs} (87%) create mode 100644 src/Umbraco.Core/CompositionExtensions_FileSystems.cs create mode 100644 src/Umbraco.Core/CompositionExtensions_Uniques.cs diff --git a/src/Umbraco.Core/CompositionExtensions_Accessors.cs b/src/Umbraco.Core/CompositionExtensions.cs similarity index 87% rename from src/Umbraco.Core/CompositionExtensions_Accessors.cs rename to src/Umbraco.Core/CompositionExtensions.cs index f19437809e..e1c7ad4467 100644 --- a/src/Umbraco.Core/CompositionExtensions_Accessors.cs +++ b/src/Umbraco.Core/CompositionExtensions.cs @@ -18,46 +18,6 @@ namespace Umbraco.Core /// public static partial class CompositionExtensions { - #region FileSystems - - /// - /// Registers a filesystem. - /// - /// The type of the filesystem. - /// The implementing type. - /// The composition. - /// The register. - public static void RegisterFileSystem(this Composition composition) - where TImplementing : FileSystemWrapper, TFileSystem - where TFileSystem : class - { - composition.RegisterUnique(factory => - { - var fileSystems = factory.GetInstance(); - var supporting = factory.GetInstance(); - return fileSystems.GetFileSystem(supporting.For()); - }); - } - - /// - /// Registers a filesystem. - /// - /// The type of the filesystem. - /// The composition. - /// The register. - public static void RegisterFileSystem(this Composition composition) - where TFileSystem : FileSystemWrapper - { - composition.RegisterUnique(factory => - { - var fileSystems = factory.GetInstance(); - var supporting = factory.GetInstance(); - return fileSystems.GetFileSystem(supporting.For()); - }); - } - - #endregion - #region Collection Builders /// diff --git a/src/Umbraco.Core/CompositionExtensions_Essentials.cs b/src/Umbraco.Core/CompositionExtensions_Essentials.cs index 46575c1428..b85479716c 100644 --- a/src/Umbraco.Core/CompositionExtensions_Essentials.cs +++ b/src/Umbraco.Core/CompositionExtensions_Essentials.cs @@ -10,8 +10,6 @@ namespace Umbraco.Core /// public static partial class CompositionExtensions { - #region Essentials - /// /// Registers essential services. /// @@ -33,36 +31,5 @@ namespace Umbraco.Core composition.RegisterUnique(typeLoader); composition.RegisterUnique(state); } - - #endregion - - #region Unique - - /// - /// Registers a unique service as its own implementation. - /// - public static void RegisterUnique(this Composition composition) - => composition.RegisterUnique(typeof(TService), typeof(TService)); - - /// - /// Registers a unique service with an implementation type. - /// - public static void RegisterUnique(this Composition composition) - => composition.RegisterUnique(typeof(TService), typeof(TImplementing)); - - /// - /// Registers a unique service with an implementation type, for a target. - /// - public static void RegisterUniqueFor(this Composition composition) - where TService : class - => composition.RegisterUniqueFor(typeof(TImplementing)); - - /// - /// Registers a unique service with an implementing instance. - /// - public static void RegisterUnique(this Composition composition, TService instance) - => composition.RegisterUnique(typeof(TService), instance); - - #endregion } } diff --git a/src/Umbraco.Core/CompositionExtensions_FileSystems.cs b/src/Umbraco.Core/CompositionExtensions_FileSystems.cs new file mode 100644 index 0000000000..f6c65e1e1f --- /dev/null +++ b/src/Umbraco.Core/CompositionExtensions_FileSystems.cs @@ -0,0 +1,47 @@ +using Umbraco.Core.Composing; +using Umbraco.Core.IO; + +namespace Umbraco.Core +{ + /// + /// Provides extension methods to the class. + /// + public static partial class CompositionExtensions + { + /// + /// Registers a filesystem. + /// + /// The type of the filesystem. + /// The implementing type. + /// The composition. + /// The register. + public static void RegisterFileSystem(this Composition composition) + where TImplementing : FileSystemWrapper, TFileSystem + where TFileSystem : class + { + composition.RegisterUnique(factory => + { + var fileSystems = factory.GetInstance(); + var supporting = factory.GetInstance(); + return fileSystems.GetFileSystem(supporting.For()); + }); + } + + /// + /// Registers a filesystem. + /// + /// The type of the filesystem. + /// The composition. + /// The register. + public static void RegisterFileSystem(this Composition composition) + where TFileSystem : FileSystemWrapper + { + composition.RegisterUnique(factory => + { + var fileSystems = factory.GetInstance(); + var supporting = factory.GetInstance(); + return fileSystems.GetFileSystem(supporting.For()); + }); + } + } +} \ No newline at end of file diff --git a/src/Umbraco.Core/CompositionExtensions_Uniques.cs b/src/Umbraco.Core/CompositionExtensions_Uniques.cs new file mode 100644 index 0000000000..52f1ce7ecd --- /dev/null +++ b/src/Umbraco.Core/CompositionExtensions_Uniques.cs @@ -0,0 +1,35 @@ +using Umbraco.Core.Composing; + +namespace Umbraco.Core +{ + /// + /// Provides extension methods to the class. + /// + public static partial class CompositionExtensions + { + /// + /// Registers a unique service as its own implementation. + /// + public static void RegisterUnique(this Composition composition) + => composition.RegisterUnique(typeof(TService), typeof(TService)); + + /// + /// Registers a unique service with an implementation type. + /// + public static void RegisterUnique(this Composition composition) + => composition.RegisterUnique(typeof(TService), typeof(TImplementing)); + + /// + /// Registers a unique service with an implementation type, for a target. + /// + public static void RegisterUniqueFor(this Composition composition) + where TService : class + => composition.RegisterUniqueFor(typeof(TImplementing)); + + /// + /// Registers a unique service with an implementing instance. + /// + public static void RegisterUnique(this Composition composition, TService instance) + => composition.RegisterUnique(typeof(TService), instance); + } +} \ No newline at end of file diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj index c3fe7be10a..c7e7db18a7 100755 --- a/src/Umbraco.Core/Umbraco.Core.csproj +++ b/src/Umbraco.Core/Umbraco.Core.csproj @@ -161,7 +161,7 @@ - + @@ -187,6 +187,8 @@ + +