From 13bb25a8b82352396fe4ea1d848747fecdc9090e Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Wed, 13 Aug 2025 15:02:52 +0200 Subject: [PATCH] Close dropdown when "Reload"-Entity Action has executed (#19808) Bind 'action-executed' event handler to class instance Updated the event listener for 'action-executed' to bind the handler to the class instance, ensuring correct 'this' context when the event is triggered. --- .../entity-actions-dropdown.element.ts | 2 +- tests/Umbraco.Tests.AcceptanceTest/console-errors.json | 3 +++ tests/Umbraco.Tests.AcceptanceTest/package-lock.json | 9 +++++---- tests/Umbraco.Tests.AcceptanceTest/package.json | 2 +- 4 files changed, 10 insertions(+), 6 deletions(-) create mode 100644 tests/Umbraco.Tests.AcceptanceTest/console-errors.json diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/global-components/entity-actions-dropdown/entity-actions-dropdown.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/global-components/entity-actions-dropdown/entity-actions-dropdown.element.ts index df3074634e..7c5d4da98c 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/global-components/entity-actions-dropdown/entity-actions-dropdown.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/global-components/entity-actions-dropdown/entity-actions-dropdown.element.ts @@ -56,7 +56,7 @@ export class UmbEntityActionsDropdownElement extends UmbLitElement { // Programmatically create the elements so they are cached if the dropdown is opened again this.#scrollContainerElement = new UUIScrollContainerElement(); this.#entityActionListElement = new UmbEntityActionListElement(); - this.#entityActionListElement.addEventListener('action-executed', this.#onActionExecuted); + this.#entityActionListElement.addEventListener('action-executed', this.#onActionExecuted.bind(this)); this.#entityActionListElement.entityType = this.#entityType; this.#entityActionListElement.unique = this.#unique; this.#entityActionListElement.setAttribute('label', this.label ?? ''); diff --git a/tests/Umbraco.Tests.AcceptanceTest/console-errors.json b/tests/Umbraco.Tests.AcceptanceTest/console-errors.json new file mode 100644 index 0000000000..51d828f4dc --- /dev/null +++ b/tests/Umbraco.Tests.AcceptanceTest/console-errors.json @@ -0,0 +1,3 @@ +{ + "consoleErrors": [] +} \ No newline at end of file diff --git a/tests/Umbraco.Tests.AcceptanceTest/package-lock.json b/tests/Umbraco.Tests.AcceptanceTest/package-lock.json index 32ed4bb4d7..412b6c2806 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/package-lock.json +++ b/tests/Umbraco.Tests.AcceptanceTest/package-lock.json @@ -8,7 +8,7 @@ "hasInstallScript": true, "dependencies": { "@umbraco/json-models-builders": "^2.0.37", - "@umbraco/playwright-testhelpers": "^16.0.34", + "@umbraco/playwright-testhelpers": "^16.0.36", "camelize": "^1.0.0", "dotenv": "^16.3.1", "node-fetch": "^2.6.7" @@ -67,9 +67,10 @@ } }, "node_modules/@umbraco/playwright-testhelpers": { - "version": "16.0.34", - "resolved": "https://registry.npmjs.org/@umbraco/playwright-testhelpers/-/playwright-testhelpers-16.0.34.tgz", - "integrity": "sha512-hCOqSUrTVZPNxD3DP+olYz/QFc8HwyZ1QZR6gTv87nIkAlvEjk44+7KblPartfBXQDd93uvasptr7dO3XCapZA==", + "version": "16.0.36", + "resolved": "https://registry.npmjs.org/@umbraco/playwright-testhelpers/-/playwright-testhelpers-16.0.36.tgz", + "integrity": "sha512-SjPrVgWI18ErfyCUEuIwt1V7HjCGXFLae0S8u3NO74QBbOO9z79+JM0/U4Xwqwq9KdV2XMiVPkzDm/5xThSvMg==", + "license": "MIT", "dependencies": { "@umbraco/json-models-builders": "2.0.37", "node-fetch": "^2.6.7" diff --git a/tests/Umbraco.Tests.AcceptanceTest/package.json b/tests/Umbraco.Tests.AcceptanceTest/package.json index 09fce13b54..6df0b2ca45 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/package.json +++ b/tests/Umbraco.Tests.AcceptanceTest/package.json @@ -22,7 +22,7 @@ }, "dependencies": { "@umbraco/json-models-builders": "^2.0.37", - "@umbraco/playwright-testhelpers": "^16.0.34", + "@umbraco/playwright-testhelpers": "^16.0.36", "camelize": "^1.0.0", "dotenv": "^16.3.1", "node-fetch": "^2.6.7"