From 153cfeefb7d230f7e0ac85721cd4e67a8bc3ca78 Mon Sep 17 00:00:00 2001
From: Shannon Deminick <sdeminick@gmail.com>
Date: Mon, 10 Dec 2012 03:49:53 +0500
Subject: [PATCH] Have obsoleted LogTypes that are not part of the audit trail

---
 src/umbraco.businesslogic/Log.cs              | 136 +--------------
 src/umbraco.businesslogic/LogTypes.cs         | 158 ++++++++++++++++++
 .../umbraco.businesslogic.csproj              |   1 +
 3 files changed, 160 insertions(+), 135 deletions(-)
 create mode 100644 src/umbraco.businesslogic/LogTypes.cs

diff --git a/src/umbraco.businesslogic/Log.cs b/src/umbraco.businesslogic/Log.cs
index 26dea86a32..4c24711385 100644
--- a/src/umbraco.businesslogic/Log.cs
+++ b/src/umbraco.businesslogic/Log.cs
@@ -337,141 +337,7 @@ namespace umbraco.BusinessLogic
         #endregion
     }
 
-    /// <summary>
-    /// The collection of available log types.
-    /// </summary>
-    public enum LogTypes
-    {
-        /// <summary>
-        /// Used when new nodes are added
-        /// </summary>
-        [AuditTrailLogItem]
-        New,
-        /// <summary>
-        /// Used when nodes are saved
-        /// </summary>
-        [AuditTrailLogItem]
-        Save,
-        /// <summary>
-        /// Used when nodes are opened
-        /// </summary>
-        [AuditTrailLogItem]
-        Open,
-        /// <summary>
-        /// Used when nodes are deleted
-        /// </summary>
-        [AuditTrailLogItem]
-        Delete,
-        /// <summary>
-        /// Used when nodes are published
-        /// </summary>
-        [AuditTrailLogItem]
-        Publish,
-        /// <summary>
-        /// Used when nodes are send to publishing
-        /// </summary>
-        [AuditTrailLogItem]
-        SendToPublish,
-        /// <summary>
-        /// Used when nodes are unpublished
-        /// </summary>
-        [AuditTrailLogItem]
-        UnPublish,
-        /// <summary>
-        /// Used when nodes are moved
-        /// </summary>
-        [AuditTrailLogItem]
-        Move,
-        /// <summary>
-        /// Used when nodes are copied
-        /// </summary>
-        [AuditTrailLogItem]
-        Copy,
-        /// <summary>
-        /// Used when nodes are assígned a domain
-        /// </summary>
-        [AuditTrailLogItem]
-        AssignDomain,
-        /// <summary>
-        /// Used when public access are changed for a node
-        /// </summary>
-        [AuditTrailLogItem]
-        PublicAccess,
-        /// <summary>
-        /// Used when nodes are sorted
-        /// </summary>
-        [AuditTrailLogItem]
-        Sort,
-        /// <summary>
-        /// Used when a notification are send to a user
-        /// </summary>
-        [AuditTrailLogItem]
-        Notify,
-        /// <summary>
-        /// Used when a user logs into the umbraco back-end
-        /// </summary>
-        Login,
-        /// <summary>
-        /// Used when a user logs out of the umbraco back-end
-        /// </summary>
-        Logout,
-        /// <summary>
-        /// Used when a user login fails
-        /// </summary>
-        LoginFailure,
-        /// <summary>
-        /// General system notification
-        /// </summary>
-        [AuditTrailLogItem]
-        System,
-        /// <summary>
-        /// System debugging notification
-        /// </summary>
-        Debug,
-        /// <summary>
-        /// System error notification
-        /// </summary>
-        Error,
-        /// <summary>
-        /// Notfound error notification
-        /// </summary>
-        NotFound,
-        /// <summary>
-        /// Used when a node's content is rolled back to a previous version
-        /// </summary>
-        [AuditTrailLogItem]
-        RollBack,
-        /// <summary>
-        /// Used when a package is installed
-        /// </summary>
-        [AuditTrailLogItem]
-        PackagerInstall,
-        /// <summary>
-        /// Used when a package is uninstalled
-        /// </summary>
-        [AuditTrailLogItem]
-        PackagerUninstall,
-        /// <summary>
-        /// Used when a ping is send to/from the system
-        /// </summary>
-        Ping,
-        /// <summary>
-        /// Used when a node is send to translation
-        /// </summary>
-        [AuditTrailLogItem]
-        SendToTranslate,
-        /// <summary>
-        /// Notification from a Scheduled task.
-        /// </summary>
-        ScheduledTask,
-        /// <summary>
-        /// Use this log action for custom log messages that should be shown in the audit trail
-        /// </summary>
-        [AuditTrailLogItem]
-        Custom
-    }
-
-    public class LogItem
+	public class LogItem
     {
         public int UserId { get; set; }
         public int NodeId { get; set; }
diff --git a/src/umbraco.businesslogic/LogTypes.cs b/src/umbraco.businesslogic/LogTypes.cs
new file mode 100644
index 0000000000..21b168d001
--- /dev/null
+++ b/src/umbraco.businesslogic/LogTypes.cs
@@ -0,0 +1,158 @@
+using System;
+
+namespace umbraco.BusinessLogic
+{
+	/// <summary>
+	/// The collection of available log types.
+	/// </summary>
+	public enum LogTypes
+	{
+		/// <summary>
+		/// Used when new nodes are added
+		/// </summary>
+		[AuditTrailLogItem]
+		New,
+		/// <summary>
+		/// Used when nodes are saved
+		/// </summary>
+		[AuditTrailLogItem]
+		Save,
+		/// <summary>
+		/// Used when nodes are opened
+		/// </summary>
+		[AuditTrailLogItem]
+		Open,
+		/// <summary>
+		/// Used when nodes are deleted
+		/// </summary>
+		[AuditTrailLogItem]
+		Delete,
+		/// <summary>
+		/// Used when nodes are published
+		/// </summary>
+		[AuditTrailLogItem]
+		Publish,
+		/// <summary>
+		/// Used when nodes are send to publishing
+		/// </summary>
+		[AuditTrailLogItem]
+		SendToPublish,
+		/// <summary>
+		/// Used when nodes are unpublished
+		/// </summary>
+		[AuditTrailLogItem]
+		UnPublish,
+		/// <summary>
+		/// Used when nodes are moved
+		/// </summary>
+		[AuditTrailLogItem]
+		Move,
+		/// <summary>
+		/// Used when nodes are copied
+		/// </summary>
+		[AuditTrailLogItem]
+		Copy,
+		/// <summary>
+		/// Used when nodes are assígned a domain
+		/// </summary>
+		[AuditTrailLogItem]
+		AssignDomain,
+		/// <summary>
+		/// Used when public access are changed for a node
+		/// </summary>
+		[AuditTrailLogItem]
+		PublicAccess,
+		/// <summary>
+		/// Used when nodes are sorted
+		/// </summary>
+		[AuditTrailLogItem]
+		Sort,
+		/// <summary>
+		/// Used when a notification are send to a user
+		/// </summary>
+		[AuditTrailLogItem]
+		Notify,
+
+		/// <summary>
+		/// Used when a user logs into the umbraco back-end
+		/// </summary>
+		[Obsolete("Use LogHelper to write log messages")]
+		Login,
+
+		/// <summary>
+		/// Used when a user logs out of the umbraco back-end
+		/// </summary>
+		[Obsolete("Use LogHelper to write log messages")]
+		Logout,
+		
+		/// <summary>
+		/// Used when a user login fails
+		/// </summary>
+		[Obsolete("Use LogHelper to write error log messages")]
+		LoginFailure,
+		
+		/// <summary>
+		/// General system notification
+		/// </summary>
+		[AuditTrailLogItem]
+		System,
+
+
+		/// <summary>
+		/// System debugging notification
+		/// </summary>
+		[Obsolete("Use LogHelper to write debug log messages")]
+		Debug,
+
+		/// <summary>
+		/// System error notification
+		/// </summary>
+		[Obsolete("Use LogHelper to write error log messages")]
+		Error,
+
+		/// <summary>
+		/// Notfound error notification
+		/// </summary>
+		[Obsolete("Use LogHelper to write log messages")]
+		NotFound,
+
+		/// <summary>
+		/// Used when a node's content is rolled back to a previous version
+		/// </summary>
+		[AuditTrailLogItem]
+		RollBack,
+		/// <summary>
+		/// Used when a package is installed
+		/// </summary>
+		[AuditTrailLogItem]
+		PackagerInstall,
+		/// <summary>
+		/// Used when a package is uninstalled
+		/// </summary>
+		[AuditTrailLogItem]
+		PackagerUninstall,
+
+		/// <summary>
+		/// Used when a ping is send to/from the system
+		/// </summary>
+		[Obsolete("Use LogHelper to write log messages")]
+		Ping,
+		/// <summary>
+		/// Used when a node is send to translation
+		/// </summary>
+		[AuditTrailLogItem]
+		SendToTranslate,
+		
+		/// <summary>
+		/// Notification from a Scheduled task.
+		/// </summary>
+		[Obsolete("Use LogHelper to write log messages")]
+		ScheduledTask,
+
+		/// <summary>
+		/// Use this log action for custom log messages that should be shown in the audit trail
+		/// </summary>
+		[AuditTrailLogItem]
+		Custom
+	}
+}
\ No newline at end of file
diff --git a/src/umbraco.businesslogic/umbraco.businesslogic.csproj b/src/umbraco.businesslogic/umbraco.businesslogic.csproj
index ca64da53c1..9e8b7b478c 100644
--- a/src/umbraco.businesslogic/umbraco.businesslogic.csproj
+++ b/src/umbraco.businesslogic/umbraco.businesslogic.csproj
@@ -149,6 +149,7 @@
     <Compile Include="ApplicationTree.cs" />
     <Compile Include="ApplicationTreeRegistrar.cs" />
     <Compile Include="DefaultApps.cs" />
+    <Compile Include="LogTypes.cs" />
     <Compile Include="PluginManagerExtensions.cs" />
     <Compile Include="TreeAttribute.cs" />
     <Compile Include="Properties\AssemblyInfo.cs">