From 9911f0374579d04c951cacb75e8e649f3f062f1a Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Thu, 7 Nov 2013 20:09:06 +0100 Subject: [PATCH] Fixed potential DbReaderException - Use Fetch instead of Query because we create another DbReader inside the loop with DoesMacroHaveParameters(). --- src/Umbraco.Web/UI/Controls/InsertMacroSplitButton.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web/UI/Controls/InsertMacroSplitButton.cs b/src/Umbraco.Web/UI/Controls/InsertMacroSplitButton.cs index 50968413ae..4fa9146dbc 100644 --- a/src/Umbraco.Web/UI/Controls/InsertMacroSplitButton.cs +++ b/src/Umbraco.Web/UI/Controls/InsertMacroSplitButton.cs @@ -71,7 +71,7 @@ namespace Umbraco.Web.UI.Controls var divMacroItemContainer = new TagBuilder("div"); divMacroItemContainer.Attributes.Add("style", "width: 285px;display:none;"); divMacroItemContainer.Attributes.Add("class", "sbMenu"); - var macros = ApplicationContext.DatabaseContext.Database.Query("select id, macroAlias, macroName from cmsMacro order by macroName"); + var macros = ApplicationContext.DatabaseContext.Database.Fetch("select id, macroAlias, macroName from cmsMacro order by macroName"); foreach (var macro in macros) { var divMacro = new TagBuilder("div");