Fixing all the TODO, FIXME & HACK comments so they all follow the same layout.
This commit is contained in:
committed by
Sebastiaan Janssen
parent
d31e25281d
commit
193e24afd2
@@ -29,7 +29,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
|
||||
#region Constructor
|
||||
|
||||
// todo - figure this out
|
||||
// TODO: figure this out
|
||||
// after the current snapshot has been resync-ed
|
||||
// it's too late for UmbracoContext which has captured previewDefault and stuff into these ctor vars
|
||||
// but, no, UmbracoContext returns snapshot.Content which comes from elements SO a resync should create a new cache
|
||||
|
||||
@@ -38,7 +38,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
private volatile int _wlocked;
|
||||
private List<KeyValuePair<int, ContentNodeKit>> _wchanges;
|
||||
|
||||
// todo - collection trigger (ok for now)
|
||||
// TODO: collection trigger (ok for now)
|
||||
// see SnapDictionary notes
|
||||
private const long CollectMinGenDelta = 8;
|
||||
|
||||
@@ -104,7 +104,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
}
|
||||
|
||||
// gets a scope contextual representing a locked writer to the dictionary
|
||||
// todo GetScopedWriter? should the dict have a ref onto the scope provider?
|
||||
// TODO: GetScopedWriter? should the dict have a ref onto the scope provider?
|
||||
public IDisposable GetWriter(IScopeProvider scopeProvider)
|
||||
{
|
||||
return ScopeContextualBase.Get(scopeProvider, _instanceId, scoped => new ContentStoreWriter(this, scoped));
|
||||
|
||||
@@ -36,7 +36,7 @@ namespace Umbraco.Web.PublishedCache.NuCache.DataSource
|
||||
// write each variation
|
||||
foreach (var (culture, variation) in variations)
|
||||
{
|
||||
// todo - it's weird we're dealing with cultures here, and languageId in properties
|
||||
// TODO: it's weird we're dealing with cultures here, and languageId in properties
|
||||
|
||||
PrimitiveSerializer.String.WriteTo(culture, stream); // should never be null
|
||||
WriteObject(variation.Name, stream); // write an object in case it's null (though... should not happen)
|
||||
|
||||
@@ -15,7 +15,7 @@ using static Umbraco.Core.Persistence.NPocoSqlExtensions.Statics;
|
||||
|
||||
namespace Umbraco.Web.PublishedCache.NuCache.DataSource
|
||||
{
|
||||
// todo - use SqlTemplate for these queries else it's going to be horribly slow!
|
||||
// TODO: use SqlTemplate for these queries else it's going to be horribly slow!
|
||||
|
||||
// provides efficient database access for NuCache
|
||||
internal class DatabaseDataSource : IDataSource
|
||||
|
||||
@@ -12,14 +12,14 @@ namespace Umbraco.Web.PublishedCache.NuCache.DataSource
|
||||
public string Culture
|
||||
{
|
||||
get => _culture;
|
||||
set => _culture = value ?? throw new ArgumentNullException(nameof(value)); // todo or fallback to string.Empty? CANNOT be null
|
||||
set => _culture = value ?? throw new ArgumentNullException(nameof(value)); // TODO: or fallback to string.Empty? CANNOT be null
|
||||
}
|
||||
|
||||
[JsonProperty("seg")]
|
||||
public string Segment
|
||||
{
|
||||
get => _segment;
|
||||
set => _segment = value ?? throw new ArgumentNullException(nameof(value)); // todo or fallback to string.Empty? CANNOT be null
|
||||
set => _segment = value ?? throw new ArgumentNullException(nameof(value)); // TODO: or fallback to string.Empty? CANNOT be null
|
||||
}
|
||||
|
||||
[JsonProperty("val")]
|
||||
|
||||
@@ -201,7 +201,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
|
||||
private void InitializeRepositoryEvents()
|
||||
{
|
||||
//todo: The reason these events are in the repository is for legacy, the events should exist at the service
|
||||
// TODO: The reason these events are in the repository is for legacy, the events should exist at the service
|
||||
// level now since we can fire these events within the transaction... so move the events to service level
|
||||
|
||||
// plug repository event handlers
|
||||
@@ -584,7 +584,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
continue;
|
||||
}
|
||||
|
||||
// todo- should we do some RV check here? (later)
|
||||
// TODO: should we do some RV check here? (later)
|
||||
|
||||
var capture = payload;
|
||||
using (var scope = _scopeProvider.CreateScope())
|
||||
@@ -674,7 +674,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
continue;
|
||||
}
|
||||
|
||||
// todo- should we do some RV checks here? (later)
|
||||
// TODO: should we do some RV checks here? (later)
|
||||
|
||||
var capture = payload;
|
||||
using (var scope = _scopeProvider.CreateScope())
|
||||
@@ -773,7 +773,7 @@ namespace Umbraco.Web.PublishedCache.NuCache
|
||||
using (_contentStore.GetWriter(_scopeProvider))
|
||||
using (_mediaStore.GetWriter(_scopeProvider))
|
||||
{
|
||||
// todo - need to add a datatype lock
|
||||
// TODO: need to add a datatype lock
|
||||
// this is triggering datatypes reload in the factory, and right after we create some
|
||||
// content types by loading them ... there's a race condition here, which would require
|
||||
// some locking on datatypes
|
||||
|
||||
Reference in New Issue
Block a user