From 19dbe6002e1d79b1d6dd2970c439066c5ab8ffb9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Fri, 6 Jan 2023 20:16:45 +0100 Subject: [PATCH] comments --- .../backoffice/shared/components/property/property.element.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/property/property.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/property/property.element.ts index 45ba7d01ec..09e27c1e6f 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/property/property.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/property/property.element.ts @@ -156,7 +156,6 @@ export class UmbPropertyElement extends UmbLitElement { this._description = description; }); - // TODO: move event to context. maybe rename to property-editor-value-change. this.addEventListener('property-editor-value-change', this._onPropertyEditorChange as any as EventListener); @@ -206,8 +205,8 @@ export class UmbPropertyElement extends UmbLitElement { this.value = target.value; //TODO: Property-Context: Figure out the requirements for this. Cause currently the alias-prop(getter) is required, but its not obvious. + // Could it make more sense to parse this on as part of the event? alias?, value? - // TODO: Confusing with the little detail of the event name that changed here.. this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); e.stopPropagation(); };