Add generic section icon in section picker + clean up legacy section icon stuff

src/Umbraco.Web.UI.Client/src/common/directives/components/application/sectionicon.directive.js

@@ -1,30 +0,0 @@
-angular.module("umbraco.directives")
-.directive('sectionIcon', function ($compile, iconHelper) {
-    return {
-        restrict: 'E',
-        replace: true,
-
-        link: function (scope, element, attrs) {
-
-            var icon = attrs.icon;
-
-            if (iconHelper.isLegacyIcon(icon)) {
-                //its a known legacy icon, convert to a new one
-                element.html("<i class='" + iconHelper.convertFromLegacyIcon(icon) + "'></i>");
-            }
-            else if (iconHelper.isFileBasedIcon(icon)) {
-                var convert = iconHelper.convertFromLegacyImage(icon);
-                if(convert){
-                    element.html("<i class='icon-section " + convert + "'></i>");
-                }else{
-                    element.html("<img class='icon-section' src='images/tray/" + icon + "'>");
-                }
-                //it's a file, normally legacy so look in the icon tray images
-            }
-            else {
-                //it's normal
-                element.html("<i class='icon-section " + icon + "'></i>");
-            }
-        }
-    };
-});

src/Umbraco.Web.UI.Client/src/less/helveticons.less

@@ -1875,3 +1875,6 @@ i.small{
 .icon-alert-alt:before {
 	content: "\e25d";
 }
+.icon-section:before {
+    content: "\e24f";
+}

src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/sectionpicker/sectionpicker.controller.js

@@ -78,7 +78,7 @@
 
         function setSectionIcon(sections) {
             angular.forEach(sections, function(section) {
-                section.icon = "icon-section " + section.cssclass;
+                section.icon = "icon-section";
             });
         }
 

src/Umbraco.Web.UI.Client/src/views/users/group.controller.js

@@ -302,7 +302,7 @@
 
         function setSectionIcon(sections) {
             angular.forEach(sections, function (section) {
-                section.icon = "icon-section " + section.cssclass;
+                section.icon = "icon-section";
             });
         }