From 1c70d04ce29fd750055227cabac2bccd44cc1d0b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B8ren=20Kottal?= <snielsen43@gmail.com>
Date: Tue, 5 Nov 2019 15:33:07 +0100
Subject: [PATCH] Moves editor name part out of template. Adds null checking in
 templates

---
 .../src/views/propertyeditors/grid/grid.controller.js | 11 +++++++++--
 src/Umbraco.Web.UI/config/grid.editors.config.js      |  7 ++++---
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js
index 32f495e32b..5dce84d5dc 100644
--- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js
@@ -681,8 +681,15 @@ angular.module("umbraco")
             };
 
             $scope.getTemplateName = function (control) {
-                if (control.editor.nameExp) return control.editor.nameExp(control)
-                return control.editor.name;
+                var templateName = control.editor.name;
+                if (control.editor.nameExp) {
+                    var valueOfTemplate = control.editor.nameExp(control);
+                    if (valueOfTemplate != "") {
+                        templateName += ": ";
+                        templateName += valueOfTemplate;
+                    }
+                }
+                return templateName;
             }
 
             // *********************************************
diff --git a/src/Umbraco.Web.UI/config/grid.editors.config.js b/src/Umbraco.Web.UI/config/grid.editors.config.js
index 49b843689b..210d167f9e 100644
--- a/src/Umbraco.Web.UI/config/grid.editors.config.js
+++ b/src/Umbraco.Web.UI/config/grid.editors.config.js
@@ -7,14 +7,14 @@
     },
     {
         "name": "Image",
-        "nameTemplate": "{{ 'Image: ' + (value.udi | ncNodeName) }}",
+        "nameTemplate": "{{ value && value.udi ? (value.udi | ncNodeName) : '' }}",
         "alias": "media",
         "view": "media",
         "icon": "icon-picture"
     },
     {
         "name": "Macro",
-        "nameTemplate": "{{ 'Macro: ' + value.macroAlias }}",
+        "nameTemplate": "{{ value && value.macroAlias ? value.macroAlias : '' }}",
         "alias": "macro",
         "view": "macro",
         "icon": "icon-settings-alt"
@@ -27,7 +27,7 @@
     },
     {
         "name": "Headline",
-        "nameTemplate": "{{ 'Headline: ' + value }}",
+        "nameTemplate": "{{ value }}",
         "alias": "headline",
         "view": "textstring",
         "icon": "icon-coin",
@@ -38,6 +38,7 @@
     },
     {
         "name": "Quote",
+        "nameTemplate": "{{ value ? value.substring(0,32) + (value.length > 32 ? '...' : '') : '' }}",
         "alias": "quote",
         "view": "textstring",
         "icon": "icon-quote",