From 1da2c00f0a09ca2122b122d7224a6841bd7303b2 Mon Sep 17 00:00:00 2001 From: Sebastiaan Janssen Date: Tue, 25 Jun 2019 11:41:33 +0200 Subject: [PATCH] Fix logic & make code easier to follow --- src/Umbraco.Web/Services/DashboardService.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web/Services/DashboardService.cs b/src/Umbraco.Web/Services/DashboardService.cs index 0e33171f48..794c6fa671 100644 --- a/src/Umbraco.Web/Services/DashboardService.cs +++ b/src/Umbraco.Web/Services/DashboardService.cs @@ -104,8 +104,9 @@ namespace Umbraco.Web.Services } } - if (hasAccess || denyRules.Length == 0) - return true; + // No need to check denyRules if there aren't any, just return current state + if (denyRules.Length == 0) + return hasAccess; // check if this item has any deny arguments, if so check if the user is in one of the denied user groups, if so they will // be denied to see it no matter what