diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/lit-element/lit-element.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/lit-element/lit-element.element.ts index 4a5ff9f7a2..490081a7c9 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/lit-element/lit-element.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/lit-element/lit-element.element.ts @@ -1,8 +1,6 @@ import { LitElement, property } from '@umbraco-cms/backoffice/external/lit'; import { UmbElementMixin } from '@umbraco-cms/backoffice/element-api'; -// TODO: Currently we don't check if the `lang` is registered in the backoffice. We should do that. We can do that by checking if the `lang` is in the `languages` array of the `language` resource and potentially make sure that UmbLocalizationRegistry only loads the localizations and some other mechanism reloads to another language (currently it does both) - /** * The base class for all Umbraco LitElement elements. * @@ -19,7 +17,7 @@ export class UmbLitElement extends UmbElementMixin(LitElement) { * @example 'ltr' * @example 'rtl' */ - @property() dir: 'rtl' | 'ltr' | '' = ''; + @property() override dir: 'rtl' | 'ltr' | '' = ''; /** * The language of the element. @@ -29,5 +27,5 @@ export class UmbLitElement extends UmbElementMixin(LitElement) { * @example 'en-us' * @example 'en' */ - @property() lang = ''; + @property() override lang = ''; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts index d50807098e..4b5a6c4b35 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts @@ -1,6 +1,3 @@ -import { UmbLanguageDetailRepository } from '../../repository/index.js'; -import type { UmbLanguageDetailModel } from '../../types.js'; -import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js'; import { type UmbSubmittableWorkspaceContext, UmbSubmittableWorkspaceContextBase, @@ -10,6 +7,9 @@ import { } from '@umbraco-cms/backoffice/workspace'; import { UmbObjectState } from '@umbraco-cms/backoffice/observable-api'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; +import { UmbLanguageDetailRepository } from '../../repository/index.js'; +import type { UmbLanguageDetailModel } from '../../types.js'; +import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js'; export class UmbLanguageWorkspaceContext extends UmbSubmittableWorkspaceContextBase @@ -27,8 +27,6 @@ export class UmbLanguageWorkspaceContext #validationErrors = new UmbObjectState(undefined); readonly validationErrors = this.#validationErrors.asObservable(); - readonly routes = new UmbWorkspaceRouteManager(this); - constructor(host: UmbControllerHost) { super(host, 'Umb.Workspace.Language');