Refactor editing, cleanup

This commit is contained in:
Stephan
2018-02-25 10:43:16 +01:00
parent 47d7677948
commit 1f60314348
66 changed files with 267 additions and 360 deletions

View File

@@ -35,7 +35,7 @@ namespace Umbraco.Web.Models.ContentEditing
/// Used internally during model mapping
/// </summary>
[IgnoreDataMember]
internal IConfiguredDataEditor PropertyEditor { get; set; }
internal IDataEditor PropertyEditor { get; set; }
}
}

View File

@@ -45,7 +45,7 @@ namespace Umbraco.Web.Models.ContentEditing
/// Gets or sets the property editor.
/// </summary>
[IgnoreDataMember]
internal IConfiguredDataEditor PropertyEditor { get; set; }
internal IDataEditor PropertyEditor { get; set; }
}
}

View File

@@ -36,15 +36,8 @@ namespace Umbraco.Web.Models.Mapping
/// </summary>
public IEnumerable<DataTypeConfigurationFieldDisplay> Resolve(IDataType dataType)
{
ConfiguredDataEditor editor = null;
if (!string.IsNullOrWhiteSpace(dataType.EditorAlias))
{
if (!Current.PropertyEditors.TryGet(dataType.EditorAlias, out var e1))
throw new InvalidOperationException($"Could not find a property editor with alias \"{dataType.EditorAlias}\".");
if (!(e1 is ConfiguredDataEditor e2))
throw new InvalidOperationException($"Property editor with alias \"{dataType.EditorAlias}\" is not configurable.");
editor = e2;
}
if (!string.IsNullOrWhiteSpace(dataType.EditorAlias) || !Current.PropertyEditors.TryGet(dataType.EditorAlias, out var e) || !(e is DataEditor editor))
throw new InvalidOperationException($"Could not find a property editor with alias \"{dataType.EditorAlias}\".");
var configuration = dataType.Configuration;
Dictionary<string, object> configurationDictionary = null;

View File

@@ -23,7 +23,7 @@ namespace Umbraco.Web.Models.Mapping
var configurationDisplayResolver = new DataTypeConfigurationFieldDisplayResolver();
var databaseTypeResolver = new DatabaseTypeResolver();
CreateMap<ConfiguredDataEditor, PropertyEditorBasic>();
CreateMap<DataEditor, PropertyEditorBasic>();
// map the standard properties, not the values
CreateMap<ConfigurationField, DataTypeConfigurationFieldDisplay>()
@@ -36,7 +36,7 @@ namespace Umbraco.Web.Models.Mapping
Constants.DataTypes.DefaultMembersListView
};
CreateMap<ConfiguredDataEditor, DataTypeBasic>()
CreateMap<DataEditor, DataTypeBasic>()
.ForMember(dest => dest.Udi, opt => opt.Ignore())
.ForMember(dest => dest.HasPrevalues, opt => opt.Ignore())
.ForMember(dest => dest.IsSystemDataType, opt => opt.Ignore())
@@ -105,7 +105,7 @@ namespace Umbraco.Web.Models.Mapping
.ForMember(dest => dest.Editor, opt => opt.MapFrom(src => propertyEditors[src.EditorAlias]));
//Converts a property editor to a new list of pre-value fields - used when creating a new data type or changing a data type with new pre-vals
CreateMap<ConfiguredDataEditor, IEnumerable<DataTypeConfigurationFieldDisplay>>()
CreateMap<DataEditor, IEnumerable<DataTypeConfigurationFieldDisplay>>()
.ConvertUsing(src =>
{
// this is a new data type, initialize default configuration