From 1fcfdab1ed3da3408997d344430acdda7c9a27b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Wed, 7 Feb 2024 14:35:09 +0100 Subject: [PATCH] corrections --- .../block/block-grid/context/block-grid-manager.context.ts | 2 +- .../block/block-list/context/block-list-manager.context.ts | 2 +- .../packages/block/block/context/block-manager.context.ts | 6 ++++++ .../block/block/workspace/block-workspace.context.ts | 4 ++-- .../layouts/default/notification-layout-default.test.ts | 1 + .../property-editor-ui-image-crops-configuration.test.ts | 2 ++ 6 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/context/block-grid-manager.context.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/context/block-grid-manager.context.ts index 953b0afe9f..eb4b852f98 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/context/block-grid-manager.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/context/block-grid-manager.context.ts @@ -22,7 +22,7 @@ export class UmbBlockGridManagerContext extends UmbBlockManagerContext( modalData: ModalDataType, layoutEntry: Omit, diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts index 3582efd244..1408231ebd 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts @@ -143,7 +143,7 @@ export class UmbBlockWorkspaceContext< this.#layout.setValue(layoutData as LayoutDataType); if (this.#liveEditingMode) { - const blockCreated = this.#blockManager.createBlock( + const blockCreated = this.#blockManager.create( this.#modalContext.data as UmbBlockWorkspaceData, layoutData, contentElementTypeId, @@ -225,7 +225,7 @@ export class UmbBlockWorkspaceContext< if (!this.#liveEditingMode) { if (this.getIsNew() === true) { - const blockCreated = this.#blockManager.createBlock( + const blockCreated = this.#blockManager.create( this.#modalContext.data as UmbBlockWorkspaceData, layoutData, contentData.contentTypeKey, diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/notification/layouts/default/notification-layout-default.test.ts b/src/Umbraco.Web.UI.Client/src/packages/core/notification/layouts/default/notification-layout-default.test.ts index e21e5a90f2..35bb96d08f 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/notification/layouts/default/notification-layout-default.test.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/notification/layouts/default/notification-layout-default.test.ts @@ -3,6 +3,7 @@ import type { UmbNotificationDefaultData } from './notification-layout-default.e import { UmbNotificationLayoutDefaultElement } from './notification-layout-default.element.js'; import type { UUIToastNotificationLayoutElement } from '@umbraco-cms/backoffice/external/uui'; import { UmbNotificationHandler } from '@umbraco-cms/backoffice/notification'; +import type { UmbTestRunnerWindow } from '@umbraco-cms/internal/test-utils'; describe('UmbNotificationLayoutDefault', () => { let element: UmbNotificationLayoutDefaultElement; diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/property-editors/image-crops-configuration/property-editor-ui-image-crops-configuration.test.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/property-editors/image-crops-configuration/property-editor-ui-image-crops-configuration.test.ts index 36c87d4d3c..1bd5b1dd11 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/property-editors/image-crops-configuration/property-editor-ui-image-crops-configuration.test.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/property-editors/image-crops-configuration/property-editor-ui-image-crops-configuration.test.ts @@ -15,10 +15,12 @@ describe('UmbPropertyEditorUIImageCropsConfigurationElement', () => { expect(element).to.be.instanceOf(UmbPropertyEditorUIImageCropsConfigurationElement); }); + /* if ((window as UmbTestRunnerWindow).__UMBRACO_TEST_RUN_A11Y_TEST) { it('passes the a11y audit', async () => { //TODO: This test is broken. It fails at forms because of missing labels even if you have them. // await expect(element).shadowDom.to.be.accessible(defaultA11yConfig); }); } + */ });