yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup

Browse Source
This commit is contained in:
Stephan
2019-02-07 12:27:19 +01:00
parent a9adc4eee5
commit 2092156db3
12 changed files with 32 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/Umbraco.Tests/Testing/ContentBaseExtensions.cs
View File

@@ -9,7 +9,7 @@ namespace Umbraco.Tests.Testing
{
public static class ContentBaseExtensions
{
/// <summary>
/// Set property values by alias with an anonymous object.
/// </summary>
@@ -22,29 +22,12 @@ namespace Umbraco.Tests.Testing
var propertyInfos = value.GetType().GetProperties();
foreach (var propertyInfo in propertyInfos)
{
if (content.Properties.TryGetValue(propertyInfo.Name, out var property))
{
property.SetValue(propertyInfo.GetValue(value, null), culture, segment);
//Update item with newly added value
content.Properties.Add(property);
}
else
{
if (!content.Properties.TryGetValue(propertyInfo.Name, out var property))
throw new Exception($"The property alias {propertyInfo.Name} is not valid, because no PropertyType with this alias exists");
//fixme: Can this ever happen? According to the ctor in ContentBase (EnsurePropertyTypes), all properties will be created based on the content type's property types
// so how can a property not be resolved by the alias on the content.Properties but it can on the content type?
// This maybe can happen if a developer has removed a property with the api and is trying to then set the value of that property again...
// BUT, as it turns out the content.Properties.Remove(...) method is NEVER used, because why and how could it? you never remove a property from
// a content item directly.
var propertyType = ((ContentBase)content).AllPropertyTypes.FirstOrDefault(x => x.Alias == propertyInfo.Name);
if (propertyType == null)
throw new Exception($"The property alias {propertyInfo.Name} is not valid, because no PropertyType with this alias exists");
//Create new Property to add to collection
property = propertyType.CreateProperty();
property.SetValue(propertyInfo.GetValue(value, null), culture, segment);
content.Properties.Add(property);
}
property.SetValue(propertyInfo.GetValue(value, null), culture, segment);
//Update item with newly added value
content.Properties.Add(property);
}
}
}