From 227559fe7a5d44324b529af4f0248fc98a6a81fa Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Thu, 4 Jul 2024 11:59:11 +0200 Subject: [PATCH] catch the error instead of relying on a timeout --- .../create-extension-api-by-alias.test.ts | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/utils/create-extension-api-by-alias.test.ts b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/utils/create-extension-api-by-alias.test.ts index 71d67efa06..0cc1f3c56a 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/utils/create-extension-api-by-alias.test.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/utils/create-extension-api-by-alias.test.ts @@ -46,7 +46,6 @@ describe('Create Extension Api By Alias Method', () => { hostElement = await fixture(html``); }); - /* it('Returns `undefined` when manifest does not have any correct properties', (done) => { const manifest: ManifestApi = { type: 'my-test-type', @@ -55,17 +54,17 @@ describe('Create Extension Api By Alias Method', () => { }; umbExtensionsRegistry.register(manifest); - createExtensionApiByAlias(hostElement, manifest.alias, []).then(() => { - umbExtensionsRegistry.unregister(manifest.alias); - done(new Error('Should not resolve')); - }); - - setTimeout(() => { - umbExtensionsRegistry.unregister(manifest.alias); - done(); - }, 10); + createExtensionApiByAlias(hostElement, manifest.alias, []).then( + () => { + umbExtensionsRegistry.unregister(manifest.alias); + done(new Error('Should not resolve')); + }, + () => { + umbExtensionsRegistry.unregister(manifest.alias); + done(); + }, + ); }); - */ it('Handles when `api` property contains a class constructor', async () => { const manifest: ManifestApi = {