From 22fccc7b64bbb72371b75e223d9208fe25268fef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Mon, 28 Aug 2023 15:21:22 +0200 Subject: [PATCH] notes --- .../documents/dataset-context/document-dataset-context.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/dataset-context/document-dataset-context.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/dataset-context/document-dataset-context.ts index 6245dfc1a0..1e50182daa 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/dataset-context/document-dataset-context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/dataset-context/document-dataset-context.ts @@ -23,7 +23,9 @@ export class UmbDocumentDatasetContext extends UmbBaseController implements UmbV segment = this.#currentVariant.asObservablePart((x) => x?.segment); // TODO: Refactor: Make a properties observable. (with such I think i mean a property value object array.. array with object with properties, alias, value, culture and segment) - + // TO make such happen I think we need to maintain all properties and their value of this object. + // This will actually make it simpler if multiple are watching the same property. + // But it will also mean that we wil watch all properties and their structure, for variantID, all the time for all of the properties. getType(): string {