From d3b9486038003419134f39d3b40afe2d9105b0af Mon Sep 17 00:00:00 2001
From: Lone Iversen <108085781+loivsen@users.noreply.github.com>
Date: Wed, 14 Feb 2024 14:41:12 +0100
Subject: [PATCH] fix build errors

---
 .../document-type-workspace-view-edit-properties.element.ts | 4 ++--
 .../document-type-workspace-view-edit-property.element.ts   | 3 ++-
 .../design/document-type-workspace-view-edit-tab.element.ts | 6 ++++--
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-properties.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-properties.element.ts
index 0a20071218..dc7699b0dd 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-properties.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-properties.element.ts
@@ -30,13 +30,13 @@ export class UmbDocumentTypeWorkspaceViewEditPropertiesElement extends UmbLitEle
 		// TODO: Fix bug where a local property turn into an inherited when moved to a new group container.
 		containerSelector: '#property-list',
 		onChange: ({ item, model }) => {
-			const isInNewContainer = model.find((entry) => entry.container.id !== this._containerId);
+			const isInNewContainer = model.find((entry) => entry?.container?.id !== this._containerId && this._containerId);
 			if (isInNewContainer) {
 				model.forEach((entry, index) => {
 					entry.id === item.id
 						? this._propertyStructureHelper.partialUpdateProperty(entry.id, {
 								sortOrder: index,
-								container: { id: this._containerId },
+								container: { id: this._containerId! },
 						  })
 						: this._propertyStructureHelper.partialUpdateProperty(entry.id, { sortOrder: index });
 				});
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-property.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-property.element.ts
index af1e782e06..d0c7858416 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-property.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-property.element.ts
@@ -197,7 +197,8 @@ export class UmbDocumentTypeWorkspacePropertyElement extends UmbLitElement {
 				type="number"
 				?readonly=${this.inherited}
 				label="sort order"
-				@change=${(e: UUIInputEvent) => this._partialUpdate({ sortOrder: parseInt(e.target.value as string) || 0 })}
+				@change=${(e: UUIInputEvent) =>
+					this._partialUpdate({ sortOrder: parseInt(e.target.value as string) || 0 } as UmbPropertyTypeModel)}
 				.value=${this.property.sortOrder ?? 0}></uui-input>
 		`;
 	}
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts
index 31a74d2938..616cbf4787 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts
@@ -1,6 +1,8 @@
 import type { UmbDocumentTypeDetailModel } from '../../../types.js';
 import type { UmbDocumentTypeWorkspaceContext } from '../../document-type-workspace.context.js';
 import type { UmbDocumentTypeWorkspaceViewEditPropertiesElement } from './document-type-workspace-view-edit-properties.element.js';
+
+import type { UUIInputEvent } from '@umbraco-cms/backoffice/external/uui';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
 import { css, html, customElement, property, state, repeat, ifDefined } from '@umbraco-cms/backoffice/external/lit';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
@@ -24,7 +26,7 @@ export class UmbDocumentTypeWorkspaceViewEditTabElement extends UmbLitElement {
 			identifier: 'document-type-container-sorter',
 			itemSelector: '.container-handle',
 			containerSelector: '.container-list',
-			onChange: ({ item, model }) => {
+			onChange: ({ model }) => {
 				model.forEach((modelItem, index) => {
 					this._groupStructureHelper.partialUpdateContainer(modelItem.id, { sortOrder: index });
 				});
@@ -172,7 +174,7 @@ export class UmbDocumentTypeWorkspaceViewEditTabElement extends UmbLitElement {
 				<uui-input
 					type="number"
 					label=${this.localize.term('sort_sortOrder')}
-					@change=${(e: InputEvent) => {
+					@change=${(e: UUIInputEvent) => {
 						this._groupStructureHelper.partialUpdateContainer(group.id!, {
 							sortOrder: parseInt(e.target.value as string) || 0,
 						});