diff --git a/src/Umbraco.Web.UI/umbraco/developer/Python/editPython.aspx b/src/Umbraco.Web.UI/umbraco/developer/Python/editPython.aspx index 082c480869..d4b2d5ce68 100644 --- a/src/Umbraco.Web.UI/umbraco/developer/Python/editPython.aspx +++ b/src/Umbraco.Web.UI/umbraco/developer/Python/editPython.aspx @@ -38,13 +38,12 @@ - + - + diff --git a/src/Umbraco.Web.UI/umbraco/developer/Xslt/editXslt.aspx b/src/Umbraco.Web.UI/umbraco/developer/Xslt/editXslt.aspx index a51caa8be8..8a58fd6589 100644 --- a/src/Umbraco.Web.UI/umbraco/developer/Xslt/editXslt.aspx +++ b/src/Umbraco.Web.UI/umbraco/developer/Xslt/editXslt.aspx @@ -54,12 +54,12 @@ - + - + diff --git a/src/Umbraco.Web.UI/umbraco/settings/editTemplate.aspx b/src/Umbraco.Web.UI/umbraco/settings/editTemplate.aspx index da36e5ae7d..4f16123fba 100644 --- a/src/Umbraco.Web.UI/umbraco/settings/editTemplate.aspx +++ b/src/Umbraco.Web.UI/umbraco/settings/editTemplate.aspx @@ -109,20 +109,20 @@ - + - + - + + AutoResize="false" /> diff --git a/src/Umbraco.Web.UI/umbraco/settings/scripts/editScript.aspx b/src/Umbraco.Web.UI/umbraco/settings/scripts/editScript.aspx index 489470895e..e68922bd98 100644 --- a/src/Umbraco.Web.UI/umbraco/settings/scripts/editScript.aspx +++ b/src/Umbraco.Web.UI/umbraco/settings/scripts/editScript.aspx @@ -39,17 +39,17 @@ - - + + + runat="server" AutoResize="false" /> - + - + diff --git a/src/Umbraco.Web.UI/umbraco/settings/stylesheet/editstylesheet.aspx b/src/Umbraco.Web.UI/umbraco/settings/stylesheet/editstylesheet.aspx index 4e79f8b3fe..f107edad96 100644 --- a/src/Umbraco.Web.UI/umbraco/settings/stylesheet/editstylesheet.aspx +++ b/src/Umbraco.Web.UI/umbraco/settings/stylesheet/editstylesheet.aspx @@ -40,7 +40,7 @@ - + diff --git a/src/Umbraco.Web.UI/umbraco/settings/views/EditView.aspx b/src/Umbraco.Web.UI/umbraco/settings/views/EditView.aspx index 2c6fc12f76..ba464262d0 100644 --- a/src/Umbraco.Web.UI/umbraco/settings/views/EditView.aspx +++ b/src/Umbraco.Web.UI/umbraco/settings/views/EditView.aspx @@ -55,26 +55,26 @@ - + - + - + - + - + - + - + diff --git a/src/umbraco.controls/CodeArea.cs b/src/umbraco.controls/CodeArea.cs index 6cf048004c..3d0608a322 100644 --- a/src/umbraco.controls/CodeArea.cs +++ b/src/umbraco.controls/CodeArea.cs @@ -3,6 +3,7 @@ using System.Collections; using System.ComponentModel; using System.Data; using System.Drawing; +using System.Text; using System.Web; using System.Web.SessionState; using System.Web.UI; @@ -132,13 +133,13 @@ namespace umbraco.uicontrols { EnsureChildControls(); - var jsEventCode = ""; + var jsEventCode = new StringBuilder(); if (CodeMirrorEnabled == false) { CodeTextBox.RenderControl(writer); - jsEventCode = RenderBasicEditor(); + jsEventCode.Append(RenderBasicEditor()); } else { @@ -148,13 +149,25 @@ namespace umbraco.uicontrols this.ControlStyle.AddAttributesToRender(writer); writer.Write(HtmlTextWriter.TagRightChar); Menu.RenderControl(writer); + + writer.WriteBeginTag("div"); + writer.WriteAttribute("class", "code-container"); + this.ControlStyle.AddAttributesToRender(writer); + writer.Write(HtmlTextWriter.TagRightChar); CodeTextBox.RenderControl(writer); writer.WriteEndTag("div"); + writer.WriteEndTag("div"); - jsEventCode = RenderCodeEditor(); + jsEventCode.Append(RenderCodeEditor()); } - + jsEventCode.Append(@" + //TODO: for now this is a global var, need to refactor all this so that is using proper js standards + //with correct objects, and proper accessors to these objects. + var UmbEditor; + $(document).ready(function () { + //create the editor + UmbEditor = new Umbraco.Controls.CodeEditor.UmbracoEditor(" + (CodeMirrorEnabled == false).ToString().ToLower() + @", '" + ClientID + @"');"); if (this.AutoResize) { @@ -165,27 +178,22 @@ namespace umbraco.uicontrols OffSetY += 50; } - jsEventCode += @" - //TODO: for now this is a global var, need to refactor all this so that is using proper js standards - //with correct objects, and proper accessors to these objects. - var UmbEditor; - $(document).ready(function () { - //create the editor - UmbEditor = new Umbraco.Controls.CodeEditor.UmbracoEditor(" + (CodeMirrorEnabled == false).ToString().ToLower() + @", '" + this.ClientID + @"'); - var m_textEditor = jQuery('#" + this.ClientID + @"'); + //add the resize code + jsEventCode.Append(@" + var m_textEditor = jQuery('#" + ClientID + @"'); //with codemirror adding divs for line numbers, we need to target a different element m_textEditor = m_textEditor.find('iframe').length > 0 ? m_textEditor.children('div').get(0) : m_textEditor.get(0); - jQuery(window).resize(function(){ resizeTextArea(m_textEditor, " + OffSetX.ToString() + "," + OffSetY.ToString() + @"); }); - jQuery(document).ready(function(){ resizeTextArea(m_textEditor, " + OffSetX.ToString() + "," + OffSetY.ToString() + @"); }); - });"; - + jQuery(window).resize(function(){ resizeTextArea(m_textEditor, " + OffSetX + "," + OffSetY + @"); }); + jQuery(document).ready(function(){ resizeTextArea(m_textEditor, " + OffSetX + "," + OffSetY + @"); });"); + } - jsEventCode = string.Format(@"", jsEventCode); - writer.WriteLine(jsEventCode); + jsEventCode.Append(@" + });"); + writer.WriteLine(@"", jsEventCode); } @@ -212,8 +220,6 @@ namespace umbraco.uicontrols var jsEventCode = @" var textarea = document.getElementById('" + CodeTextBox.ClientID + @"'); var codeEditor = CodeMirror.fromTextArea(textarea, { - width: ""100%"", - height: ""100%"", tabMode: ""shift"", matchBrackets: true, indentUnit: 4, diff --git a/src/umbraco.controls/Panel.cs b/src/umbraco.controls/Panel.cs index f749b71637..0149627da5 100644 --- a/src/umbraco.controls/Panel.cs +++ b/src/umbraco.controls/Panel.cs @@ -109,7 +109,7 @@ namespace umbraco.uicontrols row.Controls.Add(rightcol); body.TagName = "div"; - body.Attributes.Add("class", "umb-panel-body umb-scrollable row-fluid"); + body.Attributes.Add("class", "umb-panel-body row-fluid"); Width = Unit.Empty; Height = Unit.Empty; diff --git a/src/umbraco.controls/TabPage.cs b/src/umbraco.controls/TabPage.cs index e5b59ee97c..aae552de98 100644 --- a/src/umbraco.controls/TabPage.cs +++ b/src/umbraco.controls/TabPage.cs @@ -88,7 +88,7 @@ namespace umbraco.uicontrols { if (this.ID == parent.ActiveTabId) activeClass = "active"; - writer.WriteLine("
"); + writer.WriteLine("
"); writer.WriteLine("
"); this.RenderChildren(writer);