From 28e8ac11f0c37f7f5b8fbd729c33642e2029928e Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Wed, 15 Nov 2023 09:03:08 +0100 Subject: [PATCH] Added scope.complete in edge cases. (#15207) --- src/Umbraco.Core/Services/ContentVersionService.cs | 2 ++ src/Umbraco.Web.Website/Controllers/UmbProfileController.cs | 1 + 2 files changed, 3 insertions(+) diff --git a/src/Umbraco.Core/Services/ContentVersionService.cs b/src/Umbraco.Core/Services/ContentVersionService.cs index 1c190311da..3d3eed062e 100644 --- a/src/Umbraco.Core/Services/ContentVersionService.cs +++ b/src/Umbraco.Core/Services/ContentVersionService.cs @@ -77,6 +77,7 @@ internal class ContentVersionService : IContentVersionService if (version is null) { + scope.Complete(); return; } @@ -128,6 +129,7 @@ internal class ContentVersionService : IContentVersionService if (allHistoricVersions is null) { + scope.Complete(); return Array.Empty(); } if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug)) diff --git a/src/Umbraco.Web.Website/Controllers/UmbProfileController.cs b/src/Umbraco.Web.Website/Controllers/UmbProfileController.cs index 22d5f7e3e2..d493bb7e02 100644 --- a/src/Umbraco.Web.Website/Controllers/UmbProfileController.cs +++ b/src/Umbraco.Web.Website/Controllers/UmbProfileController.cs @@ -112,6 +112,7 @@ public class UmbProfileController : SurfaceController IdentityResult saveResult = await _memberManager.UpdateAsync(currentMember); if (!saveResult.Succeeded) { + scope.Complete(); return saveResult; }