From 2941b350136016315c4113760c64bd5a04ddf6af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <niels.lyngso@gmail.com>
Date: Tue, 5 Nov 2024 10:41:52 +0100
Subject: [PATCH] use slotchange callback + clean up

---
 .../workspace-split-view/workspace-split-view.element.ts | 9 +++++----
 ...ment-workspace-split-view-variant-selector.element.ts | 3 ---
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts
index 57ee63c769..d205654112 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts
@@ -33,12 +33,13 @@ export class UmbWorkspaceSplitViewElement extends UmbLitElement {
 
 	@state()
 	private _variantSelectorSlotHasContent = false;
-	private _variantSelectorSlotChanged = (e: Event) => {
-		this._variantSelectorSlotHasContent = (e.target as HTMLSlotElement).assignedNodes({ flatten: true }).length > 0;
-	};
 
 	splitViewContext = new UmbWorkspaceSplitViewContext(this);
 
+	#onVariantSelectorSlotChanged(e: Event) {
+		this._variantSelectorSlotHasContent = (e.target as HTMLSlotElement).assignedNodes({ flatten: true }).length > 0;
+	}
+
 	override render() {
 		return html`
 			<umb-workspace-editor
@@ -46,7 +47,7 @@ export class UmbWorkspaceSplitViewElement extends UmbLitElement {
 				back-path=${ifDefined(this.backPath)}
 				.hideNavigation=${!this.displayNavigation}
 				.enforceNoFooter=${true}>
-				<slot id="header" name="variant-selector" slot="header">
+				<slot id="header" name="variant-selector" slot="header" @slotchange=${this.#onVariantSelectorSlotChanged}>
 					${this._variantSelectorSlotHasContent
 						? nothing
 						: html`<umb-workspace-split-view-variant-selector></umb-workspace-split-view-variant-selector>`}
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-split-view-variant-selector.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-split-view-variant-selector.element.ts
index 46a4bac112..f08abb5f61 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-split-view-variant-selector.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-split-view-variant-selector.element.ts
@@ -2,7 +2,6 @@ import type { UmbDocumentVariantOptionModel } from '../types.js';
 import { sortVariants } from '../utils.js';
 import { customElement, html } from '@umbraco-cms/backoffice/external/lit';
 import { DocumentVariantStateModel } from '@umbraco-cms/backoffice/external/backend-api';
-import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { UmbWorkspaceSplitViewVariantSelectorElement } from '@umbraco-cms/backoffice/workspace';
 
 const elementName = 'umb-document-workspace-split-view-variant-selector';
@@ -22,8 +21,6 @@ export class UmbDocumentWorkspaceSplitViewVariantSelectorElement extends UmbWork
 			this.#publishStateLocalizationMap[variantOption.variant?.state || DocumentVariantStateModel.NOT_CREATED],
 		)}`;
 	}
-
-	static override styles = [...UmbWorkspaceSplitViewVariantSelectorElement.styles, UmbTextStyles];
 }
 
 declare global {