From 2b7f12253f48c7ec08b8511c4f42bb27cd439742 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <nsl@umbraco.dk>
Date: Fri, 8 Mar 2019 12:40:24 +0100
Subject: [PATCH] umb-checkbox id renamed to input-id for it not to collide,
 since ids have to be unique.

---
 .../directives/components/forms/umbcheckbox.directive.js  | 8 ++++----
 .../src/views/components/forms/umb-checkbox.html          | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbcheckbox.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbcheckbox.directive.js
index 54c6c67755..47381a15c0 100644
--- a/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbcheckbox.directive.js
+++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbcheckbox.directive.js
@@ -22,14 +22,14 @@
 </pre>
 
 @param {boolean} model Set to <code>true</code> or <code>false</code> to set the checkbox to checked or unchecked.
-@param {string} id Set the id of the checkbox.
+@param {string} input-id Set the <code>id</code> of the checkbox.
 @param {string} value Set the value of the checkbox.
 @param {string} name Set the name of the checkbox.
 @param {string} text Set the text for the checkbox label.
-@param {string} serverValidationField Set the val-server-field of the checkbox.
+@param {string} server-validation-field Set the <code>val-server-field</code> of the checkbox.
 @param {boolean} disabled Set the checkbox to be disabled.
 @param {boolean} required Set the checkbox to be required.
-@param {string} onChange Callback when the value of the input element changes.
+@param {string} on-change Callback when the value of the checkbox changed by interaction.
 
 **/
 
@@ -56,7 +56,7 @@
         controllerAs: 'vm',
         bindings: {
             model: "=",
-            id: "@",
+            inputId: "@",
             value: "@",
             name: "@",
             text: "@",
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/forms/umb-checkbox.html b/src/Umbraco.Web.UI.Client/src/views/components/forms/umb-checkbox.html
index 4de97b7856..d40263c6b6 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/forms/umb-checkbox.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/forms/umb-checkbox.html
@@ -1,6 +1,6 @@
 <label class="checkbox umb-form-check umb-form-check--checkbox" ng-class="{ 'umb-form-check--disabled': disabled }">
     <input type="checkbox"
-           id="{{vm.id}}"
+           id="{{vm.inputId}}"
            name="{{vm.name}}"
            value="{{vm.value}}"
            class="umb-form-check__input"