diff --git a/build/Build.bat b/build/Build.bat index 966fcdb84f..66f0c7e3b9 100644 --- a/build/Build.bat +++ b/build/Build.bat @@ -1,5 +1,5 @@ @ECHO OFF -SET release=6.0.2 +SET release=6.0.3 SET comment= SET version=%release% diff --git a/src/SQLCE4Umbraco/SqlCEHelper.cs b/src/SQLCE4Umbraco/SqlCEHelper.cs index a35f84de82..a7f1abd88c 100644 --- a/src/SQLCE4Umbraco/SqlCEHelper.cs +++ b/src/SQLCE4Umbraco/SqlCEHelper.cs @@ -149,7 +149,9 @@ namespace SqlCE4Umbraco var dataDirectory = AppDomain.CurrentDomain.GetData("DataDirectory") as string; if (!string.IsNullOrEmpty(dataDirectory)) { - path = path.Replace("|DataDirectory|", dataDirectory + System.IO.Path.DirectorySeparatorChar); + path = path.Contains(@"|\") + ? path.Replace("|DataDirectory|", dataDirectory) + : path.Replace("|DataDirectory|", dataDirectory + System.IO.Path.DirectorySeparatorChar); } } diff --git a/src/Umbraco.Core/DatabaseContext.cs b/src/Umbraco.Core/DatabaseContext.cs index 780e799095..e33b63b01b 100644 --- a/src/Umbraco.Core/DatabaseContext.cs +++ b/src/Umbraco.Core/DatabaseContext.cs @@ -112,7 +112,7 @@ namespace Umbraco.Core public void ConfigureEmbeddedDatabaseConnection() { const string providerName = "System.Data.SqlServerCe.4.0"; - const string connectionString = "Datasource=|DataDirectory|Umbraco.sdf"; + const string connectionString = @"Data Source=|DataDirectory|\Umbraco.sdf"; SaveConnectionString(connectionString, providerName); diff --git a/src/Umbraco.Core/Models/PropertyType.cs b/src/Umbraco.Core/Models/PropertyType.cs index c67a2bd2ed..874e58ea6f 100644 --- a/src/Umbraco.Core/Models/PropertyType.cs +++ b/src/Umbraco.Core/Models/PropertyType.cs @@ -335,8 +335,8 @@ namespace Umbraco.Core.Models if (Mandatory && (value == null || string.IsNullOrEmpty(value.ToString()))) return false; - //Check against Regular Expression for Legacy DataTypes - if(!string.IsNullOrEmpty(ValidationRegExp)) + //Check against Regular Expression for Legacy DataTypes - Validation exists and value is not null: + if(string.IsNullOrEmpty(ValidationRegExp) == false && (value != null && string.IsNullOrEmpty(value.ToString()) == false)) { var regexPattern = new Regex(ValidationRegExp); return regexPattern.IsMatch(value.ToString()); diff --git a/src/Umbraco.Core/Persistence/Repositories/MediaRepository.cs b/src/Umbraco.Core/Persistence/Repositories/MediaRepository.cs index 33a7a35e9f..3e2152e37c 100644 --- a/src/Umbraco.Core/Persistence/Repositories/MediaRepository.cs +++ b/src/Umbraco.Core/Persistence/Repositories/MediaRepository.cs @@ -348,6 +348,17 @@ namespace Umbraco.Core.Persistence.Repositories var propertyDataDtos = Database.Fetch(sql); var propertyFactory = new PropertyFactory(contentType, versionId, id); var properties = propertyFactory.BuildMediaEntity(propertyDataDtos); + + var newProperties = properties.Where(x => x.HasIdentity == false); + foreach (var property in newProperties) + { + var propertyDataDto = new PropertyDataDto { NodeId = id, PropertyTypeId = property.PropertyTypeId, VersionId = versionId }; + int primaryKey = Convert.ToInt32(Database.Insert(propertyDataDto)); + + property.Version = versionId; + property.Id = primaryKey; + } + return new PropertyCollection(properties); } } diff --git a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/DataTypes/editDatatype.aspx.cs b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/DataTypes/editDatatype.aspx.cs index 7106ef6ee3..7c1e8a5de1 100644 --- a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/DataTypes/editDatatype.aspx.cs +++ b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/DataTypes/editDatatype.aspx.cs @@ -91,7 +91,7 @@ namespace umbraco.cms.presentation.developer } - protected void save_click(object sender, System.Web.UI.ImageClickEventArgs e) + protected void save_click(object sender, ImageClickEventArgs e) { // save prevalues; if (_prevalue != null) @@ -106,7 +106,7 @@ namespace umbraco.cms.presentation.developer ClientTools.ShowSpeechBubble(BasePages.BasePage.speechBubbleIcon.save, ui.Text("speechBubbles", "dataTypeSaved", null), ""); - //Response.Redirect("editDataType.aspx?id=" + _id); + ClientTools.SyncTree(dt.Path, true); } diff --git a/src/umbraco.businesslogic/User.cs b/src/umbraco.businesslogic/User.cs index 0f1e5d4946..6987be7123 100644 --- a/src/umbraco.businesslogic/User.cs +++ b/src/umbraco.businesslogic/User.cs @@ -394,11 +394,17 @@ namespace umbraco.BusinessLogic /// A user or null public static User GetCurrent() { - if (umbraco.BasePages.BasePage.umbracoUserContextID != "") - return BusinessLogic.User.GetUser(umbraco.BasePages.BasePage.GetUserId(umbraco.BasePages.BasePage.umbracoUserContextID)); - else + try + { + if (umbraco.BasePages.BasePage.umbracoUserContextID != "") + return BusinessLogic.User.GetUser(umbraco.BasePages.BasePage.GetUserId(umbraco.BasePages.BasePage.umbracoUserContextID)); + else + return null; + } + catch (Exception) + { return null; - + } } /// diff --git a/src/umbraco.cms/businesslogic/media/MediaType.cs b/src/umbraco.cms/businesslogic/media/MediaType.cs index 46c24305c4..ee80b3d7b2 100644 --- a/src/umbraco.cms/businesslogic/media/MediaType.cs +++ b/src/umbraco.cms/businesslogic/media/MediaType.cs @@ -139,7 +139,7 @@ namespace umbraco.cms.businesslogic.media base.Save(); - FireBeforeSave(e); + FireAfterSave(e); } } diff --git a/src/umbraco.datalayer/DataLayerHelper.cs b/src/umbraco.datalayer/DataLayerHelper.cs index d50aa5fc8a..7952b737ec 100644 --- a/src/umbraco.datalayer/DataLayerHelper.cs +++ b/src/umbraco.datalayer/DataLayerHelper.cs @@ -53,11 +53,11 @@ namespace umbraco.DataLayer if (forceLegacyConnection == false && IsEmbeddedDatabase(connectionString) && connectionString.ToLower().Contains("SQLCE4Umbraco".ToLower()) == false) { - // Input is : Datasource=|DataDirectory|Umbraco.sdf - // Should be: datalayer=SQLCE4Umbraco.SqlCEHelper,SQLCE4Umbraco;data source=|DataDirectory|\Umbraco.sdf + connectionString = connectionString.Replace("Datasource", "Data Source"); - connectionString = connectionString.Replace("Datasource", "data source"); + if(connectionString.Contains(@"|\") == false) connectionString = connectionString.Insert(connectionString.LastIndexOf('|') + 1, "\\"); + connectionString = string.Format("datalayer=SQLCE4Umbraco.SqlCEHelper,SQLCE4Umbraco;{0}", connectionString); }