yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Returning all packages from PackagingService so they show in the backoffice (#12322)

Browse Source 
* Add pr first response workflow

* Returning all packages from PackagingService so they show in the backoffice

Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Paul Johnson <pmj@umbraco.com>
This commit is contained in:
Callum Whyte
2022-05-02 09:58:53 +01:00
committed by GitHub
parent 09731a9168
commit 2c3953ae19
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs
View File

@@ -116,7 +116,7 @@ namespace Umbraco.Cms.Core.Services.Implement
var installedPackages = new Dictionary<string, InstalledPackage>();
// Collect the package from the package migration plans
foreach(PackageMigrationPlan plan in _packageMigrationPlans)
foreach (PackageMigrationPlan plan in _packageMigrationPlans)
{
if (!installedPackages.TryGetValue(plan.PackageName, out InstalledPackage? installedPackage))
{
@@ -144,7 +144,7 @@ namespace Umbraco.Cms.Core.Services.Implement
}
// Collect and merge the packages from the manifests
foreach(PackageManifest package in _manifestParser.GetManifests())
foreach (PackageManifest package in _manifestParser.GetManifests())
{
if (package.PackageName is null)
{
@@ -157,17 +157,15 @@ namespace Umbraco.Cms.Core.Services.Implement
{
PackageName = package.PackageName
};
installedPackages.Add(package.PackageName, installedPackage);
}
installedPackage.PackageView = package.PackageView;
}
// Filter the packages listed here. i.e. only packages that have migrations or views.
// Else whats the point in showing them?
return installedPackages
.Values
.Where(x => !x.PackageView.IsNullOrWhiteSpace() || x.PackageMigrationPlans.Any());
// Return all packages with a name in the package.manifest or package migrations
return installedPackages.Values;
}
#endregion