From a501ef1410c87489f172612dd42bd90f6c9b3eae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <nsl@umbraco.dk>
Date: Tue, 28 Apr 2020 08:15:57 +0200
Subject: [PATCH 1/4] spelling mistake corrected

---
 .../components/editor/umbeditorcontentheader.directive.js     | 4 ++--
 .../views/components/editor/umb-editor-content-header.html    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js
index 750159cebc..47e2b90170 100644
--- a/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js
+++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js
@@ -77,11 +77,11 @@
                         scope.vm.hasCulture = true;
                     }
                     if (variant.segment !== null) {
-                        scope.vm.hasSegment = true;
+                        scope.vm.hasSegments = true;
                     }
                 });
 
-                scope.vm.hasVariants = (scope.vm.hasCulture || scope.vm.hasSegment);
+                scope.vm.hasVariants = (scope.vm.hasCulture || scope.vm.hasSegments);
                 
                 checkErrorsOnOtherVariants();
 
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
index a17529ca79..51a942c245 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
@@ -49,7 +49,7 @@
                         <span ng-bind="editor.content.displayName"></span>
                     </span>
 
-                    <umb-dropdown ng-if="vm.dropdownOpen" class="umb-variant-switcher" ng-class="{'--has-sub-variants': vm.hasSegment === true}" on-close="vm.dropdownOpen = false" umb-keyboard-list>
+                    <umb-dropdown ng-if="vm.dropdownOpen" class="umb-variant-switcher" ng-class="{'--has-sub-variants': vm.hasSegments === true}" on-close="vm.dropdownOpen = false" umb-keyboard-list>
                         <umb-dropdown-item
                             ng-repeat-start="entry in vm.variantMenu track by $index"
                             class="umb-variant-switcher__item"

From af10bd7dfc0bc2c6818b9d2cafc6bbb9af9f4e10 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <nsl@umbraco.dk>
Date: Tue, 28 Apr 2020 08:57:09 +0200
Subject: [PATCH 2/4] default variant would never have segment. And if we work
 only with segmentation the default variant does not have language.isDefault.

---
 .../components/content/umbtabbedcontent.directive.js           | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/content/umbtabbedcontent.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/content/umbtabbedcontent.directive.js
index c703311c8e..97e837c523 100644
--- a/src/Umbraco.Web.UI.Client/src/common/directives/components/content/umbtabbedcontent.directive.js
+++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/content/umbtabbedcontent.directive.js
@@ -122,7 +122,8 @@
             this.content = $scope.content;
             if($scope.variantNodeModel) {
                 $scope.defaultVariant = _.find($scope.variantNodeModel.variants, variant => {
-                    return variant.language && variant.language.isDefault;
+                    // defaultVariant will never have segment. Wether it has a language or not depends on the setup.
+                    return !variant.segment && ((variant.language && variant.language.isDefault) || (!variant.language));
                 });
             }
             

From 92f0de30ccc21fe42413ec373049294f9f064c14 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <nsl@umbraco.dk>
Date: Tue, 28 Apr 2020 08:57:45 +0200
Subject: [PATCH 3/4] use displayName instead of language name

---
 .../infiniteeditors/rollback/rollback.html    | 20 +++++++++----------
 .../content/umb-tabbed-content.html           |  2 +-
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/rollback/rollback.html b/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/rollback/rollback.html
index 9b230410b0..e292a94606 100644
--- a/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/rollback/rollback.html
+++ b/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/rollback/rollback.html
@@ -9,9 +9,9 @@
             hide-icon="true"
             hide-description="true">
         </umb-editor-header>
-        
+
         <umb-editor-container>
-            
+
             <umb-load-indicator
                 ng-if="vm.loading">
             </umb-load-indicator>
@@ -21,21 +21,21 @@
 
                     <div ng-if="model.node.variants.length > 1">
                         <h5><localize key="general_language"></localize></h5>
-                        <select 
+                        <select
                             class="input-block-level"
                             ng-model="vm.selectedLanguage"
-                            ng-options="variant as variant.language.name for variant in model.node.variants track by variant.language.culture"
+                            ng-options="variant as variant.displayName for variant in model.node.variants track by variant.language.culture"
                             ng-change="vm.changeLanguage(vm.selectedLanguage)">
                         </select>
                     </div>
-                    
+
                     <div>
-                                            
+
                         <h5><localize key="rollback_currentVersion"></localize></h5>
                         <p>{{vm.currentVersion.name}} (Created: {{vm.currentVersion.createDate}})</p>
-                        
+
                         <h5><localize key="rollback_rollbackTo"></localize></h5>
-                        <select 
+                        <select
                             class="input-block-level"
                             ng-model="vm.selectedVersion"
                             ng-options="version.displayValue for version in vm.previousVersions track by version.versionId"
@@ -48,7 +48,7 @@
 
                         <h5>Changes</h5>
                         <small style="margin-bottom: 15px; display: block;"><localize key="rollback_diffHelp"></localize></small>
-        
+
                         <table class="table table-condensed table-bordered">
                             <tbody>
                                 <tr>
@@ -73,7 +73,7 @@
                                 </tr>
                             </tbody>
                         </table>
-        
+
                     </div>
 
                 </umb-box-content>
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/content/umb-tabbed-content.html b/src/Umbraco.Web.UI.Client/src/views/components/content/umb-tabbed-content.html
index 800e2dbfcd..d534cd77ed 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/content/umb-tabbed-content.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/content/umb-tabbed-content.html
@@ -12,7 +12,7 @@
                     ng-repeat="property in group.properties track by property.alias"
                     property="property"
                     show-inherit="propertyEditorDisabled(property)"
-                    inherits-from="defaultVariant.language.name">
+                    inherits-from="defaultVariant.displayName">
 
                     <div ng-class="{'o-40 cursor-not-allowed': propertyEditorDisabled(property) }">
                         <umb-property-editor

From a8f2acd89ffb384a4b126e1b653b32c6b9f9f582 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <nsl@umbraco.dk>
Date: Tue, 28 Apr 2020 10:12:41 +0200
Subject: [PATCH 4/4] more robust variant-picker

---
 .../components/editor/umbeditorcontentheader.directive.js     | 4 ++++
 .../views/components/editor/umb-editor-content-header.html    | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js
index 47e2b90170..618bdb19a9 100644
--- a/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js
+++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorcontentheader.directive.js
@@ -35,6 +35,7 @@
             });
             scope.vm = {};
             scope.vm.hasVariants = false;
+            scope.vm.hasSubVariants = false;
             scope.vm.hasCulture = false;
             scope.vm.hasSegments = false;
             scope.vm.dropdownOpen = false;
@@ -82,6 +83,7 @@
                 });
 
                 scope.vm.hasVariants = (scope.vm.hasCulture || scope.vm.hasSegments);
+                scope.vm.hasSubVariants = (scope.vm.hasCulture && scope.vm.hasSegments);
                 
                 checkErrorsOnOtherVariants();
 
@@ -90,6 +92,7 @@
                     angular.forEach(scope.content.variants, (v) => {
                         if (v.language !== null && v.segment === null) {
                             var variantMenuEntry = {
+                                key: String.CreateGuid(),
                                 open: v.language && v.language.culture === scope.editor.culture,
                                 variant: v,
                                 subVariants: scope.content.variants.filter( (subVariant) => subVariant.language.culture === v.language.culture && subVariant.segment !== null)
@@ -100,6 +103,7 @@
                 } else {
                     angular.forEach(scope.content.variants, (v) => {
                         scope.vm.variantMenu.push({
+                            key: String.CreateGuid(),
                             variant: v
                         });
                     });
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
index 51a942c245..3809379f1b 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
@@ -49,9 +49,9 @@
                         <span ng-bind="editor.content.displayName"></span>
                     </span>
 
-                    <umb-dropdown ng-if="vm.dropdownOpen" class="umb-variant-switcher" ng-class="{'--has-sub-variants': vm.hasSegments === true}" on-close="vm.dropdownOpen = false" umb-keyboard-list>
+                    <umb-dropdown ng-if="vm.dropdownOpen" class="umb-variant-switcher" ng-class="{'--has-sub-variants': vm.hasSubVariants === true}" on-close="vm.dropdownOpen = false" umb-keyboard-list>
                         <umb-dropdown-item
-                            ng-repeat-start="entry in vm.variantMenu track by $index"
+                            ng-repeat-start="entry in vm.variantMenu track by entry.key"
                             class="umb-variant-switcher__item"
                             ng-class="{'--current': entry.variant === editor.content, '--active': entry.variant.active && vm.dropdownOpen, '--error': variantHasError(entry.variant), '--state-notCreated':entry.variant.state==='NotCreated' && entry.variant.name == null, '--state-draft':entry.variant.state==='Draft' || (entry.variant.state==='NotCreated' && entry.variant.name != null)}"
                         >