yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename old FIXME to TODO (#13646)

Browse Source 
* Rename old FIXME to TODO, so we can track new FIXME starting v13

* Remove empty TODO
This commit is contained in:
Elitsa Marinovska
2023-01-18 12:28:54 +01:00
committed by GitHub
parent de8e307295
commit 2c8927c2e9
32 changed files with 55 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/NPocoTests/NPocoBulkInsertTests.cs
View File

@@ -16,7 +16,7 @@ using Umbraco.Extensions;
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.NPocoTests;
// FIXME: npoco - is this still appropriate?
// TODO: npoco - is this still appropriate?
[TestFixture]
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerTest)]
public class NPocoBulkInsertTests : UmbracoIntegrationTest

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/NPocoTests/NPocoFetchTests.cs
View File

@@ -310,7 +310,7 @@ public class NPocoFetchTests : UmbracoIntegrationTest
// GROUP BY zbThing1.id, zbThing1.name";
var sql = ScopeAccessor.AmbientScope.SqlContext.Sql()
.Select<Thing1Dto>()
.Append(", COUNT(zbThing2Group.groupId) AS groupCount") // FIXME:
.Append(", COUNT(zbThing2Group.groupId) AS groupCount")
.From<Thing1Dto>()
.InnerJoin<Thing2GroupDto>().On<Thing1Dto, Thing2GroupDto>((t, t2g) => t.Id == t2g.ThingId)
.GroupBy<Thing1Dto>(x => x.Id, x => x.Name);

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/PublicAccessRepositoryTest.cs
View File

@@ -191,7 +191,7 @@ public class PublicAccessRepositoryTest : UmbracoIntegrationTest
// now remove a few rules from a few of the items and then add some more, this will put things 'out of order' which
// we need to verify our sort order is working for the relator
// FIXME: no "relator" in v8?!
// TODO: no "relator" in v8?!
for (var i = 0; i < allEntries.Count; i++)
{
// all the even ones

6
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/RedirectUrlRepositoryTests.cs
View File

@@ -91,7 +91,7 @@ public class RedirectUrlRepositoryTests : UmbracoIntegrationTest
Assert.AreNotEqual(0, rurl.Id);
// FIXME: too fast = same date = key violation?
// TODO: too fast = same date = key violation?
// and... can that happen in real life?
// we don't really *care* about the IX, only supposed to make things faster...
// BUT in realife we AddOrUpdate in a trx so it should be safe, always
@@ -134,7 +134,7 @@ public class RedirectUrlRepositoryTests : UmbracoIntegrationTest
Assert.AreNotEqual(0, rurl.Id);
// FIXME: too fast = same date = key violation?
// TODO: too fast = same date = key violation?
// and... can that happen in real life?
// we don't really *care* about the IX, only supposed to make things faster...
// BUT in realife we AddOrUpdate in a trx so it should be safe, always
@@ -177,7 +177,7 @@ public class RedirectUrlRepositoryTests : UmbracoIntegrationTest
Assert.AreNotEqual(0, rurl.Id);
// FIXME: goes too fast and bam, errors, first is blah
// TODO: goes too fast and bam, errors, first is blah
rurl = new RedirectUrl
{
ContentKey = _textpage.Key,

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/SimilarNodeNameTests.cs
View File

@@ -194,7 +194,7 @@ public class SimilarNodeNameTests
new SimilarNodeName {Id = 22, Name = "Test (1) (1)"}
};
// fixme - this will yield "Test (2)" which is already in use
// TODO: this will yield "Test (2)" which is already in use
Assert.AreEqual("Test (3)", SimilarNodeName.GetUniqueName(names, 0, "Test"));
}
}

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/UserRepositoryTest.cs
View File

@@ -185,7 +185,7 @@ public class UserRepositoryTest : UmbracoIntegrationTest
// Act
var updatedItem = repository.Get(user.Id);
// FIXME: this test cannot work, user has 2 sections but the way it's created,
// TODO: this test cannot work, user has 2 sections but the way it's created,
// they don't show, so the comparison with updatedItem fails - fix!
// Assert

6
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServiceTagsTests.cs
View File

@@ -423,7 +423,7 @@ public class ContentServiceTagsTests : UmbracoIntegrationTest
propertyType.Variations = ContentVariation.Nothing;
ContentTypeService.Save(contentType);
// FIXME: This throws due to index violations
// TODO: This throws due to index violations
propertyType.Variations = ContentVariation.Culture;
ContentTypeService.Save(contentType);
@@ -555,7 +555,7 @@ public class ContentServiceTagsTests : UmbracoIntegrationTest
tags = TagService.GetTagsForEntity(content1.Id);
Assert.AreEqual(5, tags.Count());
// FIXME: tag & tree issue
// TODO: tag & tree issue
// when we publish, we 'just' publish the top one and not the ones below = fails
// what we should do is... NOT clear tags when unpublishing or trashing or...
// and just update the tag service to NOT return anything related to trashed or
@@ -620,7 +620,7 @@ public class ContentServiceTagsTests : UmbracoIntegrationTest
var tags = TagService.GetTagsForEntity(content1.Id);
Assert.AreEqual(0, tags.Count());
// FIXME: tag & tree issue
// TODO: tag & tree issue
// when we (un)publish, we 'just' publish the top one and not the ones below = fails
// see similar note above
tags = TagService.GetTagsForEntity(content2.Id);

14
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServiceTests.cs
View File

@@ -2789,13 +2789,13 @@ public class ContentServiceTests : UmbracoIntegrationTestWithContent
Assert.IsFalse(content.Published);
Assert.IsTrue(content.Edited);
// FIXME: depending on 1 line in ContentBaseFactory.BuildEntity
// TODO: depending on 1 line in ContentBaseFactory.BuildEntity
// the published infos can be gone or not
// if gone, it's not consistent with above
Assert.AreEqual(vpk, ((Content)content).VersionId);
Assert.AreEqual(ppk, ((Content)content).PublishedVersionId); // still there
// FIXME: depending on 1 line in ContentRepository.MapDtoToContent
// TODO: depending on 1 line in ContentRepository.MapDtoToContent
// the published values can be null or not
// if null, it's not consistent with above
// Assert.IsNull(content.GetValue("title", published: true));
@@ -2811,7 +2811,7 @@ public class ContentServiceTests : UmbracoIntegrationTestWithContent
//
// ContentService.SaveAndPublish(content);
// FIXME: what shall we do of all this?
// TODO: what shall we do of all this?
/*
// this basically republishes a content
// what if it never was published?
@@ -2822,11 +2822,11 @@ public class ContentServiceTests : UmbracoIntegrationTestWithContent
Assert.IsTrue(content.Published);
Assert.IsFalse(content.Edited);
// FIXME: should it be 2 or 3
// TODO: should it be 2 or 3
versions = ContentService.GetVersions(content.Id);
Assert.AreEqual(2, versions.Count());
// FIXME: now test rollbacks
// TODO: now test rollbacks
var version = ContentService.GetByVersion(content.Id); // test that it gets a version - should be GetVersion
var previousVersion = ContentService.GetVersions(content.Id).Skip(1).FirstOrDefault(); // need an optimized way to do this
content.CopyValues(version); // copies the edited value - always
@@ -2871,7 +2871,7 @@ public class ContentServiceTests : UmbracoIntegrationTestWithContent
// the name will be set to the default culture variant name
Assert.AreEqual("name-us", content.Name);
// FIXME: should we always sync the invariant name even on update? see EnsureInvariantNameValues
// TODO: should we always sync the invariant name even on update? see EnsureInvariantNameValues
////updating the default culture variant name should also update the invariant name so they stay in sync
// content.SetName("name-us-2", langUk.IsoCode);
// ContentService.Save(content);
@@ -3083,7 +3083,7 @@ public class ContentServiceTests : UmbracoIntegrationTestWithContent
ValueStorageType.Nvarchar, "prop")
{ Variations = ContentVariation.Culture });
// FIXME: add test w/ an invariant prop
// TODO: add test w/ an invariant prop
ContentTypeService.Save(contentType);
var content = ContentService.Create("Home US", Constants.System.Root, "umbTextpage");