yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename old FIXME to TODO (#13646)

Browse Source 
* Rename old FIXME to TODO, so we can track new FIXME starting v13

* Remove empty TODO
This commit is contained in:
Elitsa Marinovska
2023-01-18 12:28:54 +01:00
committed by GitHub
parent de8e307295
commit 2c8927c2e9
32 changed files with 55 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/PublicAccessRepositoryTest.cs
View File

@@ -191,7 +191,7 @@ public class PublicAccessRepositoryTest : UmbracoIntegrationTest
// now remove a few rules from a few of the items and then add some more, this will put things 'out of order' which
// we need to verify our sort order is working for the relator
// FIXME: no "relator" in v8?!
// TODO: no "relator" in v8?!
for (var i = 0; i < allEntries.Count; i++)
{
// all the even ones

6
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/RedirectUrlRepositoryTests.cs
View File

@@ -91,7 +91,7 @@ public class RedirectUrlRepositoryTests : UmbracoIntegrationTest
Assert.AreNotEqual(0, rurl.Id);
// FIXME: too fast = same date = key violation?
// TODO: too fast = same date = key violation?
// and... can that happen in real life?
// we don't really *care* about the IX, only supposed to make things faster...
// BUT in realife we AddOrUpdate in a trx so it should be safe, always
@@ -134,7 +134,7 @@ public class RedirectUrlRepositoryTests : UmbracoIntegrationTest
Assert.AreNotEqual(0, rurl.Id);
// FIXME: too fast = same date = key violation?
// TODO: too fast = same date = key violation?
// and... can that happen in real life?
// we don't really *care* about the IX, only supposed to make things faster...
// BUT in realife we AddOrUpdate in a trx so it should be safe, always
@@ -177,7 +177,7 @@ public class RedirectUrlRepositoryTests : UmbracoIntegrationTest
Assert.AreNotEqual(0, rurl.Id);
// FIXME: goes too fast and bam, errors, first is blah
// TODO: goes too fast and bam, errors, first is blah
rurl = new RedirectUrl
{
ContentKey = _textpage.Key,

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/SimilarNodeNameTests.cs
View File

@@ -194,7 +194,7 @@ public class SimilarNodeNameTests
new SimilarNodeName {Id = 22, Name = "Test (1) (1)"}
};
// fixme - this will yield "Test (2)" which is already in use
// TODO: this will yield "Test (2)" which is already in use
Assert.AreEqual("Test (3)", SimilarNodeName.GetUniqueName(names, 0, "Test"));
}
}

2
tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/UserRepositoryTest.cs
View File

@@ -185,7 +185,7 @@ public class UserRepositoryTest : UmbracoIntegrationTest
// Act
var updatedItem = repository.Get(user.Id);
// FIXME: this test cannot work, user has 2 sections but the way it's created,
// TODO: this test cannot work, user has 2 sections but the way it's created,
// they don't show, so the comparison with updatedItem fails - fix!
// Assert