From 2d00ece365e67d9932e573ab27fb520422703fa2 Mon Sep 17 00:00:00 2001 From: Emma Garland Date: Fri, 12 Feb 2021 14:38:20 +0000 Subject: [PATCH] Renamed MembersUserManager --- .../{IMembersUserManager.cs => IMemberManager.cs} | 2 +- .../MembersServiceCollectionExtensionsTests.cs | 2 +- .../AutoFixture/AutoMoqDataAttribute.cs | 2 +- .../Security/MemberIdentityUserManagerTests.cs | 10 +++++----- .../Controllers/MemberControllerUnitTests.cs | 14 +++++++------- .../Controllers/MemberController.cs | 4 ++-- .../ServiceCollectionExtensions.cs | 2 +- .../{MembersUserManager.cs => MemberManager.cs} | 4 ++-- 8 files changed, 20 insertions(+), 20 deletions(-) rename src/Umbraco.Infrastructure/Security/{IMembersUserManager.cs => IMemberManager.cs} (61%) rename src/Umbraco.Web.Common/Security/{MembersUserManager.cs => MemberManager.cs} (94%) diff --git a/src/Umbraco.Infrastructure/Security/IMembersUserManager.cs b/src/Umbraco.Infrastructure/Security/IMemberManager.cs similarity index 61% rename from src/Umbraco.Infrastructure/Security/IMembersUserManager.cs rename to src/Umbraco.Infrastructure/Security/IMemberManager.cs index a466ea2aa9..47d8a4f2fb 100644 --- a/src/Umbraco.Infrastructure/Security/IMembersUserManager.cs +++ b/src/Umbraco.Infrastructure/Security/IMemberManager.cs @@ -3,7 +3,7 @@ namespace Umbraco.Infrastructure.Security /// /// The user manager for members /// - public interface IMembersUserManager : IUmbracoUserManager + public interface IMemberManager : IUmbracoUserManager { } } diff --git a/src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/MembersServiceCollectionExtensionsTests.cs b/src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/MembersServiceCollectionExtensionsTests.cs index 8dd4bee0cf..dc730201fe 100644 --- a/src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/MembersServiceCollectionExtensionsTests.cs +++ b/src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/MembersServiceCollectionExtensionsTests.cs @@ -25,7 +25,7 @@ namespace Umbraco.Tests.Integration.Umbraco.Web.BackOffice [Test] public void AddMembersIdentity_ExpectMembersUserManagerResolvable() { - IMembersUserManager userManager = Services.GetService(); + IMemberManager userManager = Services.GetService(); Assert.NotNull(userManager); } diff --git a/src/Umbraco.Tests.UnitTests/AutoFixture/AutoMoqDataAttribute.cs b/src/Umbraco.Tests.UnitTests/AutoFixture/AutoMoqDataAttribute.cs index ca95c73345..589f2572aa 100644 --- a/src/Umbraco.Tests.UnitTests/AutoFixture/AutoMoqDataAttribute.cs +++ b/src/Umbraco.Tests.UnitTests/AutoFixture/AutoMoqDataAttribute.cs @@ -55,7 +55,7 @@ namespace Umbraco.Tests.UnitTests.AutoFixture .Customize(new ConstructorCustomization(typeof(MemberController), new GreedyConstructorQuery())) .Customize(new ConstructorCustomization(typeof(BackOfficeController), new GreedyConstructorQuery())) .Customize(new ConstructorCustomization(typeof(BackOfficeUserManager), new GreedyConstructorQuery())) - .Customize(new ConstructorCustomization(typeof(MembersUserManager), new GreedyConstructorQuery())); + .Customize(new ConstructorCustomization(typeof(MemberManager), new GreedyConstructorQuery())); fixture.Customize(new AutoMoqCustomization()); diff --git a/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberIdentityUserManagerTests.cs b/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberIdentityUserManagerTests.cs index 438f6d35bc..dd90a71180 100644 --- a/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberIdentityUserManagerTests.cs +++ b/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberIdentityUserManagerTests.cs @@ -31,7 +31,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Infrastructure.Security private Mock>> _mockLogger; private Mock> _mockPasswordConfiguration; - public MembersUserManager CreateSut() + public MemberManager CreateSut() { _mockMemberStore = new Mock>(); _mockIdentityOptions = new Mock>(); @@ -62,7 +62,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Infrastructure.Security new PasswordValidator() }; - var userManager = new MembersUserManager( + var userManager = new MemberManager( new Mock().Object, _mockMemberStore.Object, _mockIdentityOptions.Object, @@ -87,7 +87,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Infrastructure.Security public async Task GivenICreateUser_AndTheIdentityResultFailed_ThenIShouldGetAFailedResultAsync() { //arrange - MembersUserManager sut = CreateSut(); + MemberManager sut = CreateSut(); MembersIdentityUser fakeUser = new MembersIdentityUser() { PasswordConfig = "testConfig" @@ -120,7 +120,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Infrastructure.Security public async Task GivenICreateUser_AndTheUserIsNull_ThenIShouldGetAFailedResultAsync() { //arrange - MembersUserManager sut = CreateSut(); + MemberManager sut = CreateSut(); CancellationToken fakeCancellationToken = new CancellationToken() { }; IdentityError[] identityErrors = { @@ -148,7 +148,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Infrastructure.Security public async Task GivenICreateANewUser_AndTheUserIsPopulatedCorrectly_ThenIShouldGetASuccessResultAsync() { //arrange - MembersUserManager sut = CreateSut(); + MemberManager sut = CreateSut(); MembersIdentityUser fakeUser = new MembersIdentityUser() { PasswordConfig = "testConfig" diff --git a/src/Umbraco.Tests.UnitTests/Umbraco.Web.BackOffice/Controllers/MemberControllerUnitTests.cs b/src/Umbraco.Tests.UnitTests/Umbraco.Web.BackOffice/Controllers/MemberControllerUnitTests.cs index c3d3657a16..c69d1365ed 100644 --- a/src/Umbraco.Tests.UnitTests/Umbraco.Web.BackOffice/Controllers/MemberControllerUnitTests.cs +++ b/src/Umbraco.Tests.UnitTests/Umbraco.Web.BackOffice/Controllers/MemberControllerUnitTests.cs @@ -64,7 +64,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers [Test] [AutoMoqData] public void PostSaveMember_WhenModelStateIsNotValid_ExpectFailureResponse( - [Frozen] IMembersUserManager umbracoMembersUserManager, + [Frozen] IMemberManager umbracoMembersUserManager, IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, @@ -99,7 +99,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers [Test] [AutoMoqData] public async Task PostSaveMember_SaveNew_NoCustomField_WhenAllIsSetupCorrectly_ExpectSuccessResponse( - [Frozen] IMembersUserManager umbracoMembersUserManager, + [Frozen] IMemberManager umbracoMembersUserManager, IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, @@ -137,7 +137,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers [Test] [AutoMoqData] public async Task PostSaveMember_SaveNew_CustomField_WhenAllIsSetupCorrectly_ExpectSuccessResponse( - [Frozen] IMembersUserManager umbracoMembersUserManager, + [Frozen] IMemberManager umbracoMembersUserManager, IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, @@ -176,7 +176,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers [Test] [AutoMoqData] public async Task PostSaveMember_SaveExisting_WhenAllIsSetupCorrectly_ExpectSuccessResponse( - [Frozen] IMembersUserManager umbracoMembersUserManager, + [Frozen] IMemberManager umbracoMembersUserManager, IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, @@ -222,7 +222,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers [Test] [AutoMoqData] public void PostSaveMember_SaveNew_WhenMemberEmailAlreadyExists_ExpectFailResponse( - [Frozen] IMembersUserManager umbracoMembersUserManager, + [Frozen] IMemberManager umbracoMembersUserManager, IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, @@ -261,7 +261,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers [Test] [AutoMoqData] public async Task PostSaveMember_SaveExistingMember_WithNoRoles_Add1Role_ExpectSuccessResponse( - [Frozen] IMembersUserManager umbracoMembersUserManager, + [Frozen] IMemberManager umbracoMembersUserManager, IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, @@ -330,7 +330,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Web.BackOffice.Controllers IMemberService memberService, IMemberTypeService memberTypeService, IMemberGroupService memberGroupService, - IMembersUserManager membersUserManager, + IMemberManager membersUserManager, IDataTypeService dataTypeService, IBackOfficeSecurityAccessor backOfficeSecurityAccessor) { diff --git a/src/Umbraco.Web.BackOffice/Controllers/MemberController.cs b/src/Umbraco.Web.BackOffice/Controllers/MemberController.cs index c58b9aa1ee..fa8788f14d 100644 --- a/src/Umbraco.Web.BackOffice/Controllers/MemberController.cs +++ b/src/Umbraco.Web.BackOffice/Controllers/MemberController.cs @@ -50,7 +50,7 @@ namespace Umbraco.Web.BackOffice.Controllers private readonly UmbracoMapper _umbracoMapper; private readonly IMemberService _memberService; private readonly IMemberTypeService _memberTypeService; - private readonly IMembersUserManager _memberManager; + private readonly IMemberManager _memberManager; private readonly IDataTypeService _dataTypeService; private readonly ILocalizedTextService _localizedTextService; private readonly IBackOfficeSecurityAccessor _backOfficeSecurityAccessor; @@ -83,7 +83,7 @@ namespace Umbraco.Web.BackOffice.Controllers UmbracoMapper umbracoMapper, IMemberService memberService, IMemberTypeService memberTypeService, - IMembersUserManager memberManager, + IMemberManager memberManager, IDataTypeService dataTypeService, IBackOfficeSecurityAccessor backOfficeSecurityAccessor, IJsonSerializer jsonSerializer) diff --git a/src/Umbraco.Web.BackOffice/DependencyInjection/ServiceCollectionExtensions.cs b/src/Umbraco.Web.BackOffice/DependencyInjection/ServiceCollectionExtensions.cs index 56ab6a904d..4aa6fc96c1 100644 --- a/src/Umbraco.Web.BackOffice/DependencyInjection/ServiceCollectionExtensions.cs +++ b/src/Umbraco.Web.BackOffice/DependencyInjection/ServiceCollectionExtensions.cs @@ -45,7 +45,7 @@ namespace Umbraco.Web.BackOffice.DependencyInjection services.BuildMembersIdentity() .AddDefaultTokenProviders() .AddUserStore() - .AddMembersUserManager(); + .AddMembersUserManager(); private static BackOfficeIdentityBuilder BuildUmbracoBackOfficeIdentity(this IServiceCollection services) { diff --git a/src/Umbraco.Web.Common/Security/MembersUserManager.cs b/src/Umbraco.Web.Common/Security/MemberManager.cs similarity index 94% rename from src/Umbraco.Web.Common/Security/MembersUserManager.cs rename to src/Umbraco.Web.Common/Security/MemberManager.cs index 51206bce61..a4c8ca10bd 100644 --- a/src/Umbraco.Web.Common/Security/MembersUserManager.cs +++ b/src/Umbraco.Web.Common/Security/MemberManager.cs @@ -17,11 +17,11 @@ using Umbraco.Web.Models.ContentEditing; namespace Umbraco.Web.Common.Security { - public class MembersUserManager : UmbracoUserManager, IMembersUserManager + public class MemberManager : UmbracoUserManager, IMemberManager { private readonly IHttpContextAccessor _httpContextAccessor; - public MembersUserManager( + public MemberManager( IIpResolver ipResolver, IUserStore store, IOptions optionsAccessor,