From 2f21c55c93d268af005fd9226f02b969e5dfdaae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Mon, 19 Aug 2024 11:46:28 +0200 Subject: [PATCH] fix linting --- src/Umbraco.Web.UI.Client/src/packages/media/media/types.ts | 2 ++ .../src/packages/members/member-type/types.ts | 3 +++ .../src/packages/members/member/types.ts | 2 ++ .../views/section-view-examine-searchers.ts | 6 ++++-- .../tags/components/tags-input/tags-input.element.ts | 6 +++++- .../templating-page-field-builder-modal.token.ts | 1 + .../templating-section-picker-modal.token.ts | 1 + .../input-entity-user-permission.element.ts | 6 +++++- .../src/packages/user/user/collection/repository/types.ts | 1 + 9 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/types.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/types.ts index a350ead8dd..b54b08659e 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/types.ts @@ -20,6 +20,7 @@ export interface UmbMediaUrlInfoModel { url: string; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaVariantModel extends UmbVariantModel {} export interface UmbMediaValueModel { @@ -29,6 +30,7 @@ export interface UmbMediaValueModel { value: ValueType; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaVariantOptionModel extends UmbVariantOptionModel {} export type * from './property-editors/types.js'; diff --git a/src/Umbraco.Web.UI.Client/src/packages/members/member-type/types.ts b/src/Umbraco.Web.UI.Client/src/packages/members/member-type/types.ts index c17ebcebe6..eb9d6939fd 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/members/member-type/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/members/member-type/types.ts @@ -10,8 +10,11 @@ export interface UmbMemberTypeDetailModel extends UmbContentTypeModel { entityType: UmbMemberTypeEntityType; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMemberTypeAvailableCompositionRequestModel extends UmbContentTypeAvailableCompositionRequestModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMemberTypeCompositionCompatibleModel extends UmbContentTypeCompositionCompatibleModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMemberTypeCompositionReferenceModel extends UmbContentTypeCompositionReferenceModel {} diff --git a/src/Umbraco.Web.UI.Client/src/packages/members/member/types.ts b/src/Umbraco.Web.UI.Client/src/packages/members/member/types.ts index fc724221e0..0e6c4bfb12 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/members/member/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/members/member/types.ts @@ -21,6 +21,7 @@ export interface UmbMemberDetailModel { variants: Array; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMemberVariantModel extends UmbVariantModel {} export interface UmbMemberValueModel { @@ -30,4 +31,5 @@ export interface UmbMemberValueModel { value: ValueType; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMemberVariantOptionModel extends UmbVariantOptionModel {} diff --git a/src/Umbraco.Web.UI.Client/src/packages/search/examine-management-dashboard/views/section-view-examine-searchers.ts b/src/Umbraco.Web.UI.Client/src/packages/search/examine-management-dashboard/views/section-view-examine-searchers.ts index 32f86e0e6b..441d5b90b8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/search/examine-management-dashboard/views/section-view-examine-searchers.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/search/examine-management-dashboard/views/section-view-examine-searchers.ts @@ -34,7 +34,9 @@ export class UmbDashboardExamineSearcherElement extends UmbLitElement { private _workspacePath = 'aa'; private _onKeyPress(e: KeyboardEvent) { - e.key == 'Enter' ? this._onSearch() : undefined; + if (e.key == 'Enter') { + this._onSearch(); + } } #entityType = ''; @@ -80,7 +82,7 @@ export class UmbDashboardExamineSearcherElement extends UmbLitElement { return field.name ?? ''; }); - // TODO: I don't get this code, not sure what the purpose is, it seems like a mistake: + // TODO: I don't get this code, not sure what the purpose is, it seems like a mistake: [NL] this._exposedFields = this._exposedFields ? this._exposedFields.filter((field) => { return { name: field.name, exposed: field.exposed }; diff --git a/src/Umbraco.Web.UI.Client/src/packages/tags/components/tags-input/tags-input.element.ts b/src/Umbraco.Web.UI.Client/src/packages/tags/components/tags-input/tags-input.element.ts index 7cb6b4774d..bbe9e20bae 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/tags/components/tags-input/tags-input.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/tags/components/tags-input/tags-input.element.ts @@ -145,7 +145,11 @@ export class UmbTagsInputElement extends UUIFormControlMixin(UmbLitElement, '') const currentItems = [...this.items]; const index = currentItems.findIndex((x) => x === tag); currentItems.splice(index, 1); - currentItems.length ? (this.items = [...currentItems]) : (this.items = []); + if (currentItems.length) { + this.items = currentItems; + } else { + this.items = []; + } this.dispatchEvent(new CustomEvent('change', { bubbles: true, composed: true })); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-page-field-builder/templating-page-field-builder-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-page-field-builder/templating-page-field-builder-modal.token.ts index ad621e61b5..b7785f79c2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-page-field-builder/templating-page-field-builder-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-page-field-builder/templating-page-field-builder-modal.token.ts @@ -1,5 +1,6 @@ import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbTemplatingPageFieldBuilderModalData {} export type UmbTemplatingPageFieldBuilderModalValue = { diff --git a/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-section-picker/templating-section-picker-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-section-picker/templating-section-picker-modal.token.ts index f84440d46e..7b0ae37814 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-section-picker/templating-section-picker-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/templating/modals/templating-section-picker/templating-section-picker-modal.token.ts @@ -1,5 +1,6 @@ import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbTemplatingSectionPickerModalData {} export type UmbTemplatingSectionPickerModalValue = { diff --git a/src/Umbraco.Web.UI.Client/src/packages/user/user-permission/components/input-entity-user-permission/input-entity-user-permission.element.ts b/src/Umbraco.Web.UI.Client/src/packages/user/user-permission/components/input-entity-user-permission/input-entity-user-permission.element.ts index 1c4bdb5fa8..03bcf4fae6 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/user/user-permission/components/input-entity-user-permission/input-entity-user-permission.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/user/user-permission/components/input-entity-user-permission/input-entity-user-permission.element.ts @@ -53,7 +53,11 @@ export class UmbInputEntityUserPermissionElement extends UmbFormControlMixin(Umb #onChangeUserPermission(event: UmbChangeEvent, permissionVerbs: Array) { event.stopPropagation(); const target = event.target as UmbUserPermissionVerbElement; - target.allowed ? this.#addUserPermission(permissionVerbs) : this.#removeUserPermission(permissionVerbs); + if (target.allowed) { + this.#addUserPermission(permissionVerbs); + } else { + this.#removeUserPermission(permissionVerbs); + } } #addUserPermission(permissionVerbs: Array) { diff --git a/src/Umbraco.Web.UI.Client/src/packages/user/user/collection/repository/types.ts b/src/Umbraco.Web.UI.Client/src/packages/user/user/collection/repository/types.ts index 74b0522535..b73f0f6468 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/user/user/collection/repository/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/user/user/collection/repository/types.ts @@ -2,5 +2,6 @@ import type { UmbUserDetailModel } from '../../types.js'; import type { UmbUserCollectionFilterModel } from '../types.js'; import type { UmbCollectionDataSource } from '@umbraco-cms/backoffice/collection'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbUserCollectionDataSource extends UmbCollectionDataSource {}