diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/code-editor/code-editor-modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/code-editor/code-editor-modal.element.ts index eac68b2669..4543be8268 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/code-editor/code-editor-modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/code-editor/code-editor-modal.element.ts @@ -1,22 +1,17 @@ import { css, html, ifDefined, customElement, query } from '@umbraco-cms/backoffice/external/lit'; -import { loadCodeEditor, type UmbCodeEditorElement } from '@umbraco-cms/backoffice/code-editor'; -import type { UmbCodeEditorModalData, UmbCodeEditorModalValue } from '@umbraco-cms/backoffice/modal'; import { UmbModalBaseElement } from '@umbraco-cms/backoffice/modal'; -import { UmbBooleanState } from '@umbraco-cms/backoffice/observable-api'; +import type { UmbCodeEditorElement } from '@umbraco-cms/backoffice/code-editor'; +import type { UmbCodeEditorModalData, UmbCodeEditorModalValue } from '@umbraco-cms/backoffice/modal'; -@customElement('umb-code-editor-modal') +import '@umbraco-cms/backoffice/code-editor'; + +const elementName = 'umb-code-editor-modal'; + +@customElement(elementName) export class UmbCodeEditorModalElement extends UmbModalBaseElement { - #isCodeEditorReady = new UmbBooleanState(false); - isCodeEditorReady = this.#isCodeEditorReady.asObservable(); - @query('umb-code-editor') _codeEditor?: UmbCodeEditorElement; - constructor() { - super(); - this.#loadCodeEditor(); - } - #handleConfirm() { this.value = { content: this._codeEditor?.editor?.monacoEditor?.getValue() ?? '' }; this.modalContext?.submit(); @@ -25,34 +20,15 @@ export class UmbCodeEditorModalElement extends UmbModalBaseElement`; - } - - #renderLoading() { - return html`
- -
`; - } - override render() { return html` -
${this.isCodeEditorReady ? this.#renderCodeEditor() : this.#renderLoading()}
+
${this.#renderCodeEditor()}
- Cancel + + `; + } + static override styles = [ css` #editor-box { @@ -83,6 +65,6 @@ export default UmbCodeEditorModalElement; declare global { interface HTMLElementTagNameMap { - 'umb-code-editor-modal': UmbCodeEditorModalElement; + [elementName]: UmbCodeEditorModalElement; } }