From 30e165f0ca681b51764a0a21c60c8247efc36354 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Mon, 20 Mar 2023 12:51:52 +0100 Subject: [PATCH] type fixes --- .../extensions-api/registry/extension.registry.test.ts | 4 ++-- .../src/backoffice/members/section.manifests.ts | 7 +------ .../workspace/extension-root-workspace.element.ts | 6 +++--- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/libs/extensions-api/registry/extension.registry.test.ts b/src/Umbraco.Web.UI.Client/libs/extensions-api/registry/extension.registry.test.ts index 8fe49a7a8d..e5bcd2979e 100644 --- a/src/Umbraco.Web.UI.Client/libs/extensions-api/registry/extension.registry.test.ts +++ b/src/Umbraco.Web.UI.Client/libs/extensions-api/registry/extension.registry.test.ts @@ -118,7 +118,7 @@ describe('UmbExtensionRegistry with kinds', () => { }, { type: 'section', - kind: 'test-kind', + kind: 'test-kind' as unknown as undefined, // We do not know about this one, so it makes good sense that its not a valid option. name: 'test-section-1', alias: 'Umb.Test.Section.1', weight: 1, @@ -139,7 +139,7 @@ describe('UmbExtensionRegistry with kinds', () => { }, { type: 'section', - kind: 'test-kind', + kind: 'test-kind' as unknown as undefined, // We do not know about this one, so it makes good sense that its not a valid option. name: 'test-section-3', alias: 'Umb.Test.Section.3', weight: 25, diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/members/section.manifests.ts b/src/Umbraco.Web.UI.Client/src/backoffice/members/section.manifests.ts index 6437e11bb3..eacefe6606 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/members/section.manifests.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/members/section.manifests.ts @@ -1,9 +1,4 @@ -import type { - ManifestDashboard, - ManifestSection, - ManifestMenuSectionSidebarApp, - ManifestTypes, -} from '@umbraco-cms/models'; +import type { ManifestDashboard, ManifestSection, ManifestTypes } from '@umbraco-cms/models'; const sectionAlias = 'Umb.Section.Members'; diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/settings/extensions/workspace/extension-root-workspace.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/settings/extensions/workspace/extension-root-workspace.element.ts index 218da0a48f..9dcf9c2f7a 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/settings/extensions/workspace/extension-root-workspace.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/settings/extensions/workspace/extension-root-workspace.element.ts @@ -3,14 +3,14 @@ import { customElement, state } from 'lit/decorators.js'; import { map } from 'rxjs'; import { UMB_CONFIRM_MODAL_TOKEN } from '../../../shared/modals/confirm'; import { isManifestElementNameType, umbExtensionsRegistry } from '@umbraco-cms/extensions-api'; -import type { ManifestBase } from '@umbraco-cms/models'; +import type { ManifestTypes } from '@umbraco-cms/models'; import { UmbLitElement } from '@umbraco-cms/element'; import { UmbModalContext, UMB_MODAL_CONTEXT_TOKEN } from '@umbraco-cms/modal'; @customElement('umb-extension-root-workspace') export class UmbExtensionRootWorkspaceElement extends UmbLitElement { @state() - private _extensions?: Array = undefined; + private _extensions?: Array = undefined; private _modalContext?: UmbModalContext; @@ -43,7 +43,7 @@ export class UmbExtensionRootWorkspaceElement extends UmbLitElement { ); } - async #removeExtension(extension: ManifestBase) { + async #removeExtension(extension: ManifestTypes) { const modalHandler = this._modalContext?.open(UMB_CONFIRM_MODAL_TOKEN, { headline: 'Unload extension', confirmLabel: 'Unload',