U4-7083 - filesystems, polish, fix, and back-compat

2015-09-10 14:10:45 +02:00
parent 8b612a1047
commit 3314ab026b
7 changed files with 323 additions and 32 deletions
--- a/src/Umbraco.Tests/Persistence/Repositories/PartialViewRepositoryTests.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/PartialViewRepositoryTests.cs
@@ -0,0 +1,119 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using NUnit.Framework;
+using Umbraco.Core.IO;
+using Umbraco.Core.Models;
+using Umbraco.Core.Persistence.Repositories;
+using Umbraco.Core.Persistence.UnitOfWork;
+using Umbraco.Tests.TestHelpers;
+
+namespace Umbraco.Tests.Persistence.Repositories
+{
+    [TestFixture]
+    public class PartialViewRepositoryTests : BaseUmbracoApplicationTest
+    {
+        private IFileSystem _fileSystem;
+
+        [SetUp]
+        public override void Initialize()
+        {
+            base.Initialize();
+
+            _fileSystem = new PhysicalFileSystem(SystemDirectories.MvcViews + "/Partials/");
+        }
+
+        [Test]
+        public void PathTests()
+        {
+            // unless noted otherwise, no changes / 7.2.8
+
+            var provider = new FileUnitOfWorkProvider();
+            var unitOfWork = provider.GetUnitOfWork();
+            var repository = new PartialViewRepository(unitOfWork, _fileSystem);
+
+            var partialView = new PartialView("test-path-1.cshtml") { Content = "// partialView" };
+            repository.AddOrUpdate(partialView);
+            unitOfWork.Commit();
+            Assert.IsTrue(_fileSystem.FileExists("test-path-1.cshtml"));
+            Assert.AreEqual("test-path-1.cshtml", partialView.Path);
+            Assert.AreEqual("/Views/Partials/test-path-1.cshtml", partialView.VirtualPath);
+
+            partialView = new PartialView("path-2/test-path-2.cshtml") { Content = "// partialView" };
+            repository.AddOrUpdate(partialView);
+            unitOfWork.Commit();
+            Assert.IsTrue(_fileSystem.FileExists("path-2/test-path-2.cshtml"));
+            Assert.AreEqual("path-2\\test-path-2.cshtml", partialView.Path); // fixed in 7.3 - 7.2.8 does not update the path
+            Assert.AreEqual("/Views/Partials/path-2/test-path-2.cshtml", partialView.VirtualPath);
+
+            partialView = (PartialView) repository.Get("path-2/test-path-2.cshtml");
+            Assert.IsNotNull(partialView);
+            Assert.AreEqual("path-2\\test-path-2.cshtml", partialView.Path);
+            Assert.AreEqual("/Views/Partials/path-2/test-path-2.cshtml", partialView.VirtualPath);
+
+            partialView = new PartialView("path-2\\test-path-3.cshtml") { Content = "// partialView" };
+            repository.AddOrUpdate(partialView);
+            unitOfWork.Commit();
+            Assert.IsTrue(_fileSystem.FileExists("path-2/test-path-3.cshtml"));
+            Assert.AreEqual("path-2\\test-path-3.cshtml", partialView.Path);
+            Assert.AreEqual("/Views/Partials/path-2/test-path-3.cshtml", partialView.VirtualPath);
+
+            partialView = (PartialView) repository.Get("path-2/test-path-3.cshtml");
+            Assert.IsNotNull(partialView);
+            Assert.AreEqual("path-2\\test-path-3.cshtml", partialView.Path);
+            Assert.AreEqual("/Views/Partials/path-2/test-path-3.cshtml", partialView.VirtualPath);
+
+            partialView = (PartialView) repository.Get("path-2\\test-path-3.cshtml");
+            Assert.IsNotNull(partialView);
+            Assert.AreEqual("path-2\\test-path-3.cshtml", partialView.Path);
+            Assert.AreEqual("/Views/Partials/path-2/test-path-3.cshtml", partialView.VirtualPath);
+
+            partialView = new PartialView("\\test-path-4.cshtml") { Content = "// partialView" };
+            Assert.Throws<FileSecurityException>(() => // fixed in 7.3 - 7.2.8 used to strip the \
+            {
+                repository.AddOrUpdate(partialView);
+            });
+
+            partialView = (PartialView) repository.Get("missing.cshtml");
+            Assert.IsNull(partialView);
+
+            // fixed in 7.3 - 7.2.8 used to...
+            Assert.Throws<FileSecurityException>(() =>
+            {
+                partialView = (PartialView) repository.Get("\\test-path-4.cshtml"); // outside the filesystem, does not exist
+            });
+            Assert.Throws<FileSecurityException>(() =>
+            {
+                partialView = (PartialView) repository.Get("../../packages.config"); // outside the filesystem, exists
+            });
+        }
+
+        [TearDown]
+        public override void TearDown()
+        {
+            base.TearDown();
+
+            //Delete all files
+            Purge((PhysicalFileSystem)_fileSystem, "");
+            _fileSystem = null;
+        }
+
+        private void Purge(PhysicalFileSystem fs, string path)
+        {
+            var files = fs.GetFiles(path, "*.cshtml");
+            foreach (var file in files)
+            {
+                fs.DeleteFile(file);
+            }
+            var dirs = fs.GetDirectories(path);
+            foreach (var dir in dirs)
+            {
+                Purge(fs, dir);
+                fs.DeleteDirectory(dir);
+            }
+        }
+    }
+}