From 339db3eb6f6b0589b5f98f4f7ce05b52baecca56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Wed, 25 Jan 2023 16:25:34 +0100 Subject: [PATCH] optional destroy on context instances --- .../libs/context-api/provide/context-provider.controller.ts | 1 + .../libs/context-api/provide/context-provider.ts | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.controller.ts b/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.controller.ts index 88bebc98d2..f5ec707687 100644 --- a/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.controller.ts +++ b/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.controller.ts @@ -20,6 +20,7 @@ export class UmbContextProviderController } public destroy() { + super.destroy(); if (this.host) { this.host.removeController(this); } diff --git a/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.ts b/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.ts index f883c75c6a..ddad843889 100644 --- a/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.ts +++ b/src/Umbraco.Web.UI.Client/libs/context-api/provide/context-provider.ts @@ -53,4 +53,10 @@ export class UmbContextProvider { event.stopPropagation(); event.callback(this.#instance); }; + + + destroy(): void { + // I want to make sure to call this, but for now it was too overwhelming to require the destroy method on context instances. + (this.#instance as any).destroy?.(); + }; }