From 3427f596e3844b87a41602fcaf8a12b24664a3b8 Mon Sep 17 00:00:00 2001 From: Shannon Date: Tue, 25 Mar 2014 13:07:16 +1100 Subject: [PATCH] fixes up a few notes. --- src/Umbraco.Web/Editors/ContentTypeController.cs | 12 ++++++------ .../Models/Mapping/TabsAndPropertiesResolver.cs | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Umbraco.Web/Editors/ContentTypeController.cs b/src/Umbraco.Web/Editors/ContentTypeController.cs index 94574a7f75..342ca7ea5a 100644 --- a/src/Umbraco.Web/Editors/ContentTypeController.cs +++ b/src/Umbraco.Web/Editors/ContentTypeController.cs @@ -26,7 +26,7 @@ namespace Umbraco.Web.Editors [PluginController("UmbracoApi")] public class ContentTypeController : UmbracoAuthorizedJsonController { - private ICultureDictionary cultureDictionary; + private ICultureDictionary _cultureDictionary; /// /// Constructor @@ -52,7 +52,7 @@ namespace Umbraco.Web.Editors public IEnumerable GetAllowedChildren(int contentId) { IEnumerable types; - if (contentId == Core.Constants.System.Root) + if (contentId == Constants.System.Root) { types = Services.ContentTypeService.GetAllContentTypes().ToList(); @@ -83,10 +83,10 @@ namespace Umbraco.Web.Editors return basics; } - // This should really be centralized and used anywhere globalization applies. + // TODO: This should really be centralized and used anywhere globalization applies. internal string TranslateItem(string text) { - if (!text.StartsWith("#")) + if (text.StartsWith("#") == false) return text; text = text.Substring(1); @@ -98,8 +98,8 @@ namespace Umbraco.Web.Editors get { return - cultureDictionary ?? - (cultureDictionary = CultureDictionaryFactoryResolver.Current.Factory.CreateDictionary()); + _cultureDictionary ?? + (_cultureDictionary = CultureDictionaryFactoryResolver.Current.Factory.CreateDictionary()); } } } diff --git a/src/Umbraco.Web/Models/Mapping/TabsAndPropertiesResolver.cs b/src/Umbraco.Web/Models/Mapping/TabsAndPropertiesResolver.cs index 95a46b0e27..b95802e086 100644 --- a/src/Umbraco.Web/Models/Mapping/TabsAndPropertiesResolver.cs +++ b/src/Umbraco.Web/Models/Mapping/TabsAndPropertiesResolver.cs @@ -16,7 +16,7 @@ namespace Umbraco.Web.Models.Mapping /// internal class TabsAndPropertiesResolver : ValueResolver>> { - private ICultureDictionary cultureDictionary; + private ICultureDictionary _cultureDictionary; protected IEnumerable IgnoreProperties { get; set; } public TabsAndPropertiesResolver() @@ -207,7 +207,7 @@ namespace Umbraco.Web.Models.Mapping return aggregateTabs; } - // This should really be centralized and used anywhere globalization applies. + // TODO: This should really be centralized and used anywhere globalization applies. internal string TranslateItem(string text) { var cultureDictionary = CultureDictionary; @@ -216,7 +216,7 @@ namespace Umbraco.Web.Models.Mapping private static string TranslateItem(string text, ICultureDictionary cultureDictionary) { - if (!text.StartsWith("#")) + if (text.StartsWith("#") == false) return text; text = text.Substring(1); @@ -228,8 +228,8 @@ namespace Umbraco.Web.Models.Mapping get { return - cultureDictionary ?? - (cultureDictionary = CreateDictionary()); + _cultureDictionary ?? + (_cultureDictionary = CreateDictionary()); } }